Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2] usb: core: introduce per-port over-current counters
To:     Greg KH <gregkh@linuxfoundation.org>,
        Richard Leitner <dev@g0hl1n.net>
CC:     <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <stern@rowland.harvard.edu>, <linux@roeck-us.net>,
        <mathias.nyman@linux.intel.com>, <johan@kernel.org>,
        <felipe.balbi@linux.intel.com>, <ekorenevsky@gmail.com>,
        <peter.chen@nxp.com>, <drake@endlessm.com>, <joe@perches.com>
References: <20180220115033.29496-1-dev@g0hl1n.net>
 <20180309171921.GA30438@kroah.com>
From:   Richard Leitner <richard.leitner@skidata.com>
Message-ID: <1485535c-ee0a-c25c-7f1f-5c0e8ede6b45@skidata.com>
Date:   Tue, 13 Mar 2018 11:20:53 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <20180309171921.GA30438@kroah.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Greg,

On 03/09/2018 06:19 PM, Greg KH wrote:
>> diff --git a/Documentation/ABI/testing/sysfs-bus-usb b/Documentation/ABI/testing/sysfs-bus-usb
>> index 0bd731cbb50c..27020293c85b 100644
>> --- a/Documentation/ABI/testing/sysfs-bus-usb
>> +++ b/Documentation/ABI/testing/sysfs-bus-usb
>> @@ -189,6 +189,15 @@ Description:
>>  		The file will read "hotplug", "wired" and "not used" if the
>>  		information is available, and "unknown" otherwise.
>>  
>> +What:		/sys/bus/usb/devices/.../(hub interface)/portX/over_current_count
>> +Date:		February 2018
>> +Contact:	Richard Leitner <richard.leitner@skidata.com>
>> +Description:
>> +		Most hubs are able to detect over-current situations on their
>> +		ports and report them to the kernel. This attribute is to expose
>> +		the number of over-current situation occurred on a specific port
>> +		to user space. This file will contain an unsigned int.
> "unsigned int" is very vague :)
> 
> How about "this is a 32bit value"?
> 
> And what happens when this wraps?  Is that allowed?

Thank you for your feedback. I'll improve the description for v3!

> 
> thanks,
> 
> greg k-h

regards;Richard.L