Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 13 Mar 2018 16:35:26 +0530
From:   Ajay Singh <ajay.kathat@microchip.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC:     <hariprasath.elango@gmail.com>, <linux-kernel@vger.kernel.org>,
        <devel@driverdev.osuosl.org>, <vbabu3@visteon.com>,
        <linux-wireless@vger.kernel.org>,
        Ganesh Krishna <ganesh.krishna@microchip.com>,
        <aditya.shankar@microchip.com>
Subject: Re: [PATCHv2] staging: wilc1000: use pre-defined macro
 is_broadcast_ether_addr
Message-ID: <20180313163526.617216de@ajaysk-VirtualBox>
In-Reply-To: <20180313095816.GA1656@kroah.com>
References: <20180312093903.9147-1-hariprasath.elango@gmail.com>
        <20180313130051.43b087dd@ajaysk-VirtualBox>
        <20180313095816.GA1656@kroah.com>
Organization: Microchip Techonology
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 13 Mar 2018 10:58:16 +0100
Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:

> On Tue, Mar 13, 2018 at 01:00:51PM +0530, Ajay Singh wrote:
> > 
> > Reviewed-by: Ajay Singh <ajay.kathat@microchip.com>
> > 
> > On Mon, 12 Mar 2018 15:09:03 +0530
> > <hariprasath.elango@gmail.com> wrote:
> >   
> > > From: HariPrasath Elango <hariprasath.elango@gmail.com>
> > >  
> > 
> > Please avoid use of 'From' tag specially when there is only one
> > 'Signed-off-by' tag and its same.  
> 
> But the email client isn't putting the correct info in the email header,
> so this line is needed.
> 
> And if it's redundant, not a problem, git handles it just fine, better
> to be safe.


Thanks Greg, for giving the information.
In that case, we can keep the 'From:' tag to be on safe side.


Regards,
Ajay