Received: by 10.213.65.68 with SMTP id h4csp313619imn; Tue, 13 Mar 2018 05:21:29 -0700 (PDT) X-Google-Smtp-Source: AG47ELufowdyUZLr6KD37T0OLaiel0gNUlHkzLlow8hV2EXL00II8USMrvgMhDJX6qZ4c4uygryH X-Received: by 10.99.166.10 with SMTP id t10mr355229pge.198.1520943689468; Tue, 13 Mar 2018 05:21:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1520943689; cv=none; d=google.com; s=arc-20160816; b=lu62TSgySlByFkOzk2sgdV53HdNTrP9fAaG2irNG1iPKkF0gablqUUEz5atnRagNVT cfPDL0Jmgvme6cmYGGF7zibKaIKN2RwwK6oBpnHcm5cNSg7SAVwkDlW0RjmM1frSFg5u gBzR55AhYO6yX4+zJFB7wnwAy++KzZ4RMAB1T2WpALM4/titdxcv22/k+xIQDnl6fTBm s7b6y2s/C3JddNpEASDTPy6k9dXcKwaQxXu+cFHjPBJLVkVsxykrV5AZvwwOjzt1Y6sd vferL2cnKy5afHv6v/uvg3kKg4/R1oA6a3WRmrr9NYvj0BKZ8cSXCNmwAkxopyVyLWiB Dpcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=ebRn9TTAU9jbTE4nhlv428FKE5T5U9QA+2TGXyh1rbk=; b=dInkoM+B7yAZpTAfQ827+e+OOlBwGL8qgqj3/vklahjfl3woeCtFFtZrfqw9jmSGyU GYksqT261gwUG8/Oq2GPXLfUATjVClzQqG+fnTs1hk3jBnDApzzsw5h5NtNJsEGkm+Yu 5535NSG+h5FUHPbjzYQKj+fhHuk5O7J5aKUOpMA2h1MbSLOLXzZzXcJpHrd1Tp5yPlvn heIj0iAl76VqN/5X+YMTIMy6uwysR5/jLzg/7HqqM+/xuU7U8vrDt6+ScoY785Nw843W YKe82tZl6tlCZmY+/odW8EEshQp9uTvkoqWRbp+ZiQ1J++Wh8R6H4nrQPyDBMPfIM9F0 6ivQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m12-v6si42128pll.549.2018.03.13.05.21.14; Tue, 13 Mar 2018 05:21:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932839AbeCMMSH (ORCPT + 99 others); Tue, 13 Mar 2018 08:18:07 -0400 Received: from mail-wr0-f176.google.com ([209.85.128.176]:42515 "EHLO mail-wr0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752395AbeCMMSG (ORCPT ); Tue, 13 Mar 2018 08:18:06 -0400 Received: by mail-wr0-f176.google.com with SMTP id s18so8096701wrg.9 for ; Tue, 13 Mar 2018 05:18:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=ebRn9TTAU9jbTE4nhlv428FKE5T5U9QA+2TGXyh1rbk=; b=l1h7F0ZxW5qz+Au6gCfCt+QMACGhUaiJ0bS3fpHZ3pMPSOExdo9VHrQrXYYJ/mxcfW KrT7RNLcC8DHV9kBv4/3A/XNGVUHPAFm8g+nhfLqhzPG291DCgeK46/T4RkkB/BmEbaF 7buDi8EwQynTJqbB6buwdW+EI9tcghtQg3aTypWhoZXzaJgorO0QdT0N7uZu/HI3Vuii BK+m9B+aePfVTbrnOxmX8saRJ4PvB5tWqCu94Feo11rmim8tMJMTLEnfp1spd7/iko40 GPzYHHXzLlHOG9zPkyCbcrL3MgICMmoZuvIOqD0UDjILWWyO+FH8Yqgr/WUe9fMDrtxh h51g== X-Gm-Message-State: AElRT7HoRXqtbhOLuKg4cB1v9W55ePi3BNUUVycD/qDevlaiXpJ8DuRs Dd9jOk4wZCW9dAccrDHR72A= X-Received: by 10.223.226.1 with SMTP id j1mr416647wri.13.1520943484619; Tue, 13 Mar 2018 05:18:04 -0700 (PDT) Received: from localhost.localdomain (u-087-c077.eap.uni-tuebingen.de. [134.2.87.77]) by smtp.gmail.com with ESMTPSA id c1sm121783wre.27.2018.03.13.05.18.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Mar 2018 05:18:04 -0700 (PDT) From: Christian Brauner To: viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org, ebiederm@xmission.com, torvalds@linux-foundation.org Cc: containers@lists.linux-foundation.org, Christian Brauner Subject: [PATCH 0/4 v5] devpts: handle bind-mounts correctly Date: Tue, 13 Mar 2018 13:17:09 +0100 Message-Id: <20180313121713.32551-1-christian.brauner@ubuntu.com> X-Mailer: git-send-email 2.15.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hey everyone, This is the fith iteration of this patch. Per-patch changes are summarized in the individual patches: ChangeLog v4->v5: * added non-functional patch to document devpts_mntget(). Reason for putting this in a separate patch is that it allows you, Linus and Eric, to simply drop it if judged useless. * reverse error handling logic to further simplify * dput() dentry in the non-function patch. This was not really a problem since the following patch included a fix for it. But better to get it right in all individual patches. * I did another rewrite of the problem analysis for posterity in the patch "Subject: [PATCH 2/3 v3] devpts: resolve devpts bind-mounts" and in this cover letter. ChangeLog v3->v4: * small logical simplifications * add test that bind-mounts of /dev/pts/ptmx to locations that do not resolve to a valid slave pty path under the originating devpts mount fail ChangeLog v2->v3: * rewritten commit message to thoroughly analyse the problem for posterity in the patch "Subject: [PATCH 2/3 v3] devpts: resolve devpts bind-mounts" and in this cover letter. * extended selftests to test for correct handling of /dev/pts/ptmx bind-mounts to /dev/ptmx and non-standard devpts mounts such as mount -t devpts devpts /mnt ChangeLog v1->v2: * see individual patches ChangeLog v0->v1: * see individual patches Christian Brauner (4): devpts: hoist out check for DEVPTS_SUPER_MAGIC devpts: resolve devpts bind-mounts devpts: comment devpts_mntget() selftests: add devpts selftests fs/devpts/inode.c | 66 +++-- tools/testing/selftests/Makefile | 1 + tools/testing/selftests/filesystems/.gitignore | 1 + tools/testing/selftests/filesystems/Makefile | 2 +- tools/testing/selftests/filesystems/devpts_pts.c | 313 +++++++++++++++++++++++ 5 files changed, 363 insertions(+), 20 deletions(-) create mode 100644 tools/testing/selftests/filesystems/devpts_pts.c -- 2.15.1