Received: by 10.213.65.68 with SMTP id h4csp342159imn; Tue, 13 Mar 2018 06:14:10 -0700 (PDT) X-Google-Smtp-Source: AG47ELtRR+HdHarlpmY1XvsqVdC6qKJPbtc/qtSQeDHDxAlL2uFJBN4jVMUOZg1GvR8EDUCBZy6s X-Received: by 2002:a17:902:c6b:: with SMTP id 98-v6mr526801pls.267.1520946849958; Tue, 13 Mar 2018 06:14:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1520946849; cv=none; d=google.com; s=arc-20160816; b=JQhxikhh9UUhd6/SC0wbmYUydojYrqQSvfSzGOEdN5QrXar5+1HsQpF7Cs4kXQmhUa uUh6BC0ad2ijKrPs5H332rQGX0aM0U2G9YOpM1OIy0K+LnVhZb6pQVHJOQWZ1KRZ10Fq pTDwi01irpCd/BF/Ep3JERwhDqMfI8L/KS8fbzG9lrvsmJvGsbpxPp+uTk2UdRn1w1yI D5y5YYRQvlkqv+rtUDWCZmgkPPY21ClKLzz0FYIMwmupZLqUShIM+pi7iQXv/jLB5Xpz IkbfN2vPj08exm6YvDc0PjLgDNcRJOpNGkpq6CmkhOznwmuJPUiots+Hkvm1WojSV7a6 j3Yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=qQo5dA+losUQUdhHqQRpeTLBQtyFTN6UkJYUf6jYlaY=; b=FHYdXaoPQaFdDMYVPKzwEXHnVKX76Li00yf2o9zEIm5pLvV7ipBxta6ESnox9cLBE2 xWlj7hbGHw79lhjPUO6UaJva6pGx/+u7QksmQFzdzOPffg+LH6o2Xvs+QWw8MxWR7PJj HMQhoSYSkZc/IvsXg740PDTibbAajrLq+V2ExDDgepLa031UzMZhVeFaAjOtFKLQJ5ra Pmr6QCENS2vqdy1RokJDKkJYeVEhc5aGUqimgVa0LkBxGYjwZNK7u8IWHrSUXU643pjS aWnHGBZlJ4FQDPWEkZkihVF78SbYwXL33PLbooMMTUTpUSkP95GLUzFIdvG4q4Xjw4eI SNxA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u25si132337pfm.164.2018.03.13.06.13.54; Tue, 13 Mar 2018 06:14:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752679AbeCMNLX (ORCPT + 99 others); Tue, 13 Mar 2018 09:11:23 -0400 Received: from mx-rz-2.rrze.uni-erlangen.de ([131.188.11.21]:38803 "EHLO mx-rz-2.rrze.uni-erlangen.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752181AbeCMNJt (ORCPT ); Tue, 13 Mar 2018 09:09:49 -0400 Received: from mx-rz-2.rrze.uni-erlangen.de (mx-rz-2.rrze.uni-erlangen.de [IPv6:2001:638:a000:1025::15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx-rz-2.rrze.uni-erlangen.de (Postfix) with ESMTPS id 400wDp5Jz2zPlNb; Tue, 13 Mar 2018 14:09:46 +0100 (CET) Authentication-Results: mx-rz-2.rrze.uni-erlangen.de; dkim=none reason="no signature"; dkim-adsp=none (unprotected policy); dkim-atps=neutral X-Quarantine-ID: X-Virus-Scanned: amavisd-new at boeck4.rrze.uni-erlangen.de (RRZE) X-Amavis-Alert: BAD HEADER SECTION, Duplicate header field: "References" X-RRZE-Flag: Not-Spam X-RRZE-Submit-IP: 2003:d5:3c2:e00:dbd1:5c46:f440:b630 Received: from fau.de (p200300D503C20E00DBD15C46F440B630.dip0.t-ipconnect.de [IPv6:2003:d5:3c2:e00:dbd1:5c46:f440:b630]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: U2FsdGVkX1/LmdZ5Mm1lILfXwrf6CcbUH/FeuwTe/Lk=) by smtp-auth.uni-erlangen.de (Postfix) with ESMTPSA id 400wDj0BjgzPk9y; Tue, 13 Mar 2018 14:09:41 +0100 (CET) From: Jonas Rabenstein To: Jonas Rabenstein , Scott Bauer , Jonathan Derrick , Jens Axboe Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 5/8] block: sed-opal: print failed function address Date: Tue, 13 Mar 2018 14:08:58 +0100 Message-Id: <55b2d57015c4088fcc3685045415cba02f9aa931.1520946114.git.jonas.rabenstein@studium.uni-erlangen.de> X-Mailer: git-send-email 2.16.1 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org add function address (and if available its symbol) to the message if a step function fails. Signed-off-by: Jonas Rabenstein --- block/sed-opal.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/sed-opal.c b/block/sed-opal.c index 5a448a3ba1df..f7925e6f607c 100644 --- a/block/sed-opal.c +++ b/block/sed-opal.c @@ -394,8 +394,8 @@ static int next(struct opal_dev *dev) error = step->fn(dev, step->data); if (error) { - pr_debug("Error on step function: %d with error %d: %s\n", - state, error, + pr_info("Error on step function %pS: %d with error %d: %s\n", + step->fn, state, error, opal_error_to_human(error)); /* For each OPAL command we do a discovery0 then we -- 2.16.1