Received: by 10.213.65.68 with SMTP id h4csp366738imn; Tue, 13 Mar 2018 06:58:10 -0700 (PDT) X-Google-Smtp-Source: AG47ELs669PRyxqJAotLbSTZ8+bX/knQGtMytoJFTbe+VqtshFiykP6XiWMYxdO1C43OfbrWDa8I X-Received: by 10.99.156.17 with SMTP id f17mr599762pge.102.1520949490871; Tue, 13 Mar 2018 06:58:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1520949490; cv=none; d=google.com; s=arc-20160816; b=Lax9GoihjnIf3GuU3qMK/p6r9bgflGDYebeaZ9+r2RCvnpbuaLItuHkSMwMAitIkyf vEXwa5L44bUkzgCAtGy2SBAU9AhkCy54+xpxEEDn208EyE+eAROUFnkESvoPnSa22sD6 LeeMeH0b4ijHnLq+5LjwD6SyaO0nOmmsyolcxvtVoJeNfGXmxZj54NTozGou3Tww3R4C L2k5Wb0qGnEX7/EelWGcxztsW4Y4pddGDLwMkCjUkzEDfB9qGdRHEu2vXDs/kDNoIzIN 1yCxClytqMbZ2+qRGHhfsIZyY+t/5/yBJRj6anwsYVYKiXlVhmmBgen9x5aTP7YnSTrR sYNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:dkim-signature:message-id:date:subject:cc :to:from:arc-authentication-results; bh=Vb4q5xvH+rVO+3WeKmds7tlMji89kW7xKhiXzDWnXqo=; b=a5Mr5WCOk8X9LuAjLjObqiHvbylqdDFziq4B9QMB13WU3Vu4UwOKKhKUY+Ubcq662C RLO8SYqQFWa1EflVPx9om8R6E93GpymkfjhhfVFao/c/qlSuiUDdKGLNpy23Z25QYFBG FAiv2EgyR6CyWI9S4Fhyz5/AkC88espMLrQccy3MiBv4iIgLir1jXmI7Ct5NjBVlAV4/ GAsO92KI/qQ9VkgE4hGZ5eIbIpdaUuybtK17PSuIZhasoGkBkDJ9CzXdo0AtFDNUkzzH LpptVORfWf1KTY3+/BBWnvQwBFgt8QjZVQk8TdN9aV5p5GEfU/v3ILEQYTF7q2ieQjTM /TxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mx.aim.com header.s=20150623 header.b=rY+ubAq0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=aim.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w20-v6si164341plq.486.2018.03.13.06.57.56; Tue, 13 Mar 2018 06:58:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@mx.aim.com header.s=20150623 header.b=rY+ubAq0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=aim.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932610AbeCMN4j (ORCPT + 99 others); Tue, 13 Mar 2018 09:56:39 -0400 Received: from omr-a018e.mx.aol.com ([204.29.186.64]:42308 "EHLO omr-a018e.mx.aol.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751835AbeCMN4b (ORCPT ); Tue, 13 Mar 2018 09:56:31 -0400 Received: from mtaout-mcc02.mx.aol.com (mtaout-mcc02.mx.aol.com [172.26.253.78]) by omr-a018e.mx.aol.com (Outbound Mail Relay) with ESMTP id 7DAC03800124; Tue, 13 Mar 2018 09:56:30 -0400 (EDT) Received: from thor.int.jpmvrealtime.com (CPE000db93f888c-CM001404556d28.cpe.net.cable.rogers.com [99.246.128.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mtaout-mcc02.mx.aol.com (MUA/Third Party Client Interface) with ESMTPSA id 5D82838000094; Tue, 13 Mar 2018 09:56:29 -0400 (EDT) From: Martin Vuille To: Arnaldo Carvalho de Melo Cc: Martin Vuille , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH RESEND] perf annotate: Don't prepend symfs path to build_id_filename Date: Tue, 13 Mar 2018 09:56:18 -0400 Message-Id: <20180313135618.2900-1-jpmv27@aim.com> X-Mailer: git-send-email 2.13.6 x-aol-global-disposition: G DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mx.aim.com; s=20150623; t=1520949390; bh=Vb4q5xvH+rVO+3WeKmds7tlMji89kW7xKhiXzDWnXqo=; h=From:To:Subject:Message-Id:Date; b=rY+ubAq0X2DMx5cWxs9mKJpD62xXVd1dY6YXBxz29AMQsHEtsnTJD7VEU30Kkx5bS 0ywSWz23HchtKGj3kwjntqRCPskboYXl2uVkD1aBfDtfGG/ajhjTeWk1pKib8DpD5U VX59LEIIPiZnfUyLoNu+UI/dxNJDO4xHOP0PF3HQ= x-aol-sid: 3039ac1afd4e5aa7d88d2938 X-AOL-IP: 99.246.128.134 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org build_id_filename already contains symfs path if applicable, so don't prepend it a second time. - dso__build_id_filename calls build_id_cache__linkname - build_id_cache__linkname uses buildid_dir - when symfs option is specified, symbol__config_symfs sets buildid_dir to include the symfs directory Signed-off-by: Martin Vuille --- tools/perf/util/annotate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c index 007170efa014..0b78cc4fb155 100644 --- a/tools/perf/util/annotate.c +++ b/tools/perf/util/annotate.c @@ -1381,7 +1381,7 @@ static int dso__disassemble_filename(struct dso *dso, char *filename, size_t fil build_id_filename = dso__build_id_filename(dso, NULL, 0, false); if (build_id_filename) { - __symbol__join_symfs(filename, filename_size, build_id_filename); + scnprintf(filename, filename_size, "%s", build_id_filename); free(build_id_filename); } else { if (dso->has_build_id) -- 2.13.6