Received: by 10.213.65.68 with SMTP id h4csp418443imn; Tue, 13 Mar 2018 08:27:20 -0700 (PDT) X-Google-Smtp-Source: AG47ELu1BQjI8HR2VtOwr/LkcuvZRK03jmT6Pb4wv6tV+4BGvruzrKxkdOEQ9MqmoY32ds77I5WY X-Received: by 2002:a17:902:4d46:: with SMTP id o6-v6mr936351plh.166.1520954840827; Tue, 13 Mar 2018 08:27:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1520954840; cv=none; d=google.com; s=arc-20160816; b=FjfGFpy4aBIY9wSutFkbLrvYeVu83oyiHB6VUVPVWYkCpEipWcAV9eCCZMrI5rTZZr 6pYQql4Lg6FtxtKJ8aacR2/0aQhp8088B4pQ2wiW0hZOJT2dR2xm8tzDXcmKp/As4At1 GKBrrQVVEnlC7hqOEApauxeEPEWjay38l4nUGpkfLwHAPgc8jjgleVd7EHp0fI5BZWkf pVNDk6u9Fijuk3AtsDg+ia/yYqOQ/Zntz5+XaQaIN/uGUfdb69xkYkzTP6kNw/vZpT+l wD4+xdOtxuvzvZWh8gX4FE8/5evW488A7J3OjqptsK373KH9/ytMeOjicmk+iamBqWIN +wzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:dkim-signature:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:arc-authentication-results; bh=GY1BJXRjZMHwxJcax8OO7RI6A1Wn5W1AZwqWKomIcp8=; b=j5UnHcIZwCQCabRVwg41sXMDzmX+b6Giy5iO+UAj7zZQS5AnJAu3aV/+GvwqTsZq65 C0a8yQWOCkCYNlcGyJmoCBHGD4CCTs4bI3GguwLsUo/4lcJk/NofDxkmGNczD9VWn00L OSOnpyATJsPWIuefwiG6L6M+ma+xTwdQcK8S29q3b3PVgYlvq6+R/NE8C5I/CkS00BSt GlbERnvDlCYiUJcaq8dhu0n4PZPNCINLUFb7tTI1IWJ0vbhQ6aDVWxHemxshjPAcybQB QqTxO+wkGXRO1Ik53cgtIwU21zv3Ec0u9+6D7CyuYyxFeT0zk5Mfddvun11QnRm/bJ3E hwLw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mx.aim.com header.s=20150623 header.b=fGeWd7/S; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=aim.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 19si257756pgg.395.2018.03.13.08.27.06; Tue, 13 Mar 2018 08:27:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@mx.aim.com header.s=20150623 header.b=fGeWd7/S; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=aim.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932387AbeCMPY0 (ORCPT + 99 others); Tue, 13 Mar 2018 11:24:26 -0400 Received: from omr-m001e.mx.aol.com ([204.29.186.1]:35019 "EHLO omr-m001e.mx.aol.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751961AbeCMPYY (ORCPT ); Tue, 13 Mar 2018 11:24:24 -0400 Received: from mtaout-mca02.mx.aol.com (mtaout-mca02.mx.aol.com [172.26.221.78]) by omr-m001e.mx.aol.com (Outbound Mail Relay) with ESMTP id C32043800090; Tue, 13 Mar 2018 11:24:23 -0400 (EDT) Received: from [10.11.12.90] (CPE000db93f888c-CM001404556d28.cpe.net.cable.rogers.com [99.246.128.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mtaout-mca02.mx.aol.com (MUA/Third Party Client Interface) with ESMTPSA id AB6E638000085; Tue, 13 Mar 2018 11:24:22 -0400 (EDT) Subject: Re: [PATCH] perf annotate: Don't prepend symfs path to build_id_filename To: Arnaldo Carvalho de Melo Cc: Arnaldo Carvalho de Melo , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org References: <20180211191937.9703-1-jpmv27@aim.com> <20180309190715.GB25111@kernel.org> From: Martin Vuille Message-ID: Date: Tue, 13 Mar 2018 11:24:17 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180309190715.GB25111@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US x-aol-global-disposition: G DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mx.aim.com; s=20150623; t=1520954663; bh=GY1BJXRjZMHwxJcax8OO7RI6A1Wn5W1AZwqWKomIcp8=; h=From:To:Subject:Message-ID:Date:MIME-Version:Content-Type; b=fGeWd7/SnQ9g89OnlAXsFkC4LBiLotWcAtovfN80qMn1P64EuM1fdISWnWmOs39Pn xTkWxMBGRJALLyc5fBpjgCXouCNMv3RKAjGkSGR5IFBVdEI9ywhnaZhbv0kNDZZNKR V9/xUv5DBxmIrtlsGFBQ4AzCoe2Of7yGiV5PP6wA= x-aol-sid: 3039ac1add4e5aa7ed26691c X-AOL-IP: 99.246.128.134 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/09/18 14:07, Arnaldo Carvalho de Melo wrote: > Em Sun, Feb 11, 2018 at 02:19:37PM -0500, Martin Vuille escreveu: >> build_id_filename already contains symfs path if applicable, so >> don't prepend it a second time. > Where is the analysis that shows that that is the case? I looked here at > the implementation for dso__build_id_filename() and couldn't find where > was it that the symfs would be appended, can you clarify? > > - Arnaldo > Patch resubmitted with additional details in commit message: https://patchwork.kernel.org/patch/10279077/ Regards, MV