Received: by 10.213.65.68 with SMTP id h4csp443640imn; Tue, 13 Mar 2018 09:12:55 -0700 (PDT) X-Google-Smtp-Source: AG47ELtEgIy+/SWDULj6jwmHGsMkBhnRwxGaBuqx6xCelkDupx2E8OEqRyilK+w6WyRuc9wMwDK2 X-Received: by 10.167.128.194 with SMTP id a2mr1158929pfn.186.1520957574961; Tue, 13 Mar 2018 09:12:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1520957574; cv=none; d=google.com; s=arc-20160816; b=aglCVLx30G7LayrzYrGz9dpH5fD+4DOx9eSx3zJeoJTGCIoqCr+fk8bjNx6Ero73ZE tbd+GuN9N7rF96Y6FwKUq8C/vsLnnbFHT9yd6VoUMnc8Y4hrh5/sBZ36RJYU6/aXGop1 hh+8+AYRDb/vN3RjeTpPCcgAulaswvIJ63FfF195PDsQFD+INDG0LGJ1GjM9LjZKv9wV YsvKkV/KAvWva0l2pOM7mHwi/b+ykwZmagNwaNucnmX5xBXU6x/xhNg10mpG6zBdpukb rUnwwPXdg34O820/nJDB7CpVhV9f1na5ROYsH6Or7xQFW1P7of51wtZs1iivJ65ICAAo o3TA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=FBnpQGYtsqitQieVpi9Qovb5nNiG/ZxKYzfwH+jwTjA=; b=sYTqai9uiNRWxOmCFtw8LVIj7UuUqv/8p5FdQwn98UVEE70pJbnsRhjvN0E3ZbzZ7s GsPDju4gDvK93PVn57/f1NtpUm6sKnSN589F1E1jBEgGldW4HwOzsvRoRdJftICj3K5O 43CpMPLy/14k12BPJZropMZiaOPBOzM2Yd/cobnV8P6xlpLCjxFW8XncytTmDPlS+C6F hvD8G7ouSXk+FSAVAxxISdoQC1qKSaSc7x3y3Z/XS2EKLm043uEsiWdNSb6PjxkLMmKs zzNgM8JTr+3dgzwCeVtPKDslAffE2Hu4+cdns5Rv31hwZA3rErHLzUGrraSefG1V2DPv D7tQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h193si270088pgc.591.2018.03.13.09.12.39; Tue, 13 Mar 2018 09:12:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934151AbeCMPgJ (ORCPT + 99 others); Tue, 13 Mar 2018 11:36:09 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:33384 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752951AbeCMPgC (ORCPT ); Tue, 13 Mar 2018 11:36:02 -0400 Received: from localhost (LFbn-1-12258-90.w90-92.abo.wanadoo.fr [90.92.71.90]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 566471184; Tue, 13 Mar 2018 15:36:01 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Quinn Tran , Himanshu Madhani , Hannes Reinecke , "Martin K. Petersen" Subject: [PATCH 4.14 024/140] scsi: qla2xxx: Fix system crash for Notify ack timeout handling Date: Tue, 13 Mar 2018 16:23:47 +0100 Message-Id: <20180313152459.636616080@linuxfoundation.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180313152458.201155692@linuxfoundation.org> References: <20180313152458.201155692@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Quinn Tran commit 2e01d0ba868ec1d4d55ddcba519339e072b0bf4d upstream. Fix NULL pointer crash due to missing timeout handling callback for Notify Ack IOCB. Fixes: 726b85487067d ("qla2xxx: Add framework for async fabric discovery") Cc: # 4.10+ Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani Reviewed-by: Hannes Reinecke Signed-off-by: Martin K. Petersen Signed-off-by: Greg Kroah-Hartman --- drivers/scsi/qla2xxx/qla_target.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/scsi/qla2xxx/qla_target.c +++ b/drivers/scsi/qla2xxx/qla_target.c @@ -665,7 +665,7 @@ int qla24xx_async_notify_ack(scsi_qla_ho qla2x00_init_timer(sp, qla2x00_get_async_timeout(vha)+2); sp->u.iocb_cmd.u.nack.ntfy = ntfy; - + sp->u.iocb_cmd.timeout = qla2x00_async_iocb_timeout; sp->done = qla2x00_async_nack_sp_done; rval = qla2x00_start_sp(sp);