Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S271972AbTHIBsJ (ORCPT ); Fri, 8 Aug 2003 21:48:09 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S272118AbTHIBsJ (ORCPT ); Fri, 8 Aug 2003 21:48:09 -0400 Received: from mail.suse.de ([213.95.15.193]:12040 "EHLO Cantor.suse.de") by vger.kernel.org with ESMTP id S271972AbTHIBsH (ORCPT ); Fri, 8 Aug 2003 21:48:07 -0400 Date: Sat, 9 Aug 2003 03:48:06 +0200 (CEST) From: Andreas Gruenbacher To: Herbert Xu Cc: Marcelo Tosatti , Alan Cox , Linux Kernel Mailing List Subject: Re: [PATCH] 2.4: Restore current->files in flush_old_exec In-Reply-To: <20030809011116.GB10487@gondor.apana.org.au> Message-ID: References: <20030808105321.GA5096@gondor.apana.org.au> <20030809010736.GA10487@gondor.apana.org.au> <20030809011116.GB10487@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 728 Lines: 21 On Sat, 9 Aug 2003, Herbert Xu wrote: > Hi: > > The unshare_files patch to flush_old_exec() did not restore the original > state when exec_mmap fails. This patch fixes that. Indeed. This is still needed. > At this point, I believe the unshare_files stuff should be fine from > a correctness point of view. However, there is still a performance > problem as every ELF exec call ends up dupliating the files structure > as well as walking through all file locks. Cheers, Andreas. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/