Received: by 10.213.65.68 with SMTP id h4csp447806imn; Tue, 13 Mar 2018 09:20:57 -0700 (PDT) X-Google-Smtp-Source: AG47ELu9AbGkcc57+pH4HBfC+0r7J/ByVSvs5p5dCewIL53q8R85mqm1GcCqAoRf2UWtb80xR+QC X-Received: by 10.98.32.28 with SMTP id g28mr1176308pfg.182.1520958057662; Tue, 13 Mar 2018 09:20:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1520958057; cv=none; d=google.com; s=arc-20160816; b=gh5Ye9WKuMobtMRb/GCOJXYt6dZPUxVP3RoepyzCR1qbhEVFYAtRDlBi+DnxsLFMda eCKPP/on/SfydAqHH8sprH0hSN1jhAd/E73bHku4ww3B+2azYfjhzrEkEJgAvWeeLa41 R0JF132j/iv/Xvhs2njIvsmpGtTFuPOZ/psXG9pO/DtW8ZJCRaa72erdk+FuND5uGyA2 4wf/w9gvZxJdmM11Te1j6qOMsmat6rhsoRSkMSe0BmJ9YDnjq2Pm01onqD0X7Ijvx4Xa Lx4IfUUKHnv1OWtFoU7uW5BAAc8WQ7BQm0aft6RtVNiMB9xRwaJuYvNUrP0X0cyEv8Un PDYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=zyYHbl9WTkLZH7C/ilCfNi5cndUh0VpjCNIZQDDBWGg=; b=JMWEt7XP5gXosDyPLJGcrxdgEep7f9TI6nhUS+hzrYyOMQRXMUnU3DQAh549JI+ho2 f5DAgJvn7s/rDRcPy43ZlKizaYyKTz5q9n6/h01SqNoL0itkO0PeiDdBFwJrjfJWK2fm znJK4TWbEpwE7BlIS7G9GvWhqr4Q302EjJrva9+V+0jPqChhgoS3MK0YJ9alrxDNjjHQ XFN9yQylhWGze6A76lW9xnvrxROuSFOx/bgMq6mhiOpW10SjXAQ5mWZJgjIkQfgxmlLC mNa8v8pZEzZZkbwlD17jr2laOXhAGwW1TRDStE0LJ+9czYIrkHjCMddSJhsfc0GrJEkL s3Lg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 80si342316pfn.73.2018.03.13.09.20.43; Tue, 13 Mar 2018 09:20:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934021AbeCMQSw (ORCPT + 99 others); Tue, 13 Mar 2018 12:18:52 -0400 Received: from mga02.intel.com ([134.134.136.20]:23448 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752281AbeCMQSt (ORCPT ); Tue, 13 Mar 2018 12:18:49 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Mar 2018 09:18:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,465,1515484800"; d="scan'208";a="24166277" Received: from sbauer-z170x-ud5.lm.intel.com (HELO sbauer-Z170X-UD5) ([10.232.112.135]) by fmsmga008.fm.intel.com with ESMTP; 13 Mar 2018 09:18:48 -0700 Date: Tue, 13 Mar 2018 09:53:38 -0600 From: Scott Bauer To: Jonas Rabenstein Cc: Jonathan Derrick , Jens Axboe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/8] block: sed-opal: support write to shadow mbr Message-ID: <20180313155337.uz6uxdpeonbjwa2l@sbauer-Z170X-UD5> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 13, 2018 at 02:08:53PM +0100, Jonas Rabenstein wrote: > Hi, > this patchset adds support to write data into the shadow mbr of sed-opal > enabled devices. They apply cleanly on today next-tree (next-20180313) > and requires the u64 short atom length fix from [0] as that is still > missing in that tree. As I only can test on my only sed-opal enabled > Samsung 850 Evo on amd64, tests on other hardware would be appreciated. Generally the series looks fine, there are a few nits I've sent out. I will test and get back to you in the next day or two. With any further comments.