Received: by 10.213.65.68 with SMTP id h4csp453473imn; Tue, 13 Mar 2018 09:31:49 -0700 (PDT) X-Google-Smtp-Source: AG47ELvMk1HGTjWYPtETAc1swX3He+XMEytYTL4toesaiNc5/KQYprHGczVj4CeGAawS73ArdGU8 X-Received: by 10.101.99.205 with SMTP id n13mr976296pgv.345.1520958709095; Tue, 13 Mar 2018 09:31:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1520958709; cv=none; d=google.com; s=arc-20160816; b=fNFpvb0MgbcwTQShEVDrL+T7zKDsI5bjiE/o66dqGDoLViV18nsQpl02rkna3RByOe rPJhM8vNOlkADykAWYpslekjx8ATKJh3Q9DvSBzuQKD6BK6zVqold6rQPoeQ4ZxMMTB4 2KizpDdwCNppn4SpXCmUJtpQ2c+gedWRMYad7D8nAnYUBtvpd6MiX1czwL3NT2boU2de 8gWIABIG7uk/RZmfqqK5N91Vi3jl+fFpAV/NIpXKL9yeXPrfWUbzzdQvT0nwWTxTVcKl 02fMSfjEVyw6pRdXf7aOzpzYRf1+ooz92+FPqWYbRFzILm6h840UtFW4eBCnHhADg8DB EOCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=BZPK9RX98N76URfxjzYPPdfjXRiK7gCgtaYGy97aqt4=; b=rd5mC2WOrncQn/iPEpRHQBo2dMqmIGqn6hJOUdcz+dj3sA7NVLRUV1OqsFV5wzUDhE K3cly6PMnShPN9r5pc01XdiIMetPU8DnD/aepC2HRZH7VZqCHLXO81VeJ2IuychPcXam iUqePKui7WAtMyGnbgfYugYLFfx9gVdITeeZ2RtAdFN8QmsFtLcClUk2oZ+W4FPrlcYz BukbmGwZ4ibPlAVPFNj9Y28p/Nxz/PadKyAdaeNzOrCIAmY9qhRxMxGJZeZbm1T/P7xt oGBICDFXZcsu2FI7PJ9OMNQXtjjN2POPJ0f/Wh/7FKHEu52UngRz8n+cXpr+UTxUlpR+ uVww== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b3si257000pga.503.2018.03.13.09.31.34; Tue, 13 Mar 2018 09:31:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933541AbeCMPd2 (ORCPT + 99 others); Tue, 13 Mar 2018 11:33:28 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:60668 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933528AbeCMPd0 (ORCPT ); Tue, 13 Mar 2018 11:33:26 -0400 Received: from localhost (LFbn-1-12258-90.w90-92.abo.wanadoo.fr [90.92.71.90]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id C4248DE7; Tue, 13 Mar 2018 15:33:24 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Quinn Tran , Himanshu Madhani , Hannes Reinecke , "Martin K. Petersen" Subject: [PATCH 4.15 124/146] scsi: qla2xxx: Fix system crash for Notify ack timeout handling Date: Tue, 13 Mar 2018 16:24:51 +0100 Message-Id: <20180313152329.799578143@linuxfoundation.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180313152320.439085687@linuxfoundation.org> References: <20180313152320.439085687@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Quinn Tran commit 2e01d0ba868ec1d4d55ddcba519339e072b0bf4d upstream. Fix NULL pointer crash due to missing timeout handling callback for Notify Ack IOCB. Fixes: 726b85487067d ("qla2xxx: Add framework for async fabric discovery") Cc: # 4.10+ Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani Reviewed-by: Hannes Reinecke Signed-off-by: Martin K. Petersen Signed-off-by: Greg Kroah-Hartman --- drivers/scsi/qla2xxx/qla_target.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/scsi/qla2xxx/qla_target.c +++ b/drivers/scsi/qla2xxx/qla_target.c @@ -665,7 +665,7 @@ int qla24xx_async_notify_ack(scsi_qla_ho qla2x00_init_timer(sp, qla2x00_get_async_timeout(vha)+2); sp->u.iocb_cmd.u.nack.ntfy = ntfy; - + sp->u.iocb_cmd.timeout = qla2x00_async_iocb_timeout; sp->done = qla2x00_async_nack_sp_done; rval = qla2x00_start_sp(sp);