Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S272227AbTHIDCn (ORCPT ); Fri, 8 Aug 2003 23:02:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S272230AbTHIDCn (ORCPT ); Fri, 8 Aug 2003 23:02:43 -0400 Received: from mail.suse.de ([213.95.15.193]:33286 "EHLO Cantor.suse.de") by vger.kernel.org with ESMTP id S272227AbTHIDCm (ORCPT ); Fri, 8 Aug 2003 23:02:42 -0400 Date: Sat, 9 Aug 2003 05:01:50 +0200 (CEST) From: Andreas Gruenbacher To: Herbert Xu Cc: Marcelo Tosatti , Alan Cox , Linux Kernel Mailing List Subject: Re: [PATCH] 2.4: Restore current->files in flush_old_exec In-Reply-To: <20030809025311.GB11777@gondor.apana.org.au> Message-ID: References: <20030808105321.GA5096@gondor.apana.org.au> <20030809010736.GA10487@gondor.apana.org.au> <20030809011116.GB10487@gondor.apana.org.au> <20030809014830.GA11509@gondor.apana.org.au> <20030809025311.GB11777@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1059 Lines: 26 On Sat, 9 Aug 2003, Herbert Xu wrote: > On Sat, Aug 09, 2003 at 04:20:38AM +0200, Andreas Gruenbacher wrote: > > On Sat, 9 Aug 2003, Herbert Xu wrote: > > > > > On Sat, Aug 09, 2003 at 11:11:16AM +1000, herbert wrote: > > > > > > > > At this point, I believe the unshare_files stuff should be fine from > > > > a correctness point of view. However, there is still a performance > > > > problem as every ELF exec call ends up dupliating the files structure > > > > as well as walking through all file locks. > > > > > > Here is the patch that ensures files is only duplicated when necessary. > > > > This patch is correct but unnecessary: steal_locks already tests for this > > condition. > > Yes but when you call unshare_files twice one of them will have to > copy. I see---that happens through flush_old_exec. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/