Received: by 10.213.65.68 with SMTP id h4csp482419imn; Tue, 13 Mar 2018 10:26:21 -0700 (PDT) X-Google-Smtp-Source: AG47ELvNdJR758aY5QkvlWcJTc3mQh4onHFjreeBhgqwdpinQRC52tXV6ajUx+ni+Rupd1G5endJ X-Received: by 2002:a17:902:9a45:: with SMTP id x5-v6mr1261123plv.18.1520961981643; Tue, 13 Mar 2018 10:26:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1520961981; cv=none; d=google.com; s=arc-20160816; b=oim/BRCUo10ma7rQ1WDvMVkB4dkP5TZy/smE73DhP4Ma+Sglpk3Ma92ukq1Vr1xql9 C5r2rfovkVYXb8U3wOvVmKi1oDNJMDH0AWnAuKKMQriEacDrX2wQosNyEhJq50Hz1262 jIUb8MTaL6tlF11iMp0F+fALo2HAm4y5jm8KYILY0R1hEcqfPlkKvwWPS3U0KVZiJDcv o2/t6ypibaNz1eKkD0PxlegoLVObOG9snYqSYgCtE3dKQwkX7MGGMdK+o6I8W/d4upd9 Dp+JBpktPIadH9CPyQ2unDlexPh/SYgiR4/+7da5PU/b3VXlPltOAANmA8DJiwLEOSWG EgRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:from:references:cc:to:subject :arc-authentication-results; bh=g+ySq8++IURb39oXqBBQgoVUb9D+z4n0ckBHxRKlghQ=; b=QdX+W8c3Iv3OSvHSieKvGN0a5J78hGW8SzTp51eIRxcXvHY/xTJxeJCN5aC5GWNAz0 8dtBB5oUqncz8xMTHrtucRi4pWY85QLiNSZSLwB2n94AVE/+yFxYsODgdR4wuHgb5t4J z0KDgamocpj9cG771wyPfg/fXae6D8tmtgTMSDyq9eFDxdxvysgzzduTHtt2M5umJ5tJ r6He8gse0QnbXhu/lzsRtneN0cXhtofifDHFRkVtRClnOnZF5xIx9pld/xj3vW/zzB0G fLfvcPx9gq1zaDMXgCqYo6RrakJkjvJClLSxMkmY9G0gfNFCMjQ8dH8kNn3Hy6fKh05v 7ZsQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d18si394491pgo.209.2018.03.13.10.26.06; Tue, 13 Mar 2018 10:26:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932480AbeCMRZM (ORCPT + 99 others); Tue, 13 Mar 2018 13:25:12 -0400 Received: from foss.arm.com ([217.140.101.70]:42130 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932312AbeCMRZL (ORCPT ); Tue, 13 Mar 2018 13:25:11 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D50081596; Tue, 13 Mar 2018 10:25:10 -0700 (PDT) Received: from [10.1.207.62] (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0C77D3F487; Tue, 13 Mar 2018 10:25:08 -0700 (PDT) Subject: Re: [PATCH] arm64: kdump: fix interrupt handling done during machine_crash_shutdown To: Grzegorz Jaszczyk , Mark Rutland Cc: Hoeun Ryu , catalin.marinas@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, Nadav Haklai , "AKASHI, Takahiro" , james.morse@arm.com, Marcin Wojtas , linux-arm-kernel@lists.infradead.org References: <1519837260-30662-1-git-send-email-jaz@semihalf.com> <20180228171647.6t4dabntujcb5kon@lakrids.cambridge.arm.com> <20180302120556.xujh3hoy44y7ouz7@lakrids.cambridge.arm.com> <20180302131545.q2vf6uc3yofofqdb@lakrids.cambridge.arm.com> <20180302164411.fxdx72ttz7livz2e@lakrids.cambridge.arm.com> <20180302165739.dc726v3yf2mxli3u@lakrids.cambridge.arm.com> From: Marc Zyngier Organization: ARM Ltd Message-ID: Date: Tue, 13 Mar 2018 17:25:07 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/03/18 22:06, Grzegorz Jaszczyk wrote: > 2018-03-02 17:57 GMT+01:00 Mark Rutland : >>>>> Do you see this for a panic() in *any* interrupt handler? >>>> >>>> I only test with this two interrupt handlers: watchdog and i2c but I >>>> think it will behave the same with others - I can try with other if >>>> you want, any suggestion which? Maybe with some PPI interrupt instead? > > I was able to reproduce it from other interrupts handler (UART, I2C, > timer and watchdog) no difference if it is PPI or SPI interrupt. I > also reproduce this issue with GICv3. But again it only happens when > eoimode = 0. >>>>> >>>>> Can you trigger the issue with magic-sysrq c, for example? >>>> >>>> There is no problem when I trigger it via 'echo c > >>>> /proc/sysrq-trigger' - it works well all the time. The problem appears >>>> only, when the kexec/kdump procedure is triggered from interrupt >>>> context >>> >>> I'd meant that you'd send sysrq + c over serial, rather than writing to >>> /proc/sysrq-trigger. That way, the panic will be in the context of the >>> UART IRQ handler. >>> >>> If that shows the issue, that's ilikely to be the easiest way for >>> someone else to reproduce and investigate this. > > Yes it can be triggered by sending sysrq + c and indeed it is the > easiest way to reproduce it. >> >> FWIW, having just given this a go on my Juno R1 with v4.16-rc3 >> defconfig, the UART IRQs work fine in the crash kernel. That crash >> happened in IRQ context: > > I think that by default Juno uses eoimode = 1, did you try it when > eoimode was forced to be 0? Only eoimode = 0 triggers the issue. FWIW, I've now posted fixes to LKML[1]. Feel free to test them and report whether they fix the issue for you. Thanks, M. [1] https://lkml.org/lkml/2018/3/13/1088 -- Jazz is not dead. It just smells funny...