Received: by 10.213.65.68 with SMTP id h4csp496161imn; Tue, 13 Mar 2018 10:52:45 -0700 (PDT) X-Google-Smtp-Source: AG47ELurUcY3qdu83PZEOYZryONrTvAWYsh7xKLy6zwVWUiFD1WykVm3XcUPqEN/rYH/o1QJFSMS X-Received: by 2002:a17:902:207:: with SMTP id 7-v6mr1324519plc.261.1520963565358; Tue, 13 Mar 2018 10:52:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1520963565; cv=none; d=google.com; s=arc-20160816; b=Wy9iFB0+nrqAl7xEKNjy7oUvnvg+U5JpGe1i26hNcGHxBWhw9o7BzaKyh1hVNffEWS vOHFZoM8zZSJIEy2i1vSMNauqbQyriFryyKGVZlGsoHH0zRlaOIDo2/CVZy7+L7/tzqv +aoW4+H79Z+bp25sbblpPTPaGS/Oo8NZ9/TKT/CDDosWnXpfvUrdLZAHPBXTJZcWVp/H L1Chw8yrMtUbZsV3SwoZAjQzgsXhDkMk7Mt4etW+Lc6WjrJDeMFjg6Fr26K9qvvd2evi /m3lTCJNwnrW50tWeE6LUJOkJrgn0bHeyuK7fzvGCt1kzarf7AVCyphoscwKR8V88Aca mpRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=7KglegCa9CTwsgCb6PnsApbMNySUL4ew40m57VHg5f4=; b=K1E8YikVhDhYktfkpHCcB78cZY54oIwFhYLSk+Uj5JgotBINnggkSUX0PCv0X9l9Rx 6rv4kSXXSdIx0gOcHbCA/rcsLEIqm/pnVb0YG/sj4UF0iGdzs2dqN5UjmMcbmQb07/zc DKtWmqhELRkz8Dv+RmkXST1fN36gc+ilI3hP8XPU0mmy53e7IguJVgRctQyTZECAlMaA zGW4ACGX3kSdc212knN+9oj196XlDikHAIHxl7+ieQhOzRkXZPxoJUUv388TDwISMdOi VUCI6UAITOy2weACGc9uLoKqYMmKGFlekJuDEd2XEFL+EMZEtot8N1aeZ1yVIarTpsow KSlA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OJq2UAyS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v6si408669pgc.526.2018.03.13.10.52.30; Tue, 13 Mar 2018 10:52:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OJq2UAyS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752532AbeCMRvE (ORCPT + 99 others); Tue, 13 Mar 2018 13:51:04 -0400 Received: from mail-io0-f196.google.com ([209.85.223.196]:34097 "EHLO mail-io0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752468AbeCMRvD (ORCPT ); Tue, 13 Mar 2018 13:51:03 -0400 Received: by mail-io0-f196.google.com with SMTP id e7so1139732ioj.1 for ; Tue, 13 Mar 2018 10:51:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=7KglegCa9CTwsgCb6PnsApbMNySUL4ew40m57VHg5f4=; b=OJq2UAySLmYANTSVlmOnDab6h/9dTStqU/dssH3xaSHHZtoerOHL/XtoefP8Z2qBTS cOXFF6zdLJUOr4IHIpIymAWhC8YV7t1kcsagfKSyUWIkTMtMvUY0hxTriMdOjWAgbgEh iPw2ZFtfjxwCJSnyxd2dd/Yn5e21nukU6sJBE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=7KglegCa9CTwsgCb6PnsApbMNySUL4ew40m57VHg5f4=; b=D+v0h9L4REWHvuV0xO80iYNF7iwng79xl+ZrZ9Y5a6tv/NJqCLlnKNk7C9wwnXbjHF +KAFwm8uZSRLGE2uFizk9w22aAcDavnm6MzM34/hvtbZ+TrMi3irQferz8WLCieE3trK CD3tQuIeLfWRgYFRDKQIjXSi64ZodH+xa9F9MUU8g+mOvTUHIgp4DSu3bQM4JOl1tawM rP4GRoRZ8ngN+wgQx2FggfpdcBDjC1PNaxVkXhh+ZKd90Qy/i7QSsdxvObz14TUoIIpR 9O7HxrM4Dn8GIy/EijPqNCCqgnNq9elW54/axQIevXGhg0pWJwVWe9PllhVMifuylftV /q5w== X-Gm-Message-State: AElRT7HXSvOTtRpKOZMCcQe1uMVx7Xr4jbB0iUd1CSm8iAkSNDj+v3JE XyUaazWB8snxMjm14TWw9lb2EKhpCfpv+sc5ET9ObQ== X-Received: by 10.107.213.72 with SMTP id x8mr1812456ioc.60.1520963462716; Tue, 13 Mar 2018 10:51:02 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.138.209 with HTTP; Tue, 13 Mar 2018 10:51:02 -0700 (PDT) In-Reply-To: References: <20180313135314.18780-1-alexander.sverdlin@nokia.com> <20180313135314.18780-3-alexander.sverdlin@nokia.com> <5d3ae760-45bd-3588-500f-1b352e1722de@nokia.com> <60156300-b74a-628c-d296-7fb71a0eeb4f@nokia.com> From: Ard Biesheuvel Date: Tue, 13 Mar 2018 17:51:02 +0000 Message-ID: Subject: Re: [PATCH v4 2/2] ARM: ftrace: Add MODULE_PLTS support To: Alexander Sverdlin Cc: linux-arm-kernel , Linux Kernel Mailing List , Russell King , Steven Rostedt , Ingo Molnar Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13 March 2018 at 17:49, Alexander Sverdlin wrote: > On 13/03/18 18:39, Ard Biesheuvel wrote: >> if (IS_ENABLED(CONFIG_ARM_MODULE_PLTS)) >> module_plt_alloc_fixed(); > > Do you consider this a legal C code if without module-plts.o the function would not exist at all? > That's too much relying on optimizer I think... > Yes, we rely on that in many different places in the kernel.