Received: by 10.213.65.68 with SMTP id h4csp764310imn; Tue, 13 Mar 2018 22:10:13 -0700 (PDT) X-Google-Smtp-Source: AG47ELunwF5KGIeltig5WXFTXLc/HWRBxtIdvOqAt4DTzJoxtqbUvWdCogmRienOtu2zanzljR8P X-Received: by 2002:a17:902:28e2:: with SMTP id f89-v6mr2853622plb.114.1521004213402; Tue, 13 Mar 2018 22:10:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521004213; cv=none; d=google.com; s=arc-20160816; b=NjshCnGXYy9xylv8lGTcEAE1HpYvrj1t0iPAVzg14gnyHYSBoAKDqv72bFyAowdef2 Km/2V3z6EftvV6sP+l2ZEBCqQixZXrsCjCvh2dVw4qC1TVqRr9JmZu5ThT3CIpaXgF3x Qmgzkt9UP+orRVGa/54tcyFW3UIZGB0TLX5TOdapvK5XJzL3mjRZuncU1bhuiX3qJUP/ mc9TCbC6kmC4++bakMcVAB9BdiO7KfX8b81H5Bm/CO4sVPAxQEQY6XpYZH5zcI/T4QO8 Rlumc64NL6Y/+DAvxDFfhY3bkvILuLn6avhBax2JNaS/1TYFs+Ni+GT/lVwHzgnqHjYN UKlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dmarc-filter :dkim-signature:dkim-signature:arc-authentication-results; bh=RAq4VHYtBC/ePsZVGkSzIuc0neSzE7t7FOqgJsf1g88=; b=Zlroe4oBxz0tiFSbHKdchFKaNLGfMkIFeHZicX16gAIB709Xcv7haEuqgq+rG0gzbj xvES60JKfq749GwCdHK+JeCZGRDEOHD6kaJoZ/kwo6fWuOfPuWxJsV3sc7Sa8TY451Kb pYgxJAtmW81CbNUtNkXXIlo77mqnSDdpGMWmAOI1GOenvqcuA3cfvMcKYG7Eu/QNRaVd cFM4ialm1bmXX8eYaOanscqzHM8qmnCfrZhOgI4FfldWBup8gouUxo/b1jyGtvnbKz4L 7eHYlcAwQldD3dxG6/zo6f1QkpkzX88+QTkbY9/z+q1uTTB3+hon2bUXzS3XeqTu448Q jS6w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=ChoP0MIi; dkim=pass header.i=@codeaurora.org header.s=default header.b=UUW+6bBI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d14si1458001pfk.29.2018.03.13.22.09.58; Tue, 13 Mar 2018 22:10:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=ChoP0MIi; dkim=pass header.i=@codeaurora.org header.s=default header.b=UUW+6bBI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753219AbeCNFI4 (ORCPT + 99 others); Wed, 14 Mar 2018 01:08:56 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:58964 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750816AbeCNFIy (ORCPT ); Wed, 14 Mar 2018 01:08:54 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 1CCBE60591; Wed, 14 Mar 2018 05:08:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521004134; bh=GBLdD+IXti8qe/Y7RoqWjnuFOSy29MyqS5eK7+xQ8dc=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=ChoP0MIiKcaStuBJE7czxNo3nOlSZ3/1D3MnJoTXU1e1BP3zlfj3GjUQQEYDE4b3l DEgFlgjufzqPwNWzbMBuVhUfHoDYzduVbABVXMk7QzjTIA50WId7OgOegr7hyjNHnL hPV5cLfykrOm/R6wEAKhcrchL9QRis6BnuD4wKMM= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from [192.168.1.125] (cpe-24-28-70-126.austin.res.rr.com [24.28.70.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: timur@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 9FB1B60452; Wed, 14 Mar 2018 05:08:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521004133; bh=GBLdD+IXti8qe/Y7RoqWjnuFOSy29MyqS5eK7+xQ8dc=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=UUW+6bBIRO8sgFW+SH37WaJ+e1xqENQYof9Vj4vCCtjVJF9OESaaXyOUCgtgp3WSD WIwz/NqsIBA5ZfNbhXMzZlafyTbba03zC7qlJ9fCo5Echf5eDLhOPD1J0QbmBuEpOp BA5K3sguZMHz2S7fDv6jEPCQ3ug9jorewUVtVzeU= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 9FB1B60452 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=timur@codeaurora.org Subject: Re: [PATCH 7/7] ixgbevf: eliminate duplicate barriers on weakly-ordered archs To: Sinan Kaya , netdev@vger.kernel.org, sulrich@codeaurora.org Cc: linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jeff Kirsher , intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org References: <1520997629-17361-1-git-send-email-okaya@codeaurora.org> <1520997629-17361-7-git-send-email-okaya@codeaurora.org> From: Timur Tabi Message-ID: <12150aa0-77ba-878e-31f4-d4f8d6a28ccb@codeaurora.org> Date: Wed, 14 Mar 2018 00:08:51 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1520997629-17361-7-git-send-email-okaya@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/13/18 10:20 PM, Sinan Kaya wrote: > +/* Assumes caller has executed a write barrier to order memory and device > + * requests. > + */ > static inline void ixgbevf_write_tail(struct ixgbevf_ring *ring, u32 value) > { > - writel(value, ring->tail); > + writel_relaxed(value, ring->tail); > } Why not put the wmb() in this function, or just get rid of the wmb() in the rest of the file and keep this as writel? That way, you can avoid the comment and the risk that comes with it. -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.