Received: by 10.213.65.68 with SMTP id h4csp839845imn; Wed, 14 Mar 2018 01:23:10 -0700 (PDT) X-Google-Smtp-Source: AG47ELvkOU9lmkVm1egc7+IHU4TwrO/3hbSCicC8qC3lcbv4VqnzkAuWrluFwBz7+v1fh2sNCX1h X-Received: by 10.98.15.72 with SMTP id x69mr3450557pfi.16.1521015790671; Wed, 14 Mar 2018 01:23:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521015790; cv=none; d=google.com; s=arc-20160816; b=iOW49v5P3t735X1+bnajban1aJWKRJWd/xJA6iD5HUmonvLPOimQb8/5rZr8V0jTZQ 2WrWrdW0Ncx5p9YLLEnhHHBz+eUJZ80kakOkzii8FnhZInXPHJ5LY0Xqv2sh1KOCflSI nJNJHpF3oi1Aa9hZ3+PRQVoPkw3JuPtp1pRpjt+s7Wyup1vuxzm3fm+ziEo2jHShVtjn 0Gcd6S2VMSZRe/gzFKtYWOMLPg5sr5cvqlEjzxfDGRTQdj3JojT0TQ/Zs2jSw7pZGNi9 lyuFqkSr56JuIw4jTayuUQPkCLesJBUBM4XMETv3ZvBq3GFdPr1XgRXg9hnLIcfQJbyd yNrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=v5eRaTIk3RzfS7hJOtvVv0bkYedLD2bgZrH6dAbJwXc=; b=FfASTaQ3KYFkjeGVWzV8UUU65yUlwOeEKFdQICaxiuPbxDoUetdJzRFQ6kU8Dy/syV PDLRHI5VGCep2kkqCdH1nke4moUqZsC8C3E9Pce+UoPc8mavOlEmfRd6jJ7+cCV3DL95 VWOC4YH+PSOCsF8ReW3ffPpvKUe9oEciR8OIfAqcqCCnOv/JBqR++aWFUyL66nCFAHoA kJZaXWx6kwED+bJGNU3ZyUJTk9KZQbL/O+rkj/+iXRq/JetFheGtW//Gi4aQxfp8BAU3 M3fVeE4hpZ+bm9U9o6g1kNAtIAzW5Yq9y05/fqtYLHo8g1KlI44+g1IGZZSzSpbN/rCs xGwQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=ln4fTlCM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d24si1666887pfn.336.2018.03.14.01.22.56; Wed, 14 Mar 2018 01:23:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=ln4fTlCM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753544AbeCNIVs (ORCPT + 99 others); Wed, 14 Mar 2018 04:21:48 -0400 Received: from mail-qt0-f179.google.com ([209.85.216.179]:37111 "EHLO mail-qt0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753057AbeCNIVp (ORCPT ); Wed, 14 Mar 2018 04:21:45 -0400 Received: by mail-qt0-f179.google.com with SMTP id a23so2533748qtm.4; Wed, 14 Mar 2018 01:21:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=v5eRaTIk3RzfS7hJOtvVv0bkYedLD2bgZrH6dAbJwXc=; b=ln4fTlCMIzIKaB2CBQKNLSxYWsWxWmMYF+sQRf/hiHMXtrgAXPxu7DviOaFDASP4T7 l+a6NL09xH6u/uxaCGy6KRN0eT+ElA5Tam7dURndpUDNa1+tZW5/zv9iJTE2lNV8ABpm 4VjgI6IZjXAGmQP5kIbjJ2rlyDnlBnrXcRCkMkztV1imky5F2WFuBlULMYogVs4on13B sIBOoJiJZ9y1ycybL4xuWh6hKInJYGTvWqOAXuNxYEp76/2qfGD23oMVrMaT+w9osPD5 tWl4VvneTAledI/lMVj6xms4hAB5sdok5t2492zhfJIYwTZIJoUQMPMgGbsEzTmNY8wT IDPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=v5eRaTIk3RzfS7hJOtvVv0bkYedLD2bgZrH6dAbJwXc=; b=duM9qgk27bWi4pV94yRWmtTGlS4nonwu/JZUsEl/ZVhtXJkL2GZkfNk32M3+h/5JDy G0U427yRV4p2g61eoiWTVr8++tib/kNDEeTHkhSZbETL9rJCSKjRmj0kU9Z+A0r5l/3x dnNirifoE3S0raONqpE93GHxVw4Hq3ApyjJ2RSOItN25q5bv4esQhqBHwtDLwnDtQ0ih PO0gN1xrxJ3S5a6BOyl9oLuF1aV6eQQviWlWrKFwdST9hG/QTtjLWo58Fz+nU/4d3uOv SmZpAFKfTa+7zXR0/582givdrQzsotNQkCqnRUEH1sdRre9lnshtto5/FHZPn3EkaCdI LQgQ== X-Gm-Message-State: AElRT7FLXHd9B8ZeMetL+6blBTG6ya9C+Az4aPCaxUsJtG08E/MBpnM+ t0hRk8w7zjwG2UgqfXokVXBxYhIdj1gD8vVGhUoDHEUQ X-Received: by 10.237.38.231 with SMTP id q94mr5555569qtd.60.1521015705028; Wed, 14 Mar 2018 01:21:45 -0700 (PDT) MIME-Version: 1.0 Received: by 10.200.54.147 with HTTP; Wed, 14 Mar 2018 01:21:44 -0700 (PDT) In-Reply-To: <30abb41033b9670c06a54ff484d61d25d3c6e5cd.1520963956.git-series.kieran.bingham+renesas@ideasonboard.com> References: <30abb41033b9670c06a54ff484d61d25d3c6e5cd.1520963956.git-series.kieran.bingham+renesas@ideasonboard.com> From: Geert Uytterhoeven Date: Wed, 14 Mar 2018 09:21:44 +0100 X-Google-Sender-Auth: 0JwPQGIGTPnFbasHXFuBOOEix1I Message-ID: Subject: Re: [PATCH v2 02/11] media: vsp1: Remove packed attributes from aligned structures To: Kieran Bingham Cc: Laurent Pinchart , Linux Media Mailing List , DRI Development , Linux-Renesas , Mauro Carvalho Chehab , open list Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 13, 2018 at 7:05 PM, Kieran Bingham wrote: > The use of the packed attribute can cause a performance penalty for > all accesses to the struct members, as the compiler will assume that the > structure has the potential to have an unaligned base. > > These structures are all correctly aligned and contain no holes, thus > the attribute is redundant and negatively impacts performance, so we > remove the attributes entirely. > > Signed-off-by: Kieran Bingham Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds