Received: by 10.213.65.68 with SMTP id h4csp858206imn; Wed, 14 Mar 2018 02:08:04 -0700 (PDT) X-Google-Smtp-Source: AG47ELvApfJ3pMztdxhtSmwD6QefsIfq789Aok7AQR7fLpt2EoEpOaSkdAZkXVPaoKsoVxuW6xry X-Received: by 10.101.101.139 with SMTP id u11mr3145288pgv.450.1521018484060; Wed, 14 Mar 2018 02:08:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521018484; cv=none; d=google.com; s=arc-20160816; b=E/wmDQAbS6P8E7aqn9GSOniKSriTCq60kgnheopGB7RzXNBPhnlNFYv213GJLYUA4x gN3sacZnsxdQJco3qliK1sINw4dPzJEex752WYxff5OSP9Km7PMax0yB3VSuhvYHa3cE tDb4o2TbCBTjD58tbnE/PQfWJvCncTTx9D0r0bnmElMOjvG9TNnAtUCgUQE7L1i0Mog5 SD+0th0941Id41YUyL6hURqBsmKb5HeBRvTzJGlgScn5vGx5d9DyiiDqRl0Lp8ZmIo8g MvZ4ajx+CgCILpZn4JYFQ7DlPajh4JVRrz/tJoFpWaQ82NTjuxk2wiH4nA4xeu/Y06r4 L6MA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:cc:references:to :subject:dkim-signature:arc-authentication-results; bh=TyvZa+n07+9WlY5as5wfSklA6vuPw8ZjSp7BR6e1huA=; b=zDCas/uUe3K93f4/WJvG9RigmQNd/GiKdlq5bcnIzkDmMcvlmUNzGaCe7RvkfjTiU6 gFmoTh85Ljdx9LuR7rGsShOiZp2lGZ31Hag646fpK+I8IYxDxhcJQ1NfXj20jv10oA2f Yw/uR69XDpqZVCGPjf/v4iA5R5wM4BXJTFrVXwrynGpfmIvuykbrLRLChFNt19swVbpz UqEfgmNvCSIC9pf1+tVvBJdI+Fm55tYPQtsblIFDZmXjYoovuQE0cr2PGzODXCflKHPQ 7e7+pmIy1PFFSlmA0OvX84OVWNfy4Jh45BmmzcdRNyzyz5mQX4eVP4bZVC82CTN/faDM EZIQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=VHfsoe3/; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t67si1760704pfi.285.2018.03.14.02.07.49; Wed, 14 Mar 2018 02:08:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=VHfsoe3/; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751700AbeCNJGo (ORCPT + 99 others); Wed, 14 Mar 2018 05:06:44 -0400 Received: from mail-qt0-f194.google.com ([209.85.216.194]:42993 "EHLO mail-qt0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751015AbeCNJGm (ORCPT ); Wed, 14 Mar 2018 05:06:42 -0400 Received: by mail-qt0-f194.google.com with SMTP id t6so2613160qtn.9 for ; Wed, 14 Mar 2018 02:06:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=TyvZa+n07+9WlY5as5wfSklA6vuPw8ZjSp7BR6e1huA=; b=VHfsoe3/toN25Oz0zraDlXDNOyJYcwR41fy6PQPhPsubswINxGJXJfC8N6iGz5Mk9k voPO4GgVCzehWat+N+QLDzk5P9YaqrV+NMVEowaprki1LEhaH7Rruc9oNWJeJjPUjpim 4Gbfiw1m96xbijJQMOdSfP7wZ4GVlTxJanpqs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=TyvZa+n07+9WlY5as5wfSklA6vuPw8ZjSp7BR6e1huA=; b=UUsViBuaTX1g0JhjgSpyil1qJBFrJ4P+pRVVnvt66XnLyk3M4aUAp2Bup/hsKDc4zK 71CSCUhmPNLfonFrh2BhuAbBaJ5UT2pP3Torez8HwpXYNC5ENTduLzQhyCBT1l0/KRjk AipkcolvibC5uQ87DIKo+9nUCRA7CR3b9p01Jm1lL3IeeRcFD6I/nKLYGyywkd/nd9/d MQG2uF+2ywokzGSeCO7E8pciuZnw3vecuRLgp9GMyFZFsIFOilt5jElbxUjQQbftabhw VImj5HGF6LYfX62sm24CfbR7H2lY+UbLUqHSyKl/qooBQgt5du4h2Y0PWdszAbeOw8MU Y3aA== X-Gm-Message-State: AElRT7HcBj23wtJtndJN/J3xHzTbR+NvHqXtnzlzU1M++hNRH39mQACr MhzAX6hptnlL1j8n0dNc0PFusWcf X-Received: by 10.237.57.197 with SMTP id m63mr5834317qte.249.1521018401963; Wed, 14 Mar 2018 02:06:41 -0700 (PDT) Received: from [10.177.251.65] ([192.19.248.250]) by smtp.gmail.com with ESMTPSA id h184sm1163666qkc.78.2018.03.14.02.06.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Mar 2018 02:06:41 -0700 (PDT) Subject: Re: [PATCH] drivers: base: add description for .coredump() callback To: Arend van Spriel , Greg Kroah-Hartman References: <1518167637-1948-1-git-send-email-aspriel@gmail.com> Cc: LKML From: Arend van Spriel Message-ID: <5AA8E61F.9090500@broadcom.com> Date: Wed, 14 Mar 2018 10:06:39 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <1518167637-1948-1-git-send-email-aspriel@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/9/2018 10:13 AM, Arend van Spriel wrote: > Commit 3c47d19ff4dc ("drivers: base: add coredump driver ops") added > a new callback in struct device_driver, but not a kerneldoc description > so here it is. Hi Greg, Revisiting the header file I notice this patch is not yet applied. I am pretty sure I got an automated email from you regarding the merge window, but nothing else so did this one slip the cracks? Regards, Arend > Fixes: 3c47d19ff4dc ("drivers: base: add coredump driver ops") > Signed-off-by: Arend van Spriel > --- > include/linux/device.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/device.h b/include/linux/device.h > index b093405..0b32a42 100644 > --- a/include/linux/device.h > +++ b/include/linux/device.h > @@ -256,6 +256,7 @@ enum probe_type { > * automatically. > * @pm: Power management operations of the device which matched > * this driver. > + * @coredump: Called through sysfs to initiate a device coredump. > * @p: Driver core's private data, no one other than the driver > * core can touch this. > * >