Received: by 10.213.65.68 with SMTP id h4csp867594imn; Wed, 14 Mar 2018 02:31:15 -0700 (PDT) X-Google-Smtp-Source: AG47ELtkTssW6afafkiydQiyWU3Vae4AOPsVCNUaGobMQt7ZUDhXPUv8yN5wfVY0/IxBw/ks0uIk X-Received: by 2002:a17:902:bf04:: with SMTP id bi4-v6mr3345578plb.59.1521019875644; Wed, 14 Mar 2018 02:31:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521019875; cv=none; d=google.com; s=arc-20160816; b=cfJPCgPF2CLYELkdErZX22o+F7djZTXDryjWK4B7GL/nY/BH2nlVffaMjOEA9IRcl+ 5KZbokhfcXPwqBLAWoGk+BdjBc+9yyUDykSy5TQCtnMlrGJ8tlXTZywnpIhk7eC/es4q 6D10OxF4gZU++ImGpYpp/DTt1IxehrUEjiY3sPKnZVIBHwsWz8AsCsGzwX96ZsZqGLMF hTBNQ6O06RMLVLpAlwolww4cpFKFcoNcp2336u/9LvUzKP3iCx0pAaV95fNp/EI8Rbnk vgPIw35tPVxx8rse84huKDe4jmOW6m/pP9ilffkMScuKTMUywbQLQ2UjvgCR5dJ6So4Z xhSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:subject:cc:from:to :in-reply-to:arc-authentication-results; bh=d2Su2cf4cmkZuyL8WHTZPPTBCiUNxXmgMKEoWUbrtUc=; b=pPLPZ3kjRvVZ1G4Wp82mDn/HU60g/si+nsQ9HXTg1GPeHEocg3bD9PGJOfJaXWKIgz 6+Agn7amI54fo315kKunsIhsnaPmTWcLZy2qlZsn3M+yjJLgFxhilgXR/v+krO023cml jkVkZQ5JiyeY/m63rb/f53hbt0sLiXfEO19yDdPLkaXYLbe0bAyjnXHfFc8TrdvVqZwv 1AQGEA539hBm9DbpbQkmt216m6RVYZKEoz8Y9FRUppvUp3nekL7AuDLpwZVHuGb9HOGM vTrkMgVp0ORFREqLLjEGbX8IqtXLHZMW4KcAKba4i1eDGPt2y0nQjRD53vFZdTiaZN/d i1yg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t4-v6si1677033plb.282.2018.03.14.02.31.01; Wed, 14 Mar 2018 02:31:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752522AbeCNJ3f (ORCPT + 99 others); Wed, 14 Mar 2018 05:29:35 -0400 Received: from ozlabs.org ([103.22.144.67]:34009 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752377AbeCNJ2o (ORCPT ); Wed, 14 Mar 2018 05:28:44 -0400 Received: by ozlabs.org (Postfix, from userid 1034) id 401RHG6psmz9sVP; Wed, 14 Mar 2018 20:28:33 +1100 (AEDT) X-powerpc-patch-notification: thanks X-powerpc-patch-commit: 1ff3b404019adf9d605224e1dce0677a0375d274 In-Reply-To: <20180304173132.19677-1-vaibhav@linux.vnet.ibm.com> To: Vaibhav Jain , Balbir Singh From: Michael Ellerman Cc: Vaibhav Jain , Frederic Barrat , linux-kernel@vger.kernel.org, Paul Mackerras , Nicholas Piggin , Douglas Miller , linuxppc-dev@lists.ozlabs.org Subject: Re: xmon: Clear all breakpoints when xmon is disabled via debugfs Message-Id: <401RHG6psmz9sVP@ozlabs.org> Date: Wed, 14 Mar 2018 20:28:33 +1100 (AEDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2018-03-04 at 17:31:32 UTC, Vaibhav Jain wrote: > Presently when xmon is disabled by debugfs any existing > instruction/data-access breakpoints set are not disabled. This may > lead to kernel oops when those breakpoints are hit as the necessary > debugger hooks aren't installed. > > Hence this patch introduces a new function named clear_all_bpt() > which is called when xmon is disabled via debugfs. The function will > unpatch/clear all the trap and ciabr/dab based breakpoints. > > Signed-off-by: Vaibhav Jain > Reviewed-by: Balbir Singh Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/1ff3b404019adf9d605224e1dce067 cheers