Received: by 10.213.65.68 with SMTP id h4csp867767imn; Wed, 14 Mar 2018 02:31:39 -0700 (PDT) X-Google-Smtp-Source: AG47ELsV6NaxsvdQMi1jQ3JYCKXjqDGEZU5AHPLRv8yosxXXU7qN/+KRUOxKIWqnLb9BREaaWxrY X-Received: by 2002:a17:902:3041:: with SMTP id u59-v6mr3365210plb.115.1521019899736; Wed, 14 Mar 2018 02:31:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521019899; cv=none; d=google.com; s=arc-20160816; b=tisKcZGBuxNUg+4/vyU2f0XV5ZfWoxMpvDgbzntj7gdkdz8VCz0je8RoZ5JdRpD68J YM7Ap76N/unTsjF23h6ecEg0gnbxiYSYFUdcFB9LzJvUzsALlt/ypgR/bO/b9YYxNHzA gWGH3EImdLdOqBdJpXzAKEhFQCO+EplS2OUyyiAEmH1W7eoumDNyGOZBP2cGfaj1Gx0X dxs4pzy519Jjyr85MJaRCXqcFIvZ1pkJmGitxBdbQQqxJw9MmRl0ib2sUuyaw8NC/4kk Q5Syyqlv13h3rsFF6SXIx8STSK6EEEM9GojUveJpE2b/Vun5GGwPY0Kh0r7ba1u6xRkf sitg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:subject:cc:from:to :in-reply-to:arc-authentication-results; bh=s7N9oOYYZgl62TD108Dz1JK2rzmDFkWumyzbUe/+8Ds=; b=UoiG59XVLwECmarucWjkl9O6FgbxUvZ3vALn8ct1dp5zo2rlEaPcfllLxddsH8BAOy fMW7rPNcuRKQvKtY7IZPttgIS7JKN2d3oGrh793JpWtSYzdi5G0QlNLebZA8oDooySr+ mK45ITqCgIj2qIW0EPqYchqXIcn34Zmdb+vFdp8SZSkr966h5/6bVPZkppInw08LR16n Yygq0pRqsge4M8vZgOnwXhEnnqYikX8BMbwauOYHBb9RPtuYF6JZJrw0orjfKRcwrLBi /oHBMnW0QoeyR0Q2LIrybCENtNxfM/AA0DN2ALpZWFe9OHMQnjl/Tfjghyh9iUN3pD5/ 1Qhw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x75si1811639pff.339.2018.03.14.02.31.24; Wed, 14 Mar 2018 02:31:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752486AbeCNJ3I (ORCPT + 99 others); Wed, 14 Mar 2018 05:29:08 -0400 Received: from ozlabs.org ([103.22.144.67]:51507 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752419AbeCNJ2y (ORCPT ); Wed, 14 Mar 2018 05:28:54 -0400 Received: by ozlabs.org (Postfix, from userid 1034) id 401RHS1y6kz9sRX; Wed, 14 Mar 2018 20:28:43 +1100 (AEDT) X-powerpc-patch-notification: thanks X-powerpc-patch-commit: 97c6f25d5828b497e3e802b1f7c70187c88df623 In-Reply-To: <1520412364-2680-1-git-send-email-wei.guo.simon@gmail.com> To: wei.guo.simon@gmail.com, linuxppc-dev@lists.ozlabs.org From: Michael Ellerman Cc: Simon Guo , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: PCI/hotplug: ppc: correct a php_slot usage after free Message-Id: <401RHS1y6kz9sRX@ozlabs.org> Date: Wed, 14 Mar 2018 20:28:43 +1100 (AEDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2018-03-07 at 08:46:04 UTC, wei.guo.simon@gmail.com wrote: > From: Simon Guo > > In pnv_php_unregister_one(), pnv_php_put_slot() might kfree > php_slot structure. But there is pci_hp_deregister() after > that with php_slot reference. > > This patch moves pnv_php_put_slot() to the end of function. > > Signed-off-by: Simon Guo Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/97c6f25d5828b497e3e802b1f7c701 cheers