Received: by 10.213.65.68 with SMTP id h4csp870685imn; Wed, 14 Mar 2018 02:38:46 -0700 (PDT) X-Google-Smtp-Source: AG47ELuTCJa39RlvEga+ug/13Lz2KsE+1gJmxsdIaoPNW7t6MrzKusHtLHtGVow2De67nS+5VK9V X-Received: by 10.98.141.205 with SMTP id p74mr3637803pfk.211.1521020326349; Wed, 14 Mar 2018 02:38:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521020326; cv=none; d=google.com; s=arc-20160816; b=FdRHqlmRo6/02qSUnm/l+CuAoF9uBB+rvTsiiTLEXCktFZhLP6nFasdOCKedtWESz0 mCWSTkkfqwuirR+pjVYKxwUhxqmHmwTbDMfCobfb3sC8w3otOkmN0t520eivYqLkSsU5 CT+EwUSNcTtihJi4fJKsd3zMOvJTv6heWkht8yJMA2qMtdofeBF4HMLFhFklQ96VMiOy j1IybLnzJhmNVrMNmOglJkpKTbKHdRlJRweXg6wfSxPvhqP37OgErs2slU7paVtEC9Xy 7rKTaNQvvJs81jNaRdOVrm9tBoqz6ed80f1P1CfUs5f7cfRJKEhXT7XUDfGrJFeQHn0T CC6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=+Cerddbdlr6kTVWuc/t6Q4BKHvgC4hfVQdI6rKkGLPA=; b=IET7lG3Lk3EoBZhhjTVX7uRX93cc01GAcntwzQd6reQjSarCKxtinxeB50R9mJu6j9 nCKKOExEUXXQ6AdDmD4rNU5XVEB/AdWzAEm0dvJBC80oN1SAiErsrrQC6g691l8OA6jn EwFo+UG9BHHx/KJBK71n+YjGIK7MJjl5dGcIuz9ZWDbS1EFD+cgNAUZg1vaJ1HP0jPpw w5B/aMlCNX68IQbVq98iA3N9ngkFPh19h+Ze7JE8Ua/N9wd94vOjw6bXpsABD9y3mDd7 uJqAC4YwL2u2kZ7pT0tS0kBlGqtT0q5ttM8rgXca8pBnZQicI6KMepx7bP76tP9fCkgW jmIA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v5-v6si1752149ply.427.2018.03.14.02.38.32; Wed, 14 Mar 2018 02:38:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751626AbeCNJhV (ORCPT + 99 others); Wed, 14 Mar 2018 05:37:21 -0400 Received: from mail.bootlin.com ([62.4.15.54]:46368 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751295AbeCNJhT (ORCPT ); Wed, 14 Mar 2018 05:37:19 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id 9E8E9200FB; Wed, 14 Mar 2018 10:37:17 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.bootlin.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0 Received: from localhost (LStLambert-657-1-97-87.w90-63.abo.wanadoo.fr [90.63.216.87]) by mail.bootlin.com (Postfix) with ESMTPSA id 42534200FB; Wed, 14 Mar 2018 10:37:17 +0100 (CET) Date: Wed, 14 Mar 2018 10:37:18 +0100 From: Maxime Ripard To: Giulio Benetti Cc: David Airlie , Chen-Yu Tsai , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] drm/sun4i: Handle DRM_BUS_FLAG_PIXDATA_*EDGE Message-ID: <20180314093717.glamqbj2curklztd@flea> References: <1520963677-124239-1-git-send-email-giulio.benetti@micronovasrl.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4h5ue7ns54l4oqxk" Content-Disposition: inline In-Reply-To: <1520963677-124239-1-git-send-email-giulio.benetti@micronovasrl.com> User-Agent: NeoMutt/20180223 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --4h5ue7ns54l4oqxk Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 13, 2018 at 06:54:37PM +0100, Giulio Benetti wrote: > Handle both positive and negative dclk polarity, > according to bus_flags, taking care of this: >=20 > On A20 and similar SoCs, the only way to achieve Positive Edge > (Rising Edge), is setting dclk clock phase to 2/3(240=B0). > By default TCON works in Negative Edge(Falling Edge), this is why phase > is set to 0 in that case. > Unfortunately there's no way to logically invert dclk through IO_POL > register. > The only acceptable way to work, triple checked with scope, > is using clock phase set to 0=B0 for Negative Edge and set to 240=B0 for > Positive Edge. > On A33 and similar SoCs there would be a 90=B0 phase option, but it divid= es > also dclk by 2. > This patch is a way to avoid quirks all around TCON and DOTCLOCK drivers > for using A33 90=B0 phase divided by 2 and consequently increase code > complexity. >=20 > Signed-off-by: Giulio Benetti Applied, thanks! Maxime --=20 Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com --4h5ue7ns54l4oqxk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE0VqZU19dR2zEVaqr0rTAlCFNr3QFAlqo7U0ACgkQ0rTAlCFN r3QNwRAAjNMJiq7njfEmhIRERvLHNq3qFUGqbl9esEEnqGP/P5OuakeQqprKnSOa RT8KSsUuyudtwHirvenjgkEzmdXWm6Du5MKwykSnH1WfDnEbKcaI3i2ueMXbNQuh BBE/zvAgwnVMwn9i2wvkfYtBexilaFADLJtvvr4UpUK7BTcT1E/k0YzxCTXqFIFb JVRinrFqKhqqGQo/Uny5Hx3TL8p/sjAmpU9sjJL6EL9/dzWuo7vpxMyYslcP8y5P 0E2Ompqlrh02aGZqePqqS1mdiuVzalQui1LKeDeJm4Hg3VEy785YGVoRb5RPqADX V+BxBDebE/YNAwj8lV7iGiiv1mcoJT0d4fXGkXnq3Qu5SrQo5iz4iu7UCNwcmB1q tPl3neofmnaGAaXgz16cjN0n9ZycgRNZyf0NcNr059VFhFquiy+VZ6bKIu3na27m T37FLdOQCfdtEeJo6C8RCQSuinioXrb/AuE1cAZaTABuYk0iE5QWcqtZSNXmHTgE tiIU2XhacjgdFLVjblBVWGXhAfHMeeMu//vpRhGH+q3krn7lfZLAESqbwtt3vupD slRUBziRYVILt+fZApKQ79N8FA4RCEihRULSx8X5DVNYqbHaEGXhoLR3gMf3qEEC Q7TQDfvMhNoJH92hyFaL2MlF+IaE0OOcbv6VrcEeqvEGfQYLHuM= =F+p/ -----END PGP SIGNATURE----- --4h5ue7ns54l4oqxk--