Received: by 10.213.65.68 with SMTP id h4csp889824imn; Wed, 14 Mar 2018 03:21:19 -0700 (PDT) X-Google-Smtp-Source: AG47ELuazbm8LtJc4BQjMrRXX0EytbgaPJhdyL9O2053jPhAnqIFnzxGOFbxZzeavYLoICvrALms X-Received: by 10.98.76.26 with SMTP id z26mr3802534pfa.220.1521022879353; Wed, 14 Mar 2018 03:21:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521022879; cv=none; d=google.com; s=arc-20160816; b=oPuwLLEPOdprSH3XkPRVJjUztwh++BbFrddi8IAj1wC2hP8Xc6vYUDEy0yoxuc3n4I OYl1mi3yWgLfuAmq5psDhQQFn4R4wU2FadrPTW0IK6ewjA2DNHG9cuk62flO2eVhAAtL r+uK/pYOas+CLYaHg8WjMMXgn9M2LbNR1JANFiLG1eprAWZovI4Cks1egdsQY9ikLRMl WXy5sXrYDHK692t2baqDUlWrTwKGmfPvoAivm1IjltSJE/TFTNan8quizbnnyWAgPchS HTgyCzNf00EX3YQqHwC+U+BEdOdIRsDMZOcgWW/nSdrW7R1C8YzRFpVkda5+YNuM6tAX 9Aew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:arc-authentication-results; bh=W9fiIhB4BlfafVZ9QB7iI5nRmi3ga8Pan5+emXywUvI=; b=HDP7qU3CdJaRiOk7qjDJeeYi/3bd+run7DZ0ucHIesee2e8xlyzAf7ph0OPMtgufvj McUpuOp4hjW0ZazEPvST/OTtgBLpIh/BBlnROEiDMpwdRIfzQ6RU8FkPiqlpZ4zm00yw 3vae6Vysq764xx7ekG8n+LhgXr6/wB316KqNuLXx/kk45HHS4NK9Ijao852/9R/J1N1P 9j8PaggWI/a+Dlb5EcuYn7L65K/U6SobEDMlOH9ojGvRk7rHf+T5EA+voQTKdQ0FNGGw eq073Q2hHsXtb9ZzUZx4X0eHHBoUBC7UeVRJIixs7MFjCdPwDRJt0YdUnwfprS1PuvGb OG6w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q3-v6si1738972plb.221.2018.03.14.03.21.00; Wed, 14 Mar 2018 03:21:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751372AbeCNKTz (ORCPT + 99 others); Wed, 14 Mar 2018 06:19:55 -0400 Received: from vegas.theobroma-systems.com ([144.76.126.164]:43265 "EHLO mail.theobroma-systems.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750818AbeCNKTy (ORCPT ); Wed, 14 Mar 2018 06:19:54 -0400 Received: from [86.59.122.178] (port=55971 helo=ju27.lan) by mail.theobroma-systems.com with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1ew3Vf-0002Oc-U8; Wed, 14 Mar 2018 11:19:52 +0100 Subject: Re: [PATCH v2 1/1] can: ucan: add driver for Theobroma Systems UCAN devices To: Wolfgang Grandegger Cc: Martin Elshuber , Philipp Tomsich , Marc Kleine-Budde , linux-can@vger.kernel.org, linux-kernel@vger.kernel.org References: <20180313173520.21257-1-jakob.unterwurzacher@theobroma-systems.com> <20180313173520.21257-2-jakob.unterwurzacher@theobroma-systems.com> <03024ab7-5386-3bcf-76f2-ef2e0e9e7a78@theobroma-systems.com> <68564c40-396b-9081-8534-67fe96a6fb3f@grandegger.com> <92e559b1-d392-015e-1aa1-0497cbd4c071@grandegger.com> <5b3df9d5-3e65-1114-4b51-9dcc329cbc31@theobroma-systems.com> From: Jakob Unterwurzacher Message-ID: Date: Wed, 14 Mar 2018 11:19:51 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14.03.18 11:04, Wolfgang Grandegger wrote: >>>     controller-problem{rx-error-warning,tx-error-warning,rx-error-passive,tx-error-passive} > > Just, > > controller-problem{rx-error-passive,tx-error-passive} Ok. >> (1b) cable gets connected: >> >>>  (000.000883)  can0  20000034   [8]  00 3C 00 00 00 00 80 00   ERRORFRAME >>>     controller-problem{rx-error-warning,tx-error-warning,rx-error-passive,tx-error-passive} >>> >>>     transceiver-status >>>     no-acknowledgement-on-tx >>>     error-counter-tx-rx{{128}{0}} >>>  (000.000996)  can0  20000004   [8]  00 0C 00 00 00 00 7F 00   ERRORFRAME >>>     controller-problem{rx-error-warning,tx-error-warning} >>>     error-counter-tx-rx{{127}{0}} > > Back to error active is missing!? Have a look to: > > https://elixir.bootlin.com/linux/latest/source/drivers/net/can/dev.c#L364 Should be sent out once the error counter drops further, will check. Thanks, Jakob