Received: by 10.213.65.68 with SMTP id h4csp947580imn; Wed, 14 Mar 2018 05:14:24 -0700 (PDT) X-Google-Smtp-Source: AG47ELt3qxtFnqmXs5K8DG2aDj9lHIK+bn3CejmuzC3c6fezwFh3sHT5dNRJBU7gW1vgE6ZDbZ+g X-Received: by 2002:a17:902:9a45:: with SMTP id x5-v6mr3861499plv.18.1521029664617; Wed, 14 Mar 2018 05:14:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521029664; cv=none; d=google.com; s=arc-20160816; b=bTxk7ooEb4hEhmliEALstt4tZtFldO8cVsT8G9yChhRvVW661z0E0YoUN3AI76FHyt BLCUEsDZzpOWAVmMdT6/W3fNc9tPsTSH5MlTk3nUS9ZLrZeFr4rr3EWOpbuH7ZVdK7CG cWQSavyriknlqko7KV8cPlFDvpN++0Jf2hDGxLICKuF09X28INENwIXDMrZOR+wZBLSn fEkTWdJJh3xCzB4rg6GIJnvMKW+xIxiFvcj048uuA7nlNr8O2A5NdCb5L3a5pCZ8vNBO eOcK0CxTC+3YXUMSfAXTh+Y4R9TiJ8hvMl/nlPewNUdJkltbbUQR9fAJdeUHNtxrELMp VedA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:message-id:references :in-reply-to:subject:cc:to:from:date:content-transfer-encoding :mime-version:dkim-signature:dkim-signature :arc-authentication-results; bh=ujn069WLDrljgpWCRXGxo93N1Rl4sPiKBhT8QR2ud4U=; b=nQZP8xNTlSFQ4BD+9nR6jm1iDQBk/O2lzOjXHkDk5+B5RmrmcUJozG/lDMxAisgmmk 7H04BuQlD38Fzyq48nzIVEVxi/jmDVgKlRz+SSb8bq6Kc3eVyQyhKutRPYJNKDC0LreA Aowa7ZpriI8CU8yulJTfupb7Rp1ob/CDBzAu1xykaWoD+lyi/uqPJptkaj8h9hafyZ+b z6r3hA1V/hhjrYoYNNCKtDkCw30jeXwoz+cPnCKuX6Zo2EeHEkXt7ZHPm+LuUSHXpzsZ BgwNXZ1hmxjEgRpE4+6G1N1L2oaFiZWH1GGMga4Ri1PK/sfcp+BRP6TuvRde+Q58Sj/D w35g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=TX2RfXK3; dkim=pass header.i=@codeaurora.org header.s=default header.b=TX2RfXK3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t7si629140pgq.426.2018.03.14.05.14.09; Wed, 14 Mar 2018 05:14:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=TX2RfXK3; dkim=pass header.i=@codeaurora.org header.s=default header.b=TX2RfXK3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751474AbeCNMNH (ORCPT + 99 others); Wed, 14 Mar 2018 08:13:07 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:60954 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750855AbeCNMNG (ORCPT ); Wed, 14 Mar 2018 08:13:06 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 8E96D60851; Wed, 14 Mar 2018 12:13:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521029585; bh=r1rCKK6Cjhv2ErcxlcLeYcEdF4IhVo3jZx/ajuZk7A0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=TX2RfXK3C/1oTX79pbb4/ptMTbPE1FhoQttCwkpXtmtVCGKaE4s2qEAvoDvQLEFmw sodnWkurxRk66CprBlqODZRCOHAnPBOzLdubzURVLan3bW4xatSoQZ6nndvZk+QFPY xB9u7zFxzZtfrEWkSaXOj4YqVnCnZjLyEpmrBDtY= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.codeaurora.org (Postfix) with ESMTP id 206FF602FC; Wed, 14 Mar 2018 12:13:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521029585; bh=r1rCKK6Cjhv2ErcxlcLeYcEdF4IhVo3jZx/ajuZk7A0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=TX2RfXK3C/1oTX79pbb4/ptMTbPE1FhoQttCwkpXtmtVCGKaE4s2qEAvoDvQLEFmw sodnWkurxRk66CprBlqODZRCOHAnPBOzLdubzURVLan3bW4xatSoQZ6nndvZk+QFPY xB9u7zFxzZtfrEWkSaXOj4YqVnCnZjLyEpmrBDtY= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 14 Mar 2018 08:13:05 -0400 From: okaya@codeaurora.org To: Timur Tabi Cc: netdev@vger.kernel.org, sulrich@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jeff Kirsher , intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 7/7] ixgbevf: eliminate duplicate barriers on weakly-ordered archs In-Reply-To: <12150aa0-77ba-878e-31f4-d4f8d6a28ccb@codeaurora.org> References: <1520997629-17361-1-git-send-email-okaya@codeaurora.org> <1520997629-17361-7-git-send-email-okaya@codeaurora.org> <12150aa0-77ba-878e-31f4-d4f8d6a28ccb@codeaurora.org> Message-ID: <2a4f4dec64b7462ae64152f6c2df9754@codeaurora.org> X-Sender: okaya@codeaurora.org User-Agent: Roundcube Webmail/1.2.5 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018-03-14 01:08, Timur Tabi wrote: > On 3/13/18 10:20 PM, Sinan Kaya wrote: >> +/* Assumes caller has executed a write barrier to order memory and >> device >> + * requests. >> + */ >> static inline void ixgbevf_write_tail(struct ixgbevf_ring *ring, u32 >> value) >> { >> - writel(value, ring->tail); >> + writel_relaxed(value, ring->tail); >> } > > Why not put the wmb() in this function, or just get rid of the wmb() > in the rest of the file and keep this as writel? That way, you can > avoid the comment and the risk that comes with it. Sure, both solutions will work. I want to see what the maintainer prefers. I can repost accordingly.