Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 14 Mar 2018 08:51:46 -0500
From:   Josh Poimboeuf <jpoimboe@redhat.com>
To:     Ingo Molnar <mingo@kernel.org>
Cc:     tip-bot for Andy Whitcroft <tipbot@zytor.com>,
        linux-tip-commits@vger.kernel.org, hpa@zytor.com,
        dave.hansen@linux.intel.com, arjan@linux.intel.com,
        dwmw@amazon.co.uk, gregkh@linuxfoundation.org,
        torvalds@linux-foundation.org, apw@canonical.com, bp@alien8.de,
        luto@kernel.org, dan.j.williams@intel.com, tglx@linutronix.de,
        linux-kernel@vger.kernel.org, dwmw2@infradead.org,
        peterz@infradead.org
Subject: Re: [tip:x86/pti] x86/speculation, objtool: Annotate indirect
 calls/jumps for objtool on 32-bit kernels
Message-ID: <20180314135146.o5pb434qwftkhui5@treble>
References: <20180314112427.22351-1-apw@canonical.com>
 <tip-a14bff131108faf50cc0cf864589fd71ee216c96@git.kernel.org>
 <20180314130329.cmsc7mqnfrm2iop2@treble>
 <20180314133943.t5dorqzvlieotljx@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20180314133943.t5dorqzvlieotljx@gmail.com>
User-Agent: Mutt/1.6.0.1 (2016-04-01)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Mar 14, 2018 at 02:39:43PM +0100, Ingo Molnar wrote:
> 
> * Josh Poimboeuf <jpoimboe@redhat.com> wrote:
> 
> > On Wed, Mar 14, 2018 at 05:28:01AM -0700, tip-bot for Andy Whitcroft wrote:
> > > Commit-ID:  a14bff131108faf50cc0cf864589fd71ee216c96
> > > Gitweb:     https://git.kernel.org/tip/a14bff131108faf50cc0cf864589fd71ee216c96
> > > Author:     Andy Whitcroft <apw@canonical.com>
> > > AuthorDate: Wed, 14 Mar 2018 11:24:27 +0000
> > > Committer:  Ingo Molnar <mingo@kernel.org>
> > > CommitDate: Wed, 14 Mar 2018 13:24:31 +0100
> > > 
> > > x86/speculation, objtool: Annotate indirect calls/jumps for objtool on 32-bit kernels
> > > 
> > > In the following commit:
> > > 
> > >   9e0e3c5130e9 ("x86/speculation, objtool: Annotate indirect calls/jumps for objtool")
> > > 
> > > ... we added annotations for CALL_NOSPEC/JMP_NOSPEC on 64-bit x86 kernels,
> > > but we did not annotate the 32-bit path.
> > > 
> > > Annotate it similarly.
> > 
> > This patch has no effect because objtool only supports 64-bit kernels.
> 
> Yeah, indeed - but it's still a good change for completeness, right?

Yeah, it's fine.  Objtool won't use it, but I suppose it makes the code
less surprising and more consistent for humans.

-- 
Josh