Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Reply-To: monstr@monstr.eu
Subject: Re: Bug: Microblaze stopped booting after
 0fa1c579349fdd90173381712ad78aa99c09d38b
From:   Michal Simek <monstr@monstr.eu>
To:     "Alvaro G. M." <alvaro.gamez@hazent.com>,
        Rob Herring <robh@kernel.org>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20180309125106.GA1644@salem.gmr.ssr.upm.es>
 <CAL_JsqLenrLARsjHvkkL3ByuXARPShz-VAEBDE2FukJc=vD+Sg@mail.gmail.com>
 <20180312075252.GA15895@salem.gmr.ssr.upm.es>
 <242c2823-258b-d3bb-cd0a-e4eee6b979c6@monstr.eu>
Message-ID: <4d5dc903-0e88-e1b9-9761-43a84865c45b@monstr.eu>
Date:   Wed, 14 Mar 2018 16:04:31 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <242c2823-258b-d3bb-cd0a-e4eee6b979c6@monstr.eu>
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="XVxKwh5F00jj53KUQKTj6Ck0nS5AWfERm"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--XVxKwh5F00jj53KUQKTj6Ck0nS5AWfERm
Content-Type: multipart/mixed; boundary="chwdbNl9btemPMxnHAJzCChmolv9r8Yie";
 protected-headers="v1"
From: Michal Simek <monstr@monstr.eu>
Reply-To: monstr@monstr.eu
To: "Alvaro G. M." <alvaro.gamez@hazent.com>, Rob Herring <robh@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Message-ID: <4d5dc903-0e88-e1b9-9761-43a84865c45b@monstr.eu>
Subject: Re: Bug: Microblaze stopped booting after
 0fa1c579349fdd90173381712ad78aa99c09d38b
References: <20180309125106.GA1644@salem.gmr.ssr.upm.es>
 <CAL_JsqLenrLARsjHvkkL3ByuXARPShz-VAEBDE2FukJc=vD+Sg@mail.gmail.com>
 <20180312075252.GA15895@salem.gmr.ssr.upm.es>
 <242c2823-258b-d3bb-cd0a-e4eee6b979c6@monstr.eu>
In-Reply-To: <242c2823-258b-d3bb-cd0a-e4eee6b979c6@monstr.eu>

--chwdbNl9btemPMxnHAJzCChmolv9r8Yie
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable

On 12.3.2018 11:21, Michal Simek wrote:
> On 12.3.2018 08:52, Alvaro G. M. wrote:
>> On Fri, Mar 09, 2018 at 01:05:11PM -0600, Rob Herring wrote:
>>> On Fri, Mar 9, 2018 at 6:51 AM, Alvaro G. M. <alvaro.gamez@hazent.com=
> wrote:
>>>> Hi,
>>>>
>>>> I've found via git bisect that 0fa1c579349fdd90173381712ad78aa99c09d=
38b
>>>> makes microblaze unbootable.
>>>>
>>>> I'm sorry I can't provide any console output, as nothing appears at =
all,
>>>> even when setting earlyprintk (or at least I wasn't able to get anyt=
hing
>>>> back!).
>>>
>>> Ah, looks like microblaze doesn't set CONFIG_NO_BOOTMEM and so
>>> memblock_virt_alloc() doesn't work for CONFIG_HAVE_MEMBLOCK &&
>>> !CONFIG_NO_BOOTMEM. AFAICT, microblaze doesn't really need bootmem an=
d
>>> it can be removed, but I'm still investigating. Can you try out this
>>> branch[1].
>>>
>>> Rob
>>>
>>> [1] git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git
>>> microblaze-fixes
>>
>> Hi, Rob!
>>
>> This branch does indeed solve the issue. My microblaze system is now
>> booting as it did before, and everything seems normal now. Thanks!
>>
>> Tested-by: Alvaro Gamez Machado <alvaro.gamez@hazent.com>
>>
>=20
> I have tested it and I can also confirm that your two patches are fixin=
g
> issue with
>=20
> 809d0e2c: 00240034 26000000 746f6f62 206d656d    4.$....&bootmem
> 809d0e3c: 6f6c6c61 666f2063 33353220 62203830    alloc of 25308 b
> 809d0e4c: 73657479 69616620 2164656c 00000000    ytes failed!....
> 809d0e5c: 00000000 0029003c 06000000 6e72654b    ....<.).....Kern
> 809d0e6c: 70206c65 63696e61 6e202d20 7320746f    el panic - not s
>=20
> Can you please update that second commit with reasonable description an=
d
> send it out? I will take it via my tree and will send pull request to L=
inus.
>=20

I couldn't wait to fix current issue till 4.16 is done that's why I have
sent that patches with updated commit message to lkml.

Thanks,
Michal


--=20
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP SoCs


--chwdbNl9btemPMxnHAJzCChmolv9r8Yie--

--XVxKwh5F00jj53KUQKTj6Ck0nS5AWfERm
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iEYEARECAAYFAlqpOf8ACgkQykllyylKDCFlmACeNWsqJIbmfylPILGyFh+qwyTP
sHQAoInVLk3+kq50k7pIWq1iaRMePu1j
=hyu5
-----END PGP SIGNATURE-----

--XVxKwh5F00jj53KUQKTj6Ck0nS5AWfERm--