Received: by 10.213.65.68 with SMTP id h4csp1111103imn; Wed, 14 Mar 2018 09:55:17 -0700 (PDT) X-Google-Smtp-Source: AG47ELtWKUEZtyHvTal3604D6rwW85IPILtyUU4KlsfmpmTHaiQRD3NcUSdSReGUGCcwWJ6hDXq2 X-Received: by 10.99.127.91 with SMTP id p27mr4260323pgn.28.1521046517756; Wed, 14 Mar 2018 09:55:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521046517; cv=none; d=google.com; s=arc-20160816; b=VMRGNFWLVcyC05CEOc9aNDWdaX0kxk7eiXFDx+szVBF8nqbgWhht7Qsy6nGxYh+DSq kJzQB9THogivOTIyLEXaezMAwxRLrCQNOQ68eIgW1fk/SXwKz2m5i1V6vXGIlYv5LMXV Ogk5wlM4JwJqAkn8m6vriznzRL4vi5jYKkjoG6jng73hT2LfSpn6vHLw7+zkpPfZlBMG dhN5FZXHl780IxWGEZH9m/DXJqko4zk+m98fVqhSGuTdqcJbY6OQUoun62WHKwghiSVm 8BJ3/jOtfdJSfcWfYShauo3KL89GlB1NTYdkGdjqEFUiCZArypxBC6+1uHVNmX3CKQb7 aZ9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:from:cc:message-id:date:subject :dkim-signature:arc-authentication-results; bh=SICojs0BKRvm3Wgo/cvtfWx+wpZR1GeArKOirOWl2/w=; b=PHlZylQb4cgeT/0gp39JWodoInDTXosZ1Db4NAVJCj+4tvVSMxIobF6EkfwsZwLE6K VPmyHGLjm5u/79yYa+/44kSQkwn6R35zLjuKqLjGXCUdBnOsioOqPVoGSzKgoFhn2gf3 J82KF9skLxA9Br9vQ6IhnGSrtZ/YlWsWmjasv4vJ5LyQu2iywlaObaWXHkiMiX/o3sKw 2U/sxzB3Ow3iMxVeRnUh+nZR5l/8+fz6OyJc0R8wNVQzjDSaFIJeGdof3cSsZS6pov1i rO4tDPbiemZeBinAyh5a3Y7ofz+qn+zNos02so5Vp41soXpUIIcafrLDMncisyuhF3kh jyTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sifive.com header.s=google header.b=YBJDwk4z; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ay2-v6si2191173plb.749.2018.03.14.09.55.03; Wed, 14 Mar 2018 09:55:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@sifive.com header.s=google header.b=YBJDwk4z; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751944AbeCNQxq (ORCPT + 99 others); Wed, 14 Mar 2018 12:53:46 -0400 Received: from mail-pl0-f65.google.com ([209.85.160.65]:46512 "EHLO mail-pl0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751131AbeCNQxp (ORCPT ); Wed, 14 Mar 2018 12:53:45 -0400 Received: by mail-pl0-f65.google.com with SMTP id f5-v6so2005856plj.13 for ; Wed, 14 Mar 2018 09:53:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=subject:date:message-id:cc:from:to; bh=SICojs0BKRvm3Wgo/cvtfWx+wpZR1GeArKOirOWl2/w=; b=YBJDwk4z445uQjGRHFZ2+BvjgqbX3xSLIT9Su8MusOkAL3KYMC4YvX/QJi3DpucCXC 2BYhiLvKFnhRqmH9WqxPecJjrjNr1/RccLDCaABJ2/LUbNiTu0dPqv3pG12QExpoxFh9 kvTvIpr2v+BOBx0OxrzDyp4kL0/ZtfiaI0KQxNSEBiasjdn0GwwI9yCeximmiejuS6uN Y3vZECZW/yLJZkA1YMC1jXjKpYzxeXlwXJ6VUpFZMm60CmBAxpyl6izNw5wjdO2c5Bzf MJ2IUlIz3Qo57e6HywncsB25M+Y3d+HatbcaYaZsOHexxXyTWL2FepC5+iSiUBgwXa0c rnRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:date:message-id:cc:from:to; bh=SICojs0BKRvm3Wgo/cvtfWx+wpZR1GeArKOirOWl2/w=; b=UTIPjSf+KdUkLheDm3dNXabW1h0vBl6m70J4+PR3G8XQ31sONvvMNGtY66F0rqocUn GLSouDc35NzlJJnMLDXl1qzJTR25WKZULFfE8cb36a4WVhooaTvE0fKUPzCjc7KNqWVG 80+aMimqtpfyE0oSbmKyT3879R0TfVgMflITvQkti9jUSUhVAC498dYebr7QKZoig7Pg NKE3BssqdhM7mwdHhJdCphSuZeNABkxnJvzF1N5uyiFhAxr8T8XvOliyGxMkff1PwFRf YNHpnSYkqFapMBUiKk3d0ey9BgYISZ4Ok6uGi7tkAHEVSWTlqLP3wP01twVCqtMYoOt8 e7lg== X-Gm-Message-State: AElRT7FFqjxR6hwXqi35E0m2kG1KxPdEjiS8gPj7mcFw/R4bG+ZwfjtU 5KGAvf6RFEYMYwoJTiJeSiuPuA== X-Received: by 2002:a17:902:5785:: with SMTP id l5-v6mr1500295pli.386.1521046424508; Wed, 14 Mar 2018 09:53:44 -0700 (PDT) Received: from localhost ([65.153.83.185]) by smtp.gmail.com with ESMTPSA id y18sm5888528pfl.146.2018.03.14.09.53.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Mar 2018 09:53:43 -0700 (PDT) Subject: [PATCH] RISC-V: Rename CONFIG_CMDLINE_OVERRIDE to CONFIG_CMDLINE_FORCE Date: Wed, 14 Mar 2018 09:41:43 -0700 Message-Id: <20180314164143.11898-1-palmer@sifive.com> X-Mailer: git-send-email 2.16.1 Cc: Palmer Dabbelt , Trung Tran , Moritz Fischer , Michael J Clark From: Palmer Dabbelt To: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The device tree code looks for CONFIG_CMDLINE_FORCE, but we were using CONFIG_CMDLINE_OVERRIDE. It looks like this was just a hold over from before our device tree conversion -- in fact, we'd already removed the support for CONFIG_CMDLINE_OVERRIDE from our arch-specific code so it didn't even work any more. Thanks to Mortiz and Trung for finding the original bug, and for Michael for suggeting a better fix. CC: Trung Tran CC: Moritz Fischer CC: Michael J Clark Signed-off-by: Palmer Dabbelt --- arch/riscv/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig index 04807c7f64cc..992412dda60c 100644 --- a/arch/riscv/Kconfig +++ b/arch/riscv/Kconfig @@ -281,7 +281,7 @@ config CMDLINE_BOOL in CONFIG_CMDLINE. The built-in options will be concatenated to the default command - line if CMDLINE_OVERRIDE is set to 'N'. Otherwise, the default + line if CMDLINE_FORCE is set to 'N'. Otherwise, the default command line will be ignored and replaced by the built-in string. config CMDLINE @@ -291,7 +291,7 @@ config CMDLINE help Supply command-line options at build time by entering them here. -config CMDLINE_OVERRIDE +config CMDLINE_FORCE bool "Built-in command line overrides bootloader arguments" depends on CMDLINE_BOOL help -- 2.16.1