Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Reply-To: nicolas.dichtel@6wind.com
Subject: Re: [PATCH 4.4 24/36] netlink: ensure to loop over all netns in
 genlmsg_multicast_allns()
References: <20180310001807.213987241@linuxfoundation.org>
 <20180310001808.681346858@linuxfoundation.org>
 <1520899459.23626.87.camel@codethink.co.uk>
To:     Ben Hutchings <ben.hutchings@codethink.co.uk>,
        "David S. Miller" <davem@davemloft.net>
Cc:     stable@vger.kernel.org, Johannes Berg <johannes.berg@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        LKML <linux-kernel@vger.kernel.org>
From:   Nicolas Dichtel <nicolas.dichtel@6wind.com>
Organization: 6WIND
Message-ID: <d37d5d6a-2b5d-184b-470b-25a97910988b@6wind.com>
Date:   Wed, 14 Mar 2018 18:06:17 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <1520899459.23626.87.camel@codethink.co.uk>
Content-Type: text/plain; charset=utf-8
Content-Language: fr
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Le 13/03/2018 à 01:04, Ben Hutchings a écrit :
> On Fri, 2018-03-09 at 16:18 -0800, Greg Kroah-Hartman wrote:
>> 4.4-stable review patch.  If anyone has any objections, please let me know.
>>
>> ------------------
>>
>> From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
>>
>>
>> [ Upstream commit cb9f7a9a5c96a773bbc9c70660dc600cfff82f82 ]
> [...] 
>> -	return nlmsg_multicast(prev->genl_sock, skb, portid, group, flags);
>> +	err = nlmsg_multicast(prev->genl_sock, skb, portid, group, flags);
>> +	if (!err)
>> +		delivered = true;
>> +	else if (err != -ESRCH)
>> +		goto error;
> 
> This call to nlmsg_multicast() consumes skb rather than a clone, so we
> must not free it again here.
Right, good catch.

I will send an update.

Regards,
Nicolas