Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20180314102847.30459-1-douly.fnst@cn.fujitsu.com>
References: <20180314102847.30459-1-douly.fnst@cn.fujitsu.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Wed, 14 Mar 2018 19:24:14 +0200
Message-ID: <CAHp75VfGPgbD8gBdvchBn5U8gH93zoHB9ja3KucUuxVNq+_MLg@mail.gmail.com>
Subject: Re: [RFC PATCH] ACPI / processor: Get accurate possible CPU count
To:     Dou Liyang <douly.fnst@cn.fujitsu.com>
Cc:     ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Len Brown <lenb@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Artem Bityutskiy <dedekind1@gmail.com>, ming.lei@redhat.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Mar 14, 2018 at 12:28 PM, Dou Liyang <douly.fnst@cn.fujitsu.com> wrote:

> +static void __init acpi_update_possible_map(void)
> +{
> +       unsigned int cpu, nr = 0;
> +

> +       if (nr_cpu_ids <= nr_unique_ids)
> +               return;
> +
> +       for_each_possible_cpu(cpu) {
> +               if (nr >= nr_unique_ids)
> +                       set_cpu_possible(cpu, false);
> +               nr++;
> +       }

IIUC this can be optimized to:

if (nr_unique_ids >= nr_cpu_ids)
    return;

/* Don't yet figure out if it's superfluous */
if (nr_unique_ids >= cpumask_last(cpu_possible_mask))
    return;

for_each_cpu_wrap(cpu, cpu_possible_mask, nr_unique_ids)
    set_cpu_possible(cpu, false);

> +       nr_cpu_ids = nr_unique_ids;
> +       pr_info("Allowing %d possible CPUs\n", nr_cpu_ids);
> +}

-- 
With Best Regards,
Andy Shevchenko