Received: by 10.213.65.68 with SMTP id h4csp1140650imn; Wed, 14 Mar 2018 10:46:03 -0700 (PDT) X-Google-Smtp-Source: AG47ELt96TJiEWa0uVNawWUy3dqufQb060DzmNQq3oKlffBd68dsRbxb8nvmM6qxpesoryskVxzy X-Received: by 2002:a17:902:68c4:: with SMTP id x4-v6mr4963403plm.198.1521049563155; Wed, 14 Mar 2018 10:46:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521049563; cv=none; d=google.com; s=arc-20160816; b=uN+pdKoDR8DS2+ums0u61GN0kmLwTKFLV/qGX215UaZsTOYSDLQ4Rpaxdkb+m1CA6L IfGIc1M42kEi7tkaOg7HOsbps+u9FMTAWabwYQvUNkuzEqgnbY33KbEuQwtUNIBSsPmW sFooqD+JXOwXfy0qedxczLfPBtuN3qBm5CLC61D3rqP90G0YNTUL/mLMTCM+svcJWQGL jQM71BYFniiYefny8Y0dRoyP+OabU82E1Dj2Y3c+s/nR8iQ7acWeYeA7Zu/giQh+wH9z BDwlQcTjv4Em4XLEYORsdNWEttPRjc69iR8ki4Aq0x42ECZyKUrj5Quq16taE7n7+mo3 R71A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=7HRxrek337rzihAr1zDlenpisNZw5DJ5S2Cb8Dtx+hU=; b=TeRVJMgTbltMqPX9uLksy0grbNa1SUl4LtyMbSHqUl70uLK1+6DWmlVaUmM+lrMsTv 3+b6yvVBI+I7pwenEZr6fAz88JFq/ZZnUl/0fokS9HIDR/Dyvo+O0ZHPlz53IaF7S4ul 8Ez/m8lUbKie4HZxB0pgWBnX08Er4/wavFkaqejW/5KZiB5xNCFhHmCWbvZc7Z7N97Zp WZwvM2YMC1ydKWbhJ94ba8uXP62pD+3td85XUrvvu7VThGQ3DpoLx/dLeM0DsILQk3Bg W5rZ6m16qNZz2vQmdNpAS0DeT5BjNeHaaETySoLTERqaHQBzQ4llKb9cF7+nDG4lWDyt bJmw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k136si2165276pga.630.2018.03.14.10.45.48; Wed, 14 Mar 2018 10:46:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752450AbeCNRoI (ORCPT + 99 others); Wed, 14 Mar 2018 13:44:08 -0400 Received: from mx2.suse.de ([195.135.220.15]:51790 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751700AbeCNRoG (ORCPT ); Wed, 14 Mar 2018 13:44:06 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 4ED35AF8E; Wed, 14 Mar 2018 17:44:04 +0000 (UTC) Date: Wed, 14 Mar 2018 17:44:03 +0000 From: "Luis R. Rodriguez" To: Greg KH , Andrew Morton Cc: "Luis R. Rodriguez" , Kees Cook , Bitterblue of Monsea , Jakub Kicinski , linux-wireless , Shuah Khan , Martin Fuzzey , Mimi Zohar , David Howells , pali.rohar@gmail.com, Takashi Iwai , arend.vanspriel@broadcom.com, =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Nicolas Broeking , Vikram Mulukutla , Mark Brown , Dmitry Torokhov , David Woodhouse , Linus Torvalds , Abhay_Salunke@dell.com, bjorn.andersson@linaro.org, jewalt@lgsinnovations.com, oneukum@suse.com, ast@fb.com, andresx7@gmail.com, LKML , "linux-fsdevel@vger.kernel.org" Subject: Re: [PATCH v3 00/20] firmware: development for v4.17 Message-ID: <20180314174403.GJ4449@wotan.suse.de> References: <20180310141501.2214-1-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 10, 2018 at 09:16:36AM -0800, Kees Cook wrote: > On Sat, Mar 10, 2018 at 6:14 AM, Luis R. Rodriguez wrote: > > Greg, > > > > Here's a respin of what I have queued up for v4.17 for the firmware API. It > > combines the cleanup I've been working on and the addition of the new API call > > request_firmware_cache() for fixing a corner case suspend issue on some type of > > cards with an optimization in place where the firmware is *not* needed on > > reboot. > > > > The cleanup work allows us to test the firmware API with one kernel > > configuration. I've addressed Kees' feedback on this respin and > > combined the code into drivers/base/firmware_class/. > > > > I've made one new test_firmware change in consideration for one firmware > > change, the patch "firmware: ensure the firmware cache is not used on > > incompatible calls" requires us to modify our tests scripts to use > > the APIs sanely as well. > > > > I've put up these changes on my git tree, refer to the branch > > "20180307-firmware-dev-for-v4.17" based on linux-next [0] and > > the same name based on Linus' tree [1]. > > > > Questions, feedback, and specially rants are always welcomed. > > This all looks good to me! Thanks for respinning. :) Greg, I'd like to get these baked a bit through linux-next. Let me know if its easier for you if I go through Andrew for the firmware API changes. Luis