Received: by 10.213.65.68 with SMTP id h4csp1166762imn; Wed, 14 Mar 2018 11:33:40 -0700 (PDT) X-Google-Smtp-Source: AG47ELvRCvSXZIA+M7yx42kKGrXTOB2U+XhnnIhn1xV8PyjsvrBA+EXH5d3tcG+7dNFcPJxZo3Uq X-Received: by 10.99.125.78 with SMTP id m14mr4550195pgn.190.1521052420219; Wed, 14 Mar 2018 11:33:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521052420; cv=none; d=google.com; s=arc-20160816; b=Mjo2mYw7X45QaL/EY3NB6kYkKVuEX3XdhNjD1H473h+KXkcrOU7Kanqw/68sGIEULr osyueh0ljNyuH4dkMSNLx3wEezmi+aZuSp+N67hJiW/FXMawA4iWWgpltIHlFjZO74XW N1Dy7nfZAYgVjIHKYKaQIb9J1SszZ/xx3uPKqorXMWyczs0e9ObaG2rwA92SwhUFROAI mpZEFa2SNYntsrAixz9+wwkATTd1UYFeRXpQTSRQFJBCm4qxS505jH3WD4d0TVPSlEfN kCtt5V42I+OGuEk0KGoBx3qhfATFzUGRsDFB6+BwqauLJAJx7vbdTkWouF5aGTavuwV1 2Tsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=roXaUJ+Vt0lkzg0JSTrGs+OqLMfUGJ2enoOcxh1kqjM=; b=jlU9wyOKZ90gCnknfoUYWOC0qBv6v5KjAA0REo1GnfEUefz7naZim/ZB39ECwDQYOX fIfYCZr9gyHRynLiHkbtZO2mcUyc2K4yMDrd2hzQ5+jF0u4Lp8It1aAegnJETudn95ZV AkzcR9QXaFbrKWTGgzGqYlRHIfPhPWICcu2TULysv+GELnYQo72IMTtv/BypNPRH31Xc oMe4tAobsKciCAJxttYm4QxWE6aQV7zATQMNgCAyqRXIZldr76nhAkDyKP5IxWQd1msb Ntv7B+DtnCReW57FempLG3gmVGrn6iHX8AZGqlADrv/YPTK2z8dsNH3p0ELQKTI99yAo 0bNQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BSX3L+5A; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x5-v6si2419988plm.443.2018.03.14.11.33.21; Wed, 14 Mar 2018 11:33:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BSX3L+5A; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752718AbeCNSau (ORCPT + 99 others); Wed, 14 Mar 2018 14:30:50 -0400 Received: from mail-pl0-f66.google.com ([209.85.160.66]:35121 "EHLO mail-pl0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752330AbeCNSaq (ORCPT ); Wed, 14 Mar 2018 14:30:46 -0400 Received: by mail-pl0-f66.google.com with SMTP id w22-v6so2186173pll.2 for ; Wed, 14 Mar 2018 11:30:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=roXaUJ+Vt0lkzg0JSTrGs+OqLMfUGJ2enoOcxh1kqjM=; b=BSX3L+5ARVIqCGpXJ2XqN6FRZcSkAmej525q0fOK2t4nuNuPPIYjfBBso+pEv82Z0e 4Ni4NHuxtb7RZyrikt/sJcntP1m+hzjlh3h79me8ogky0W2nw3TL0wTmuIRACTLDNPhc gtFj/Nr9wXyc7DdrFhGHckiDm0hkWC3xIZiiw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=roXaUJ+Vt0lkzg0JSTrGs+OqLMfUGJ2enoOcxh1kqjM=; b=V+s7+VNfJijUQYhuG7ozOeVdzxyp4/1YqfmO0K7wrCwmACKfM9cLQtn61XOh4KMUAN BzI+xrkqNuXZmvYFZvycFcRbGHwhgJpUKQjoAeT1+EKYuzMAsq5Zesez+Qu/bLhKatDg 80Hh9fJG3Zl9y0nfcrWW+HKH2tJqadSNpGXFGrlD38UUnbezQotrdpOo2cr3pZbZfP74 rJ/M76Zg31x2jp1ZQgQVE0xwxPmK+CIjXsoswNuKAW3HdbgQC5ALdYZYhT7Tvj9ZO6kg ycBXAcYuW2mJOe7xF8ScYnIKdiMkZVMJ365Sk2/ROT9CgkpIF9DfUY460XOwHBiGP9ue gkJA== X-Gm-Message-State: AElRT7FhVcWVzjML7Tj7cJJT8qWIlbPD2RjjEnRpfnFQ/RQryr0lkemN Cnn7OCZZwKE8NctE7WJH50+/yA== X-Received: by 2002:a17:902:a2:: with SMTP id a31-v6mr4967828pla.204.1521052246196; Wed, 14 Mar 2018 11:30:46 -0700 (PDT) Received: from minitux (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id o128sm7249597pfg.96.2018.03.14.11.30.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 14 Mar 2018 11:30:45 -0700 (PDT) Date: Wed, 14 Mar 2018 11:30:43 -0700 From: Bjorn Andersson To: Marcel Holtmann Cc: Thierry Escande , Rob Herring , Andy Gross , Johan Hedberg , David Brown , Mark Rutland , Andy Shevchenko , Loic Poulain , Srinivas Kandagatla , Linux Bluetooth mailing list , linux-arm-msm@vger.kernel.org, devicetree , linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/3] dt-bindings: net: bluetooth: Add qualcomm-bluetooth Message-ID: <20180314183043.GX18510@minitux> References: <20180314155514.3374-1-thierry.escande@linaro.org> <20180314155514.3374-3-thierry.escande@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 14 Mar 09:13 PDT 2018, Marcel Holtmann wrote: > > + bt-disable-n-gpios = <&pm8994_gpios 19 GPIO_ACTIVE_HIGH>; > > can we use a common name here. I think that Nokia and Broadcom drivers > define one. And if this is the enable/shutdown GPIO, we should name it > consistently across all manufacturers. It essentially does the same on > Bluetooth UART chips no matter what chip is behind them. > Broadcomm has a device-wakup-gpios and Nokia has bluetooth-wakup-gpios. It might be that these behave in the same way, but from the description they only trigger the wakeup. The reason for the proposed naming here is that the pin is named "BT_DISABLE_N" in the datasheet. Regards, Bjorn