Received: by 10.213.65.68 with SMTP id h4csp1249102imn; Wed, 14 Mar 2018 14:17:27 -0700 (PDT) X-Google-Smtp-Source: AG47ELu7t0VPSQTPSLmw7lsMba3FOmOXTH5k0SnCTHlmXOi9aawtK34BHECB0MUKDWUy3opp2NTW X-Received: by 10.99.52.11 with SMTP id b11mr3418317pga.377.1521062247350; Wed, 14 Mar 2018 14:17:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521062247; cv=none; d=google.com; s=arc-20160816; b=xGZSo45rIyF/qynqwR4U6WDc8fZHH8shp75Oi4ugHgarKbgm/BwXiVhmRVvsIiHP6t N5j5DXJoghBokHY6etRlyuROGs3E0rxfuX55inCAPzjIeeWn6Qw07sHqAPg46LPpWqIF AKNw4rZM5CKue+w3OnJ3E7dqpevwdV08gwbhZGiHb1ofvwWDxkGV/ayWrxkzSZKPfyZo zfBQuZCmnA1eD219ItTwdO8o0nyK3mHPXS/iwK8bjkDOmxCKT/KCfC9qupfALqkinvtC orNDS8qKsw/donUyDAqKw0IwL3351U6moYWP+1xqrZl2oegcUrmfa/etKFGkBgD8EQ1z 9B2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:mime-version:user-agent:date:message-id:cc:subject :from:to:arc-authentication-results; bh=5DmET40yWiIRhn7W2+jICZOpUiezl+9Jbm/3KutXLVc=; b=lg6jpWKnoKrpTBhGWSvrX5zP4/UhQ6+BJXquPNzl2FPZOWpduwIH4QUx70D7H2drNk 2nzAOsTM66IKcM1j4yibYUCJFfIgh245ANJLoGBp7d5fVO4cVMU9B9RIjFFFZ4e0tr8h xiJ/tCSkzC+3pGY6VXszmdAJ0fAW0EDB2vu9uXxP3cLcg0xk1W5ZUxuwaeGWzIazhQZf At05VkL648kmoo7GGtjWxLRF9gjQ3bHz+NiaeV99FRGWLgIhbhBc0hdx2oAhhGsSAhPg g6DUeipZubP3BtJ12YkJJrIECpYZ5PjFcmk9ipZvt6Oima0vphobsW+wGv9B89vJ5sRk Tz0A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=sourceforge.net Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j88si2684992pfe.324.2018.03.14.14.17.12; Wed, 14 Mar 2018 14:17:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=sourceforge.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751428AbeCNVQU (ORCPT + 99 others); Wed, 14 Mar 2018 17:16:20 -0400 Received: from mout.web.de ([212.227.15.3]:60763 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750950AbeCNVQS (ORCPT ); Wed, 14 Mar 2018 17:16:18 -0400 Received: from [192.168.1.2] ([85.182.40.79]) by smtp.web.de (mrweb003 [213.165.67.108]) with ESMTPSA (Nemesis) id 0LgpIE-1eK9zD45mY-00oFEM; Wed, 14 Mar 2018 22:15:46 +0100 To: linux-media@vger.kernel.org, Hans Verkuil , Mauro Carvalho Chehab , Sakari Ailus , Todor Tomov From: SF Markus Elfring Subject: [PATCH] [media] ov5645: Move an error code assignment in ov5645_probe() Cc: LKML , kernel-janitors@vger.kernel.org Message-ID: <4efad917-ca08-f257-e9a1-b5bcb7df2df2@users.sourceforge.net> Date: Wed, 14 Mar 2018 22:15:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:/sq3wTAhEFjlN+ZMTk+4g9DAVV4oMDHnerC0jI6LA0vLp+6IBm+ FcNkropneUZ54xRjOVfDcuJB730tmh2qspaVIA/JQIn7LlWY9ik1LDCQKu//PayHgIOcg5I NwHZ49sU/L6Aa1pu/l4NMelSDv/SumgmswL/9EXvT9tL2wPLo2ToBVED4mthnoWV+OmIhy0 X1xxsQcUx3z1dTTJcIvjQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:AFEGNsK5Kp4=:vEyhpA8RjRp34MH/bUWZwC gXAIVGT23VUy5KAtzXwcyfPZv92aNX3FfxHmlUimNjCqbRzOlz8ibfg8w84sKU9dQaLR9gI17 2paFUVz0w+131YHkj5EjDFQ9mZ70PljXk66e3v7S2BiXhMn99ZPcFnWMkZCLtVc96zGcxIJRt OFwU7JCr53p5qsvoeZoyxJnY9f3S1FtjiC1Xr64BYb3t958xm9xE12+1XEG5BmuXTUTvuUCIn 4jj40BZQYCuA9f4tkNtl20HubQVpV14Y9PUOrjjNttQbbOwWuq7KwEMTPSvzG/hw+OOnLJoaT 4B6L0V4dO9C2rVjJzHUx5PnPdgraHSu/Ht1gKqMYZxyyJQgJftNsGQW4ZE+Lfc+4TyP0Y5Uh5 tbDSbjhpwoOGgvNy73Gzeif01lmhmlzEAGEgkbGa0dQHjdq1NtIeSmgjh9PjSp8Vq2sJUPcPN EBcdHeIrwYaG9/CHKkC6auLzS4RhfTvpEAm3fzPTyqIxjGtHMGn0Mc77Q/PzccjJaVYwoXKX2 BKqssMwTLeZXyBNaGMRPkKWwK4FvCZ6drwLmqIFHIG5yplua+Qx2VgMr7sc/+DD6FifsPs4xp 2R4dTUSNfTOka0oSGKU85I3k0Oq1EdIOr3NCjiX7JzQQ/G+HLfINCk2IPXJ7C40JrwMN+5K7q pNmbmG/18s7bKljzptadywf6Ptp7f9gngnNquh++1dFZDEWGMj0sfqdO5y9/xwCrqeeU7GOgm RcfFwEnabgBL/CG7PRoH7cD7N+cRpctyoJxrenrrk5BdnaR40JtpxafaOdXEHvr51E4ZrMBcb r/pp60Ky5L7Ftbb3CHnbOu88s8S91h6rCxMn22AABnyrataEug= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 14 Mar 2018 22:02:52 +0100 Move an assignment for a specific error code so that it is stored only once in this function implementation. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/media/i2c/ov5645.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/media/i2c/ov5645.c b/drivers/media/i2c/ov5645.c index d28845f7356f..374576380fd4 100644 --- a/drivers/media/i2c/ov5645.c +++ b/drivers/media/i2c/ov5645.c @@ -1284,13 +1284,11 @@ static int ov5645_probe(struct i2c_client *client, ret = ov5645_read_reg(ov5645, OV5645_CHIP_ID_HIGH, &chip_id_high); if (ret < 0 || chip_id_high != OV5645_CHIP_ID_HIGH_BYTE) { dev_err(dev, "could not read ID high\n"); - ret = -ENODEV; goto power_down; } ret = ov5645_read_reg(ov5645, OV5645_CHIP_ID_LOW, &chip_id_low); if (ret < 0 || chip_id_low != OV5645_CHIP_ID_LOW_BYTE) { dev_err(dev, "could not read ID low\n"); - ret = -ENODEV; goto power_down; } @@ -1300,7 +1298,6 @@ static int ov5645_probe(struct i2c_client *client, &ov5645->aec_pk_manual); if (ret < 0) { dev_err(dev, "could not read AEC/AGC mode\n"); - ret = -ENODEV; goto power_down; } @@ -1308,7 +1305,6 @@ static int ov5645_probe(struct i2c_client *client, &ov5645->timing_tc_reg20); if (ret < 0) { dev_err(dev, "could not read vflip value\n"); - ret = -ENODEV; goto power_down; } @@ -1316,7 +1312,6 @@ static int ov5645_probe(struct i2c_client *client, &ov5645->timing_tc_reg21); if (ret < 0) { dev_err(dev, "could not read hflip value\n"); - ret = -ENODEV; goto power_down; } @@ -1334,6 +1329,7 @@ static int ov5645_probe(struct i2c_client *client, power_down: ov5645_s_power(&ov5645->sd, false); + ret = -ENODEV; free_entity: media_entity_cleanup(&ov5645->sd.entity); free_ctrl: -- 2.16.2