Received: by 10.213.65.68 with SMTP id h4csp1276314imn; Wed, 14 Mar 2018 15:18:33 -0700 (PDT) X-Google-Smtp-Source: AG47ELvxqtjs6RXqtJbXmhExuQAb+B4U+xpIfssXJfQAURZUDwyR5MZjdJn6WlqTETj9kpf4y7Zp X-Received: by 10.101.97.139 with SMTP id c11mr5044683pgv.431.1521065913106; Wed, 14 Mar 2018 15:18:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521065913; cv=none; d=google.com; s=arc-20160816; b=UIVjfLwspyGUMQ53dN1ar66sOty3QJ7FTQkBf9k6v4qVC6+ylWvLLTiPlQ3FNx/hpB Iahy2S1YJtDnYWlSdNlRIO+/KevlqaUbsbtJ4jXHBPxAE9bEoccm//p0BNV8jW3Dn2Bp dEjkhBSNfxq36T8OQGa93bfg4PoB1jQtDENUVPvXXjlz11jDbeeFVHrAVPguQJGgavN4 Qj7jro0EtUQUabLCtlBF4i5uawiKLdQ0pzjvPYdBHSJMb2aajEkdDZ/efaUfmA+z6sOP 1HpxkNN6X+6VasOtg2p+JkR6HPhxpmyvNdnuDq7yppqVpFrQ4QNrZTa5GnQSzDcSCn/q 0WLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=bCRixF3xxW/mW22gtXjz14ZI6pxKQQ2lB1LVZCEdfYI=; b=Z5vX+7aTO+L9sHVQ93V/VrFsI9PteDBMJF7Lw0yGYo3AXSkFdGsGrj7GZpZo5SytCd U6O1wGC2+2y/+PgWJn2IIgteAga8pDJw/xaU3xddASVBe1i6949tJooxYPJXspG6LDu0 IWIizhlXU1WYe2s431u8m8z5mwNVx/q23WIOcvsUErrTaAujAEjQJtRC3vtgq4FOUJ3d tUBhQL/Sx12UKtD86e68jQ9b43ZiBP3kpFS5dDyO+3yM7cj3/v8QRTIzlbxdqPt7BV0G bpIrLYuIZpBWHM/aifO4tWRF4gRSDyweCpAt1x0dvSiCDzgXvDYaFeTHrZihmZS02rjc nQHg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l69si2757469pfk.180.2018.03.14.15.18.17; Wed, 14 Mar 2018 15:18:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751984AbeCNWRI (ORCPT + 99 others); Wed, 14 Mar 2018 18:17:08 -0400 Received: from mga09.intel.com ([134.134.136.24]:21565 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751452AbeCNWRH (ORCPT ); Wed, 14 Mar 2018 18:17:07 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Mar 2018 15:17:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,307,1517904000"; d="scan'208";a="38959661" Received: from jabhirax-mobl1.gar.corp.intel.com (HELO kekkonen.fi.intel.com) ([10.252.49.112]) by orsmga001.jf.intel.com with ESMTP; 14 Mar 2018 15:17:04 -0700 Received: by kekkonen.fi.intel.com (Postfix, from userid 1000) id 7F76D21DF3; Thu, 15 Mar 2018 00:17:03 +0200 (EET) Date: Thu, 15 Mar 2018 00:17:03 +0200 From: Sakari Ailus To: SF Markus Elfring Cc: linux-media@vger.kernel.org, Hans Verkuil , Mauro Carvalho Chehab , Todor Tomov , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH] [media] ov5645: Move an error code assignment in ov5645_probe() Message-ID: <20180314221702.5rtdttyqjcpysjkd@kekkonen.localdomain> References: <4efad917-ca08-f257-e9a1-b5bcb7df2df2@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4efad917-ca08-f257-e9a1-b5bcb7df2df2@users.sourceforge.net> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 14, 2018 at 10:15:43PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 14 Mar 2018 22:02:52 +0100 > > Move an assignment for a specific error code so that it is stored only once > in this function implementation. > > This issue was detected by using the Coccinelle software. How? > > Signed-off-by: Markus Elfring > --- > drivers/media/i2c/ov5645.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/media/i2c/ov5645.c b/drivers/media/i2c/ov5645.c > index d28845f7356f..374576380fd4 100644 > --- a/drivers/media/i2c/ov5645.c > +++ b/drivers/media/i2c/ov5645.c > @@ -1284,13 +1284,11 @@ static int ov5645_probe(struct i2c_client *client, > ret = ov5645_read_reg(ov5645, OV5645_CHIP_ID_HIGH, &chip_id_high); > if (ret < 0 || chip_id_high != OV5645_CHIP_ID_HIGH_BYTE) { > dev_err(dev, "could not read ID high\n"); > - ret = -ENODEV; > goto power_down; > } > ret = ov5645_read_reg(ov5645, OV5645_CHIP_ID_LOW, &chip_id_low); > if (ret < 0 || chip_id_low != OV5645_CHIP_ID_LOW_BYTE) { > dev_err(dev, "could not read ID low\n"); > - ret = -ENODEV; > goto power_down; > } > > @@ -1300,7 +1298,6 @@ static int ov5645_probe(struct i2c_client *client, > &ov5645->aec_pk_manual); > if (ret < 0) { > dev_err(dev, "could not read AEC/AGC mode\n"); > - ret = -ENODEV; > goto power_down; > } > > @@ -1308,7 +1305,6 @@ static int ov5645_probe(struct i2c_client *client, > &ov5645->timing_tc_reg20); > if (ret < 0) { > dev_err(dev, "could not read vflip value\n"); > - ret = -ENODEV; > goto power_down; > } > > @@ -1316,7 +1312,6 @@ static int ov5645_probe(struct i2c_client *client, > &ov5645->timing_tc_reg21); > if (ret < 0) { > dev_err(dev, "could not read hflip value\n"); > - ret = -ENODEV; > goto power_down; > } > > @@ -1334,6 +1329,7 @@ static int ov5645_probe(struct i2c_client *client, > > power_down: > ov5645_s_power(&ov5645->sd, false); > + ret = -ENODEV; I don't think this is where people would expect you to set the error code in general. It should rather take place before goto, not after it. That'd mean another variable, and I'm not convinced the result would improve the driver. > free_entity: > media_entity_cleanup(&ov5645->sd.entity); > free_ctrl: -- Regards, Sakari Ailus sakari.ailus@linux.intel.com