Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <CAGXu5jK4QdG83FGAx94GAmU=tpuhN1dypTh5n_Pes8n7shEZuw@mail.gmail.com>
References: <20180314214439.27806-1-djkurtz@chromium.org> <20180314214439.27806-4-djkurtz@chromium.org>
 <CAGXu5jK4QdG83FGAx94GAmU=tpuhN1dypTh5n_Pes8n7shEZuw@mail.gmail.com>
From:   Kees Cook <keescook@chromium.org>
Date:   Wed, 14 Mar 2018 16:00:38 -0700
Message-ID: <CAGXu5jJXNK3h5P-YzRJ3hxBer305ik4FHuhcixzprnRnefU7Qw@mail.gmail.com>
Subject: Re: [PATCH v2 3/3] serial: core: Allow skipping old serial port initialization
To:     Daniel Kurtz <djkurtz@chromium.org>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Aaron Durbin <adurbin@chromium.org>,
        LKML <linux-kernel@vger.kernel.org>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Len Brown <lenb@kernel.org>, Jiri Slaby <jslaby@suse.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Matthias Brugger <mbrugger@suse.com>,
        David Howells <dhowells@redhat.com>,
        Vignesh R <vigneshr@ti.com>, Sean Young <sean@mess.org>,
        Jeffy Chen <jeffy.chen@rock-chips.com>,
        Douglas Anderson <dianders@chromium.org>,
        Matt Redfearn <matt.redfearn@mips.com>,
        Marc Gonzalez <marc_gonzalez@sigmadesigns.com>,
        "open list:ACPI" <linux-acpi@vger.kernel.org>,
        "open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Mar 14, 2018 at 3:58 PM, Kees Cook <keescook@chromium.org> wrote:
> On Wed, Mar 14, 2018 at 2:44 PM, Daniel Kurtz <djkurtz@chromium.org> wrote:
> Sorry for being dense. What tree is this against? I can't find mention
> of amdcz in Linus's tree nor linux-next.

As I watched this email send, I noticed the "3/3" in the Subject. ;) I
see the amdcz support now. :P
https://patchwork.kernel.org/project/LKML/list/?submitter=18441

>> diff --git a/include/linux/serial_8250.h b/include/linux/serial_8250.h
>> index a27ef5f56431..02570edaddd8 100644
>> --- a/include/linux/serial_8250.h
>> +++ b/include/linux/serial_8250.h
>> @@ -136,6 +136,12 @@ struct uart_8250_port {
>>         struct uart_8250_em485 *em485;
>>  };
>>
>> +#ifdef CONFIG_SERIAL_8250
>> +extern bool serial8250_skip_old_ports;
>> +#else
>> +static const bool serial8250_skip_old_ports;
>> +#endif
>
> Where does serial8250_skip_old_ports get used where CONFIG_SERIAL_8250
> isn't defined? (i.e. why is the #ifdef needed here?)

This question still stands, though.

-Kees

-- 
Kees Cook
Pixel Security