Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9EA6C20779
Date:   Wed, 14 Mar 2018 19:42:37 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Petr Mladek <pmladek@suse.com>
Cc:     Arnd Bergmann <arnd@arndb.de>, Tejun Heo <tj@kernel.org>,
        Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
        Dave Young <dyoung@redhat.com>,
        Andi Kleen <ak@linux.intel.com>,
        Greentime Hu <green.hu@gmail.com>,
        Vincent Chen <deanbo422@gmail.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        adi-buildroot-devel@lists.sourceforge.net,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: Re: [PATCH] dump_stack: convert generic dump_stack into a weak
 symbol
Message-ID: <20180314194237.45e2709c@vmware.local.home>
In-Reply-To: <20180309095054.vrngc6fz7wo3hd4x@pathway.suse.cz>
References: <20180305053742.9149-1-sergey.senozhatsky@gmail.com>
        <CAK8P3a1aCQWwrJuCmx-nrMG58NQFCkCPRuAT5g43Lty13nE2dg@mail.gmail.com>
        <20180307022127.GB802@jagdpanzerIV>
        <CAK8P3a172j6r2HEwQ3cOOqXgXkFbxYifQ96VRFZ3+=wGawYNLQ@mail.gmail.com>
        <20180307104002.GA505@jagdpanzerIV>
        <CAK8P3a3eK4iS9rEWvoRfH75zjj7KHpsPnofoGdWH28Dqbz-UyQ@mail.gmail.com>
        <20180307114845.GA894@jagdpanzerIV>
        <20180309095054.vrngc6fz7wo3hd4x@pathway.suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 9 Mar 2018 10:50:55 +0100
Petr Mladek <pmladek@suse.com> wrote:

> On Wed 2018-03-07 20:48:56, Sergey Senozhatsky wrote:
> > On (03/07/18 11:57), Arnd Bergmann wrote:  
> > > Since lib/dump_stack.c is mandatory then, I would suggest making it
> > > obj-y and moving it out of lib/ into kernel/printk/.  
> > 
> > Totally agree on obj-y. And tend to agree on moving lib/dump_stack to
> > kernel/printk. lib/dump_stack depends on CONFIG_PRINTK and is partially
> > in printk.h. So it _mostly_ seems like the right place after all.  
> 
> I agree that we should define dump_stack.o as obj-y. Also it makes
> sense to move it to kernel/printk/. As Sergey said: it depends on
> CONFIG_PRINTK and is in printk.h.
> 
> Steven, do you agree or would you suggest another location?
> It was you who suggested to move the several functions from printk.c
> to dump_stack.c. IMHO, the motivation was to fix responsibilities
> (maintainer-ship) of this stuff. This will not really happen if
> we move the file to printk directory.
>

I still would like to keep it in lib. If blackfin is going to be nuked
in 4.17, and nds32 is the only one that is causing a issue. I would
highly recommend fixing nds32 and have Stephen stop building blackfin.

-- Steve