Received: by 10.213.65.68 with SMTP id h4csp1340475imn; Wed, 14 Mar 2018 18:00:22 -0700 (PDT) X-Google-Smtp-Source: AG47ELu+dZTyUSXlkEIFMDLkLuiAxhMhrvUtMq227Pt1hLuuxo2zma6kLGaSYAnA0Ey6y0mWGe5c X-Received: by 10.98.80.15 with SMTP id e15mr5929968pfb.90.1521075622534; Wed, 14 Mar 2018 18:00:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521075622; cv=none; d=google.com; s=arc-20160816; b=DJ8zVmqyjfTLetguC0o0FbGHIJDhoX5dpr2MTsg8y5JKzCnAaEJxDJ6UZR8G3Z5cu1 mzDp13jk7f6jWj96bBSfFWRQYH9IemAlidvR0pgT5bhpTHoyuIwPOl25TQoQn/D2Z93R heLzAO0aJnpXmITMxe7cPIerhJ+d0i44xhWwNBQoNYhNZVb3mHZp3lbYgjXsNEppq05b ZssV5CmMnEELZHo/L/zEFpAKx9lRxNvIekxvwGylp6EqPRFnychIx+WhixMxTMGRC/2k Y2FuTz934i5w9TOexq0A0JQJlyPhGakZFt2YwZPCEYwQmSi8Cl+a32XgHJjtCuK/uPXN sP5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=OKCeLaC5dB1CJjUzyeE60XnjlOIxBDwPRG2vg4oNCGA=; b=LZRvNO1DZeCfzXJgO9QQ1J2Wma5RF0Ub/o/nJoYAFdKT+nA/NphLjGq1uyHi22c23P lrfw+WI53bY4+5MQgk0Ugr/WujyzDaeql14hPmmJoNhPMV2YAkCFMqfCPlsuOkWg103T jOeD5EYAZSW4On9lzJ2sbpiUl4FMfq/UM7KWbJlNA3fPApu575rYXB1TqG+D6/FJgLi1 ejO8fmduuG+ZjqbAxFYN+C4RmqvI5t2YBUST5zwNgrs1Y5fkSCFMVngq1BYqoQWrRbM1 t5w7WdXLkA7rd+AW2eFUl85xHksgbrUnjSxyFfq9oyCbUkgbaNIuJtleCtqORXN1WHev +aGw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o14si2596649pgn.655.2018.03.14.18.00.07; Wed, 14 Mar 2018 18:00:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751624AbeCOA5O (ORCPT + 99 others); Wed, 14 Mar 2018 20:57:14 -0400 Received: from mail.skyhub.de ([5.9.137.197]:34844 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751405AbeCOA5N (ORCPT ); Wed, 14 Mar 2018 20:57:13 -0400 X-Virus-Scanned: Nedap ESD1 at mail.skyhub.de Received: from mail.skyhub.de ([127.0.0.1]) by localhost (blast.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 4puW_XYG2P4Z; Thu, 15 Mar 2018 01:56:56 +0100 (CET) Received: from pd.tnic (p200300EC2BC98E000DB0D181F40EDD09.dip0.t-ipconnect.de [IPv6:2003:ec:2bc9:8e00:db0:d181:f40e:dd09]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 79BA01EC05DE; Thu, 15 Mar 2018 01:56:56 +0100 (CET) Date: Thu, 15 Mar 2018 01:56:34 +0100 From: Borislav Petkov To: "Maciej S. Szmigiero" Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/9] x86/microcode/AMD: install_equiv_cpu_table() should not return (signed) int Message-ID: <20180315005634.GC11061@pd.tnic> References: <20180314175824.GG16605@pd.tnic> <20180314235812.GB11061@pd.tnic> <21fe4521-0fc7-c5ed-5a2a-4c7e93097385@maciej.szmigiero.name> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <21fe4521-0fc7-c5ed-5a2a-4c7e93097385@maciej.szmigiero.name> User-Agent: Mutt/1.9.3 (2018-01-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 15, 2018 at 01:13:07AM +0100, Maciej S. Szmigiero wrote: > This can be done if this function is modified to return only the CPU > equivalence table length (without the container header length), leaving > its single caller the job of adding the container header length to skip > to the fist patch section. Sure, it leaves the function to deal with the equiv table length only and the caller then adds the header length. Which is actually cleaner. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.