Received: by 10.213.65.68 with SMTP id h4csp1341615imn; Wed, 14 Mar 2018 18:02:43 -0700 (PDT) X-Google-Smtp-Source: AG47ELsdjVnVuBMxa6P3Ejn0eM2hXEWJL/SNEFr/XLHOMWVE4ihBmEVTi1CpXu3trjSZzqLyXVn7 X-Received: by 10.98.180.13 with SMTP id h13mr3910891pfn.139.1521075763465; Wed, 14 Mar 2018 18:02:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521075763; cv=none; d=google.com; s=arc-20160816; b=WYUxP0rn/juDTnpGMmAjkCt4jTbQJu2J4kmT3DT8s7egolp2BebAJXNiEPE8KoNYFp 2aCZSTqfIphhrioScXhxZxDUpE0Y3LvJbzuQQLNSjfcDBePKzEFX0GTuM+5FrU8hzA+f ULKmIsxv+hZB8hpw0jEdAxYktmnQNw9PqP47oIPlRyb/Mp7Z05lR6K+wI3WrVErgloIV CJtYbroqg4lcVAWplEPmdv2DBTAR2lry6q67hI5rgvJx/2XiRQSwnEQD5RC21aVpYQCP TbkMTVJF7390AHvAVGTd38+OybVDgRACQT6Dmcc/Gi2ep142XOwhPwQBGwEXPZ6m3ESm dV+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=Nz9kG9iK/5AJZhIu+X7WaTmz0ydvq2HrKJ35TkocGLQ=; b=qq6jUcO5DyYdS2h20a+buUeBC3B5UKAWfRk3Ce7uW1jJKmK5+DvamCzHiMWmWQXrHo FuopxxrZDBgUMYhCV++Q1/U4z6IjL+lAjgd7mxCr4kvgAFLN9Q9UF/lX6iCM1uQFknTY +okdnpt40TXeVuqL/v2LGUIpzSJDLY4OlKu0bTfJl9+1bVd4l5n9VZ/gcmHWH41z06Xx 5rjop761Uj3b1U36xlY4OD7QXvsIkZ2McmCEZoQnblph6rEzfSaCOs2hz4Kyd3p5k5Nj YMBM8KD6qH+qzRzvL7gnsR3M8TKtZio8h4JmugMnLVYRLyN3n1wmc/cqwtTe9aTlOctK TbAw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o14-v6si947532pll.405.2018.03.14.18.02.29; Wed, 14 Mar 2018 18:02:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751971AbeCOBBH (ORCPT + 99 others); Wed, 14 Mar 2018 21:01:07 -0400 Received: from mail.skyhub.de ([5.9.137.197]:35156 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751302AbeCOBBF (ORCPT ); Wed, 14 Mar 2018 21:01:05 -0400 X-Virus-Scanned: Nedap ESD1 at mail.skyhub.de Received: from mail.skyhub.de ([127.0.0.1]) by localhost (blast.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id SSvDT0Jnrbuw; Thu, 15 Mar 2018 02:00:49 +0100 (CET) Received: from pd.tnic (p200300EC2BC98E000DB0D181F40EDD09.dip0.t-ipconnect.de [IPv6:2003:ec:2bc9:8e00:db0:d181:f40e:dd09]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id EFB9E1EC05DE; Thu, 15 Mar 2018 02:00:48 +0100 (CET) Date: Thu, 15 Mar 2018 02:00:29 +0100 From: Borislav Petkov To: "Maciej S. Szmigiero" Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 4/9] x86/microcode/AMD: automatically compute the PATCH_MAX_SIZE macro Message-ID: <20180315010029.GD11061@pd.tnic> References: <20180314180209.GH16605@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.3 (2018-01-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 15, 2018 at 01:05:14AM +0100, Maciej S. Szmigiero wrote: > Unfortunately, this does not work: > > ./include/linux/kernel.h:806:41: error: braced-group within expression allowed only inside a function > > #define __max(t1, t2, max1, max2, x, y) ({ \ Ok, let's drop this line then. It is simply too much monkey business just to end up with max size of 4K which is F15H_MPB_MAX_SIZE, coincidentally. Just put a comment in verify_patch_size() stating that PATCH_MAX_SIZE needs to be adjusted when a bigger per-family patch size gets added. Thx. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.