Received: by 10.213.65.68 with SMTP id h4csp1400189imn; Wed, 14 Mar 2018 20:41:24 -0700 (PDT) X-Google-Smtp-Source: AG47ELvMYuA0WZQlG12K3o/dsJbOfJTS0B5TWbLGZdnaBxmtVjl/3SvgcxcNlXIUgwFJMYOWXGJM X-Received: by 2002:a17:902:7082:: with SMTP id z2-v6mr6281783plk.130.1521085284126; Wed, 14 Mar 2018 20:41:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521085284; cv=none; d=google.com; s=arc-20160816; b=xw3VB70Ys+loeZyh81Kbkm1zSxuVYqZhtGjyGuyDT/LhbHk4gmhTX+uGaRsU15Vb4v wUMdCGwCiuJnMSWcKTXDYxKwLksIR0ljeDOJQXq0xUffMr5SxZCsTl2Pxsl13edJp+zP 6Lt+LTJZGrnMHS9yN6rlFjsBEQNGMvuyZimnCI2ICPVofu0tr/NudC67x256b5R4Rt86 lrhcK1+BF8WouZYVVhiM28j7qYzDybDp1zcxSdWi6zRivXnloxuft+vqGBjswbxk/qbZ fgEWfNbLvlYpuIEDfi4dAiGAujie9lJYn/v/lM5wJXmXvo2O6z1CtXXC//Wfbd5xqwMf DVJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature:arc-authentication-results; bh=h64H91O8+kvzcqCYVyNfGIFWkvpFzWs3Ftong7SQsaM=; b=jCAMrKPeNI36jkzu3ZDHi4DcvGw2/2fEXoKMN/eCiYjsJ+TcaGqrsVWhZL1Lmb0NcE OYcUvi/sKEsC1KknHHugZf7HLhtox0VAUSm3+Vxint/f+qHEVVsvA39OsI/0rKh1eW7r I3pNI8xIVo1ozvO7HQpuTfURztWnhQBA0Rm6v5ZMnohXiXpGofOjs/tbtwNU/wXe5nei d/cZgIx88hcdEHfOaDgDGPKuwJ7urn6Am9mP18qawfmoqcquk35UKbBGIaxLG20N6sKJ uAH+qTqZgH0urII2eXH+SWlwIleslnjURVrNgoLg87YU9bCh/qiy3vFLFTNYVEEVnbql 1pbA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=e12108hy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m1si2828747pgq.399.2018.03.14.20.40.32; Wed, 14 Mar 2018 20:41:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=e12108hy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752146AbeCODhc (ORCPT + 99 others); Wed, 14 Mar 2018 23:37:32 -0400 Received: from aserp2130.oracle.com ([141.146.126.79]:33390 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751555AbeCODhb (ORCPT ); Wed, 14 Mar 2018 23:37:31 -0400 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w2F3bRoN078439; Thu, 15 Mar 2018 03:37:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2017-10-26; bh=h64H91O8+kvzcqCYVyNfGIFWkvpFzWs3Ftong7SQsaM=; b=e12108hybibFLXz0ws/VAlCM8eQTyMzS8IilGOXrXygss53eaMiqiajCRkKgR7RlpDvh cmnURCO+mWl6RlphY9pBOdV6zXrnH86f4Tou/kRUQYCoG/OJT9UI2yGbTs8YfBP/bWai Kto1kqUDwj9gclZ3yUKHYuQrGGAEaaKEMb2X0tzzBS8dy7fRptJJEPLVr40S7QL3UtQK DVIvcK8nXdPDWkmEIdBwiTLaF2dsK0qQKZT6IsKDqefWMcj2yNRyLsyS2X2WQPoYm6Pr PZRnb9GPql3wNJMZqO4z9DbDokzYPApWKwuR9vreIvFlmBqNkUpYWVb13wxTwrEWt3ia Vw== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp2130.oracle.com with ESMTP id 2gqghn92u5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 15 Mar 2018 03:37:27 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w2F3bPi9028672 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 15 Mar 2018 03:37:25 GMT Received: from abhmp0018.oracle.com (abhmp0018.oracle.com [141.146.116.24]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w2F3bODT018620; Thu, 15 Mar 2018 03:37:24 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 14 Mar 2018 20:37:23 -0700 To: Colin King Cc: James Smart , Dick Kennedy , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] scsi: lpfc: make several unions static, fix non-ANSI prototype From: "Martin K. Petersen" Organization: Oracle Corporation References: <20180313120849.30128-1-colin.king@canonical.com> Date: Wed, 14 Mar 2018 23:37:21 -0400 In-Reply-To: <20180313120849.30128-1-colin.king@canonical.com> (Colin King's message of "Tue, 13 Mar 2018 12:08:49 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8832 signatures=668690 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=672 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1803150041 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Colin, > There are several unions that are local to the source and do not need > to be in global scope, so make them static. Also add in a missing void > parameter to functions lpfc_nvme_cmd_template and > lpfc_nvmet_cmd_template to clean up non-ANSI warning. Applied to 4.17/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering