Received: by 10.213.65.68 with SMTP id h4csp1483481imn; Thu, 15 Mar 2018 00:24:46 -0700 (PDT) X-Google-Smtp-Source: AG47ELvNVVzUOpphWEzeb+rRPUIxYg/rTrhY4Uciclzl46sX6A0pqweKnArtjAFkSJYv4iakKUOw X-Received: by 2002:a17:902:c81:: with SMTP id 1-v6mr6892215plt.205.1521098686278; Thu, 15 Mar 2018 00:24:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521098686; cv=none; d=google.com; s=arc-20160816; b=02DcEehtowSlPkWKWhzxo6+N826pSroWgEcDwSG0conr3AgVjJnBMg7mT14kdbmScl lX27quvxlgKvzdS9QHLJ0s5rxC3DlhUHSMYgJ/aSsvp74TRJRlifHErcD0eUhtg/Hqhp fncGkGp8qyCgFsonOpeCnNikpTB+8oQLuAv5K1pmhObxwFDFNcUQhTKCnj3KOxaEw2Dq fsBbVhn7my3rvCK3cJken6zgTr9qVv7nZhRf321Rz/VywxA69+wXzrsyJTgIbO58ptwD O/CGehcG19Xa1Y9cKlIo3ZKlLEhGcFf6uGUuPWKmmP53hkIXB5Ze3Zt7KftIDewhvW2q +9vQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=Fj2zm6jcF2MhHSWXUIDagwDVZ70Xm0uR6an7wjghEUw=; b=gonPwcXUX35ugSNuOLSjhVsY/lTmgRMMGCaD+BarNg84V9O0cCYahDaw4gpvIooPj+ fVnw6eTThiT6IDMrDQjqNq4LdTUqBdcj+3vFGUmitGqfDKyqswByt1pa2e/qA/5lfnEk ss97w5lW89igEIF9yQRxKFWNvfD/EAyIsmrNIMpuDxEK3zquWifKUDV4P2wStk81o6GJ h2fxgn3y/oH0/+1WhkjyrNehpNRZ54diXwjS7EkzzQIv+6OM/EesSBCh55AceJzBu3JH LGgWiCjaIBz7oCL4atQ7I38SY67U0nznF60oVLHA4m3wr6PTZ32etus8+m9Jj3Fzti5A SyVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=N+jSKacU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v8-v6si3450193plk.659.2018.03.15.00.24.32; Thu, 15 Mar 2018 00:24:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=N+jSKacU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751758AbeCOHXH (ORCPT + 99 others); Thu, 15 Mar 2018 03:23:07 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:59528 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750950AbeCOHXF (ORCPT ); Thu, 15 Mar 2018 03:23:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Fj2zm6jcF2MhHSWXUIDagwDVZ70Xm0uR6an7wjghEUw=; b=N+jSKacUP56nFc0wapMDIP3Gc Wd1aOQS/LNc7ub79oTu7kNzBXL+8GhPvvWvL6HFE5zyynIPZOfAH4pFxLREOTd0qRhG/xezpsi8eV NuUhCu4PCdXLsKLGzdRtZ3YMYkJ7OhAsWsfGPEXiB6tFXyo1iEj6G5xQIRKVJzcSZ+Ib2Jefxi489 rHIVjzd16tsfPz9bGL7NI3mapLk0FGxJvbWJ6zwxD8yZkec3g1EBC0uet7ztcR1v8Cxee52bDqVvE kEjY+1mJ40W5BS9TMALjyj4gRbwYs4ixSd7fsfYsTl6zf/MOmv8LYCK83LNAWIbuMjzT/irtGwPAq VPv8WJb1w==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1ewNE2-0004DT-44; Thu, 15 Mar 2018 07:22:58 +0000 Date: Thu, 15 Mar 2018 00:22:57 -0700 From: Christoph Hellwig To: Johannes Thumshirn Cc: Dan Williams , Ross Zwisler , Linux Kernel Mailinglist , Linux NV-DIMM Mailing List Subject: Re: [PATCH 0/3] Introduce module_nd_driver Message-ID: <20180315072257.GA14576@infradead.org> References: <20180314182508.10351-1-jthumshirn@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180314182508.10351-1-jthumshirn@suse.de> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 14, 2018 at 07:25:05PM +0100, Johannes Thumshirn wrote: > Provide a module_nd_driver() wrapper and move over the appliccable > drivers nd_pmem.ko and dax_pmem.ko. What is the point? It saves a hand fulk of lines, while making the code both harder to read and harder to extend.