Received: by 10.213.65.68 with SMTP id h4csp1496219imn; Thu, 15 Mar 2018 00:56:56 -0700 (PDT) X-Google-Smtp-Source: AG47ELswG5eVRvb/ts6w4l2uFtFAmjbn3/XJVSFihCFhOSACIVoWRL2E0NmAsTq/aQJ9LChVTeEf X-Received: by 10.99.56.11 with SMTP id f11mr6088327pga.63.1521100616522; Thu, 15 Mar 2018 00:56:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521100616; cv=none; d=google.com; s=arc-20160816; b=EEjJ2/BM3J8T2OLy+ob7xOJM+aHCWy7Og5c6XK5ezHCl5FXmZQDveC2N2vmHfyDLLr LBqET2qTDn4tNlz8eCp1d8K8PN7r/fHhpZnJqq+3NHpBGyV8IY6KDd+B12f+poaJwJSA OomHuqMjsEYXassz0iZKfWr+EIsSp3Il/JPTJcGTsDPndNrr+9+OgaLEPZQlqUA4Q6f/ cEDFj6uO4GXFeIhrgzUkb7Mf1kDOZbtjyF82KQ2fX6m/gF8jE6joYU+07sd97e+94gx4 62/b7Ci+hJM0GEYuWGo2DJbDtY2SsEZII2+Qd8JsdKCeqmLXsmThUcddL0rWwLKhPtIW HMYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:message-id:references :in-reply-to:subject:cc:to:from:date:content-transfer-encoding :mime-version:dkim-signature:dkim-signature :arc-authentication-results; bh=auaqRHyW8V84yFlt+vQzPLXyUA/Ip5q4cOjSDhI+0rk=; b=dC0/aMO0R6ars7IzPeBBVrwSuyYEay94E3GM1FVVVWO9IByH642XbIjUgU0orC+Hw0 einNQYJTh9qkaQORUBjWJj4lZTyunip0R+4z7pMdFtYU43AdSxCZ9w7/WtPmPl2TBiyt AMmuWZmP6yReFHHlGNei2pXwf96edeqk66WfsW3ioLAbp9xeyLVgmxXb+Q17Gg6wQS+C ten2W/asUrWCZU34U5Vh0KHa+ggvjCjadpemvcqaF65rpCbshyqkUC95QpQb0aNZBONc 0ozkx1tsqDkM8vdyevzAeKBpAFMYaaE2waIQatYZ/isAxynIPKF+RfWi+xVq3fg72hZd n/gA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=bi8nh6+J; dkim=pass header.i=@codeaurora.org header.s=default header.b=lu/va+sn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 3-v6si3479342plc.700.2018.03.15.00.56.42; Thu, 15 Mar 2018 00:56:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=bi8nh6+J; dkim=pass header.i=@codeaurora.org header.s=default header.b=lu/va+sn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751770AbeCOHyG (ORCPT + 99 others); Thu, 15 Mar 2018 03:54:06 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:52142 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751512AbeCOHyE (ORCPT ); Thu, 15 Mar 2018 03:54:04 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 0877E60590; Thu, 15 Mar 2018 07:54:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521100444; bh=XuHHFPleHA18CzEdpU6HLjnrzV4oM0DciymWN2CiZRs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bi8nh6+JdQfHgnv2tzaKxT/kqgLdNtaZKtbFt5s6NUkSqwT5hZXwl9WQy0NxirYe7 xh+Qdd3KZuSluui8luXXh9vLUe4hPGaycJ0ECwns3ht9ZhdvgRG35x49Qj8Iw3JJ8R wxsoo+2ZZhgHWJIGEGbLt5F8y1S4tgLPEnEk9yUo= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.codeaurora.org (Postfix) with ESMTP id 27C2960452; Thu, 15 Mar 2018 07:54:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521100443; bh=XuHHFPleHA18CzEdpU6HLjnrzV4oM0DciymWN2CiZRs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lu/va+sna4tYPUDtAjEVB5VC9B9pZV9lb37wdv0fjuOrhopOyXxF2wgvHLiMQLc9X E2TOzcffhFxSHWkovVk7N1Iv/n4bxaXYsseOJX9LogXFnL4vK0xsqrOpB3cbQl5J9S iKdLkH6vFNjN4KNpfH6GHsjJudhL1bfpkmbSNw/E= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 15 Mar 2018 13:24:03 +0530 From: poza@codeaurora.org To: Keith Busch Cc: Bjorn Helgaas , Philippe Ombredanne , Thomas Gleixner , Greg Kroah-Hartman , Kate Stewart , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Dongdong Liu , Wei Zhang , Sinan Kaya , Timur Tabi Subject: Re: [PATCH v2] PCI/DPC: Fix PCI legacy interrupt acknowledgement In-Reply-To: <20180314205230.GF29867@localhost.localdomain> References: <1521042648-20522-1-git-send-email-poza@codeaurora.org> <20180314205230.GF29867@localhost.localdomain> Message-ID: X-Sender: poza@codeaurora.org User-Agent: Roundcube Webmail/1.2.5 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018-03-15 02:22, Keith Busch wrote: > On Wed, Mar 14, 2018 at 09:20:48PM +0530, Oza Pawandeep wrote: >> Current DPC driver acknowledges the interrupt in deferred work, which >> works >> since MSI are edge triggered. >> >> But when MSI is disabled (e.g. pci=nomsi boot option) port service >> driver falls back to PCI legacy INT interrupt. >> >> With current code we do not acknowledge the interrupt back in >> dpc_irq() >> and we get dpc interrupt storm. >> >> This patch acknowledges the interrupt in interrupt handler. >> >> Signed-off-by: Oza Pawandeep > > Thanks, this looks good to me. > > Reviewed-by: Keith Busch