Received: by 10.213.65.68 with SMTP id h4csp1506765imn; Thu, 15 Mar 2018 01:20:20 -0700 (PDT) X-Google-Smtp-Source: AG47ELtpKdjeRku9ajELVofbvvY3O7tWMboHN9q/kACploaDwIYPKzojEtfgRdxQVVIDWHt6t/f0 X-Received: by 10.99.104.73 with SMTP id d70mr6068516pgc.107.1521102020259; Thu, 15 Mar 2018 01:20:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521102020; cv=none; d=google.com; s=arc-20160816; b=yRl8TLIHBXBmrH3s9Lk1kB3pc3aWysWwqFr7NCSIETmwEv8Rwh/27NoyCwuK00eR7L 0nBiLs8GA/n1dBpZDDJx4rk+Ofwou9wpB+71wcjOjrlhftbpNNMNJdFlz6Tx6vI0pVds 3lrJHN0+fvrW4yg9oYyeR789BEElBkqamOZbrmYy1Y8jPQn5HqpK+oHl2K612mjAlV7A Rmss+LZ/yWdYQb0qmFUVcjvO5Zz3nZk+aILP7NrY/wKQLm5Koyvfb5MgwWuGR57M3FjD NpOtDWb3zeGESZWxsvMse0of3C2iLDjulAImbuO7rnN96tjQd8+CgxHDk25BcCYR/6NH Zkag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=lNakqhd7tDceqWPAX9MeYAGq70Xk9FHok2NJScs951Y=; b=xbSk1GAO4IqOnewtaQoxvfwLPvreruucFRGlWfrjknYjkc8uxFqZu1CyvUg3Q+QLBE e37wBWGL9i7eUhaj0+UUC9R2imKM26FEXJSOZTpVqNRJXhBVrDkbFHFxEdrosW84VAdR GePasrKmX7poyLVf171XRMigPRudiGG8g01KsOmpaQkwkuk5dWCzRlSWajXnFHIw20pr fC/k1uALpgU3GzBKtsOUCae8PFhdjUsYB9I/LEdM+Ia9WaruFqP93AfkoQgdt8YWvNZp /bMW/SZmTo2b6w87WgxOesM09kWSXAH1QtXow1fIei1nqvV7q5tkyL2kjKZmTxSjHLUk H0iQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=bUS2RO8y; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u23si3060132pgv.706.2018.03.15.01.20.05; Thu, 15 Mar 2018 01:20:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=bUS2RO8y; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751765AbeCOITC (ORCPT + 99 others); Thu, 15 Mar 2018 04:19:02 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:52534 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751618AbeCOIS6 (ORCPT ); Thu, 15 Mar 2018 04:18:58 -0400 Received: by mail-wm0-f68.google.com with SMTP id t3so8667787wmc.2 for ; Thu, 15 Mar 2018 01:18:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=lNakqhd7tDceqWPAX9MeYAGq70Xk9FHok2NJScs951Y=; b=bUS2RO8yWCE02jUXIsSP87xFcvdpy4xi5OpF6qss/RB9iNdkZ7Hct+cfHB6FNB7UW+ TJ1zxoHovOmbGYAup1VXFJenuLT8H8CroM68il3Jng5tZxRiarWSutlapPLFwnltA4A6 C+Hk3N0VZhJ03HWKDEcKMolxoAOU4Upit/d/U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=lNakqhd7tDceqWPAX9MeYAGq70Xk9FHok2NJScs951Y=; b=jj52ACHwUvnOqaBsYN/8ExtpxCWHvK6mdI1ywMQ2Aj1xhROi2NFkoB8mSAKfHLFqTo HXmXI9oB85oKf2WH4eF4moSK48cTAxvaIGBwCc1ep3K1E+GxL+4gr+UtSJhG8yPiaY3m rABla1rzOgLIaeEeI1wmDDDIMXzM+SwdT+45/aHx2kCGFTnMitlt12Loq405ndiFJzrO UV8C6n2l+Ko2S82cc/GSlLn/EEWYsfNBIkygWDknUgTUd0fMiNXRGQ4ma8zWNMmbP0Yo X9NN5RMbirxGD8yVxb+v3qruB67Ons5xl8EApj9nUtJsbD4YMdc9lT4ibux3LiFm8ho1 l6uQ== X-Gm-Message-State: AElRT7Hztoe9LbdPYaTN2A9Fdsl7fp83MdAwBzyU34RARLe5Ql/rIk08 c/bFryiReI7zKXOJVoJSbvENcg== X-Received: by 10.28.160.26 with SMTP id j26mr3657660wme.76.1521101937142; Thu, 15 Mar 2018 01:18:57 -0700 (PDT) Received: from dell ([2.27.167.102]) by smtp.gmail.com with ESMTPSA id o11sm3759398wrg.91.2018.03.15.01.18.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 15 Mar 2018 01:18:56 -0700 (PDT) Date: Thu, 15 Mar 2018 08:18:54 +0000 From: Lee Jones To: Felix Brack Cc: linux-fbdev@vger.kernel.org, daniel.thompson@linaro.org, jingoohan1@gmail.com, b.zolnierkie@samsung.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] backlight: otm3225a: add support for ORISE OTM3225A LCD SoC Message-ID: <20180315081854.lsp5gmvqkgrgniln@dell> References: <1514388007-2248-1-git-send-email-fb@ltec.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 14 Mar 2018, Felix Brack wrote: > On 27.12.2017 16:20, Felix Brack wrote: > > This patch adds a LCD driver supporting the OTM3225A LCD SoC > > from ORISE Technology. This device can drive TFT LC panels having a > > resolution of 240x320 pixels. After initializing the OTM3225A using > > it's SPI interface it switches to use 16-bib RGB as external > > display interface. > > > > Signed-off-by: Felix Brack > > > > Changes in v2: > > - use descriptive names for registers instead of hard coding them > > - remove unnecessary registers in initialization sequence > > - make use of resource-managed functions like devm_kzalloc() > > instead of kzalloc() which simplifies and shortens the code > > - replace mdelay() by msleep() > > - use module_spi_init() since we do not do anything special > > in init/exit > > - use dev_name() instead of hard coding driver name multiple times > > - use static storage class for structure otm3225a_ops > > - sort include files alphabetically > > - use standardized licensing header > > - modify Makefile respecting alphabetical sort order > > --- > > drivers/video/backlight/Kconfig | 7 ++ > > drivers/video/backlight/Makefile | 1 + > > drivers/video/backlight/otm3225a.c | 251 +++++++++++++++++++++++++++++++++++++ > > 3 files changed, 259 insertions(+) > > create mode 100644 drivers/video/backlight/otm3225a.c [...] > Just a gentle echo request: This patch was sent and Acked more then two > months ago. Is there anything preventing it from being queued for a > future kernel release? Please take care to snip unnecessarily long quotes when replying to patches. This patch still needs Daniel Thompson's Acked-by/Reviewed-by. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog