Received: by 10.213.65.68 with SMTP id h4csp1509824imn; Thu, 15 Mar 2018 01:28:12 -0700 (PDT) X-Google-Smtp-Source: AG47ELvVk2nX9Ht0eioePcY+klZS8bgez6e+CfTTx8LObYbBd5oyWeiWMnYTLlDVsh26IoTCw/f3 X-Received: by 2002:a17:902:b786:: with SMTP id e6-v6mr7332940pls.58.1521102492690; Thu, 15 Mar 2018 01:28:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521102492; cv=none; d=google.com; s=arc-20160816; b=bG52CJ7OV7m/hdXL5EzVyrzzTISxLk3b+JVzEqYXZaq5bdYNmlY5WzvYJZAJcWQscl AeZaNFkcbrZUrR3pAcghvYjXkc7s2hSoTgPk+7NIL8elz1lXQqjAz1DjMJZukPDFwFd2 MFCR3FTAGG3SasB4GJJJcJJa/8Am2TMlfoDjFiPGp79QVsKRpRXRYyifkMn4OMjUBKyK OhqDRNlYWnV2TqBx3x/r3awW8Ujlnh7anAgbC3D1hlH8WePqOcF9hmqmnaX4MVeVNm2v ys1G7zHfwr0qnisdYYZJhQ0DVt4HRb/rP3ne1wzi3sjY7aVH5kqp6VoTAsroERgpBNo+ Chyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=a+EYOstONGG1JwTy7h6FYW9W5rs0Hi02NPdV9r5SYiA=; b=yyurWUUZgfhiCtcw4KwVScgcsry0I9lO0NFniEDh+ToWFwGPu0Kc8rpPF23T4ndTkw uk8ydnjt6P/tMCkBn9DCaxZV0zl1rx6pQEhLLC4pawHBvSTtMjdWnbRcaUJP5NbGzEQo 4iXnjgyudQ55QCIf4KAJLo3krRJO2c41fKJO+/lCpsIF/slkVR0i1HeFY956u/DFc4AK 6Xh3u4pVbM19el70E72G3XnkRkvn5u36k8tzKNAi8LDWRFd3yd0h3Rbl4uXv61wNNCBa ZlFfbRRRxppLlEdhXolWLcQGyco22ZNy3qS1lgv4ZswaX/1xIBPTIRnNEn+4sIEJ8afX VDlg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m8-v6si1640467pli.462.2018.03.15.01.27.58; Thu, 15 Mar 2018 01:28:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751639AbeCOIZl (ORCPT + 99 others); Thu, 15 Mar 2018 04:25:41 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:43766 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750777AbeCOIZj (ORCPT ); Thu, 15 Mar 2018 04:25:39 -0400 Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w2F8Oo48078865 for ; Thu, 15 Mar 2018 04:25:39 -0400 Received: from e06smtp10.uk.ibm.com (e06smtp10.uk.ibm.com [195.75.94.106]) by mx0b-001b2d01.pphosted.com with ESMTP id 2gqm2a2xtm-1 (version=TLSv1.2 cipher=AES256-SHA256 bits=256 verify=NOT) for ; Thu, 15 Mar 2018 04:25:38 -0400 Received: from localhost by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 15 Mar 2018 08:25:37 -0000 Received: from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194) by e06smtp10.uk.ibm.com (192.168.101.140) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 15 Mar 2018 08:25:33 -0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w2F8PXWE852416; Thu, 15 Mar 2018 08:25:33 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id AB42E11C052; Thu, 15 Mar 2018 08:18:10 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0B9F111C058; Thu, 15 Mar 2018 08:18:09 +0000 (GMT) Received: from bangoria.in.ibm.com (unknown [9.124.31.132]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 15 Mar 2018 08:18:08 +0000 (GMT) From: Ravi Bangoria To: rostedt@goodmis.org, linux-kernel@vger.kernel.org, keescook@chromium.org Cc: wangnan0@huawei.com, mingo@redhat.com, srikar@linux.vnet.ibm.com, oleg@redhat.com, mhiramat@kernel.org, namhyung@kernel.org, Ravi Bangoria Subject: [PATCH v2 1/2] trace_uprobe: Use %lx to display offset Date: Thu, 15 Mar 2018 13:57:55 +0530 X-Mailer: git-send-email 2.14.3 X-TM-AS-GCONF: 00 x-cbid: 18031508-0040-0000-0000-00000420ED6F X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18031508-0041-0000-0000-00002623F545 Message-Id: <20180315082756.9050-1-ravi.bangoria@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-03-15_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1803150097 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org tu->offset is unsigned long, not a pointer, thus %lx should be used to print it, not the %px. Fixes: 0e4d819d0893 ("trace_uprobe: Display correct offset in uprobe_events") Suggested-by: Kees Cook Signed-off-by: Ravi Bangoria --- v2 changelog: - Keep prefixed 0s as is. kernel/trace/trace_uprobe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c index 2014f4351ae0..0298bd15be83 100644 --- a/kernel/trace/trace_uprobe.c +++ b/kernel/trace/trace_uprobe.c @@ -608,7 +608,7 @@ static int probes_seq_show(struct seq_file *m, void *v) /* Don't print "0x (null)" when offset is 0 */ if (tu->offset) { - seq_printf(m, "0x%px", (void *)tu->offset); + seq_printf(m, "0x%0*lx", (int)(sizeof(void *) * 2), tu->offset); } else { switch (sizeof(void *)) { case 4: -- 2.13.6