Received: by 10.213.65.68 with SMTP id h4csp1523050imn; Thu, 15 Mar 2018 01:59:24 -0700 (PDT) X-Google-Smtp-Source: AG47ELu68ZAoTmrnCis/nYtWFb8I2U1dLLyhQnD0W6YU1ZS8cp0ZEGzUW76kn2aVn0X1F/4fwp62 X-Received: by 2002:a17:902:d20a:: with SMTP id t10-v6mr7215625ply.123.1521104364808; Thu, 15 Mar 2018 01:59:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521104364; cv=none; d=google.com; s=arc-20160816; b=KgYt8GiSOtaR/da4P7TW82h++ZFtgZ47vhtCQp8Q5hnFkq78ULyTfw/V3JwI1y4DCV rAJPeX+kolqkndsqvEwikXuBksoWAMIdkbm6HZG8rbT33mY7VdyElC809Iys5rNobjzj ZBOS40vaQ/NxCXVLLnfBgxTCPiOcv0c+ycBOBqSfO287kbpoJh6k8UkMsc0b0f9vlmZy QpZD6vwdxWr3mKP+cIhB1xYXeUUWbN76sR7hc5bg3YlCLgNEb/Uyw6/dI4pQ+hqL8B+M 94Bjg2rXB5v3KO8vHBM4biISARRMPv2JIJ8rfWKJWZhOS+I/ahavRwnJBDJPLawyInnO qOyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=Xg6HoExFmv2W4hYrHFdHnq5oW3UUkYcVHv+WPE2h9Rk=; b=OeC5qj6lkEnktXdYfkX2xRxi68gyLN9deblKuJX4Bt3LoFsPdupM5zLvxKRuPUFHMx w0rtl9MoNxMzIRSvtQnQYKalkE35ywXTB0Two9ycz3T7c1bS+B6Dpgt1z6Js2z50LSiA ApmWG7trBRRS5BzhCmcCMXEK3Zj0YCLVPglGlOVMWB1IpSpqG9AM+8T7nzIqO3ZNEpEa z5cPUxRahaEcnlxlXrrmwFecRA8LvmnSCrePlK0T6lZLMHzBpur8mZ4xe3Z0DScSO2yA mL4rWCprtf+BtyHrBDp+jqN3t9FmAi2nn6LsU3P6XIPFVLeysIBljCZ8A2u1mV6SfUqT NIYQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cYSqnt1m; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c3-v6si3562487pld.466.2018.03.15.01.59.10; Thu, 15 Mar 2018 01:59:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cYSqnt1m; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751640AbeCOI6F (ORCPT + 99 others); Thu, 15 Mar 2018 04:58:05 -0400 Received: from mail-wr0-f195.google.com ([209.85.128.195]:40910 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751478AbeCOI6C (ORCPT ); Thu, 15 Mar 2018 04:58:02 -0400 Received: by mail-wr0-f195.google.com with SMTP id s12so4873496wre.7 for ; Thu, 15 Mar 2018 01:58:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Xg6HoExFmv2W4hYrHFdHnq5oW3UUkYcVHv+WPE2h9Rk=; b=cYSqnt1m+LiNG06gaBF8UTBfaKQJw9MSTao8dzZtZDzNSt1mWZrRhi31iLL7lEEfIN xx4ztg5RDg8519vTmcy5T5nK2giJXhiwLyngrOARRu8BygMFBfsd3+OLuLqv8/NxBakL V+KOoJ75sZrySGpH+3AHxoP0xAMcUcLavZDMU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Xg6HoExFmv2W4hYrHFdHnq5oW3UUkYcVHv+WPE2h9Rk=; b=bkQjbqAvnKEi2ju8dpEjzyiImVhzk/lFmcYIKaAsn/fMpe5IOn4Q3vM0k5ykUZ7GZ2 Pfw/4bKURvalpgzQvfPii70tDxJgbVjdOsWLOuBrlnsVX999mjJMxrAt3NNLgTwQtUOG eas3IQNEQ6csFL04i71HV5R0QkFEbRFx6I8MgePJpF19qCcvYu5+IMEyeYGiw5GRudXO 0RRDbPv5ghUxYNh8ju6j/f0YJ9J4Ggewk0RvouP7MOMu/Xd0o5b2u0IINFKzeRAH7Ja2 fdli68kPvRwOdcfH+nTMIq67mt1nIoorHX+WGe3W+Zkd8IizPyMeGdHOQi71oPzVN/2Z xRhw== X-Gm-Message-State: AElRT7G7VKZ66pm7FvMAocKPSkZ3wK9OA4MmSyjh2XNlwNMWuTI5mg0c yh/06g4O1lXhn6/BpBsbB2HV6A== X-Received: by 10.223.138.138 with SMTP id y10mr5860635wry.44.1521104281210; Thu, 15 Mar 2018 01:58:01 -0700 (PDT) Received: from [192.168.27.197] ([37.157.136.206]) by smtp.gmail.com with ESMTPSA id u127sm4563415wmd.30.2018.03.15.01.57.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Mar 2018 01:58:00 -0700 (PDT) Subject: Re: [PATCH] [media] ov5645: Move an error code assignment in ov5645_probe() To: Sakari Ailus , SF Markus Elfring Cc: linux-media@vger.kernel.org, Hans Verkuil , Mauro Carvalho Chehab , LKML , kernel-janitors@vger.kernel.org References: <4efad917-ca08-f257-e9a1-b5bcb7df2df2@users.sourceforge.net> <20180314221702.5rtdttyqjcpysjkd@kekkonen.localdomain> From: Todor Tomov Message-ID: <1da1eeff-b566-e7a4-c1ef-a90ff635c846@linaro.org> Date: Thu, 15 Mar 2018 10:57:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180314221702.5rtdttyqjcpysjkd@kekkonen.localdomain> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 15.03.2018 00:17, Sakari Ailus wrote: > On Wed, Mar 14, 2018 at 10:15:43PM +0100, SF Markus Elfring wrote: >> From: Markus Elfring >> Date: Wed, 14 Mar 2018 22:02:52 +0100 >> >> Move an assignment for a specific error code so that it is stored only once >> in this function implementation. >> >> This issue was detected by using the Coccinelle software. > > How? > >> >> Signed-off-by: Markus Elfring >> --- >> drivers/media/i2c/ov5645.c | 6 +----- >> 1 file changed, 1 insertion(+), 5 deletions(-) >> >> diff --git a/drivers/media/i2c/ov5645.c b/drivers/media/i2c/ov5645.c >> index d28845f7356f..374576380fd4 100644 >> --- a/drivers/media/i2c/ov5645.c >> +++ b/drivers/media/i2c/ov5645.c >> @@ -1284,13 +1284,11 @@ static int ov5645_probe(struct i2c_client *client, >> ret = ov5645_read_reg(ov5645, OV5645_CHIP_ID_HIGH, &chip_id_high); >> if (ret < 0 || chip_id_high != OV5645_CHIP_ID_HIGH_BYTE) { >> dev_err(dev, "could not read ID high\n"); >> - ret = -ENODEV; >> goto power_down; >> } >> ret = ov5645_read_reg(ov5645, OV5645_CHIP_ID_LOW, &chip_id_low); >> if (ret < 0 || chip_id_low != OV5645_CHIP_ID_LOW_BYTE) { >> dev_err(dev, "could not read ID low\n"); >> - ret = -ENODEV; >> goto power_down; >> } >> >> @@ -1300,7 +1298,6 @@ static int ov5645_probe(struct i2c_client *client, >> &ov5645->aec_pk_manual); >> if (ret < 0) { >> dev_err(dev, "could not read AEC/AGC mode\n"); >> - ret = -ENODEV; >> goto power_down; >> } >> >> @@ -1308,7 +1305,6 @@ static int ov5645_probe(struct i2c_client *client, >> &ov5645->timing_tc_reg20); >> if (ret < 0) { >> dev_err(dev, "could not read vflip value\n"); >> - ret = -ENODEV; >> goto power_down; >> } >> >> @@ -1316,7 +1312,6 @@ static int ov5645_probe(struct i2c_client *client, >> &ov5645->timing_tc_reg21); >> if (ret < 0) { >> dev_err(dev, "could not read hflip value\n"); >> - ret = -ENODEV; >> goto power_down; >> } >> >> @@ -1334,6 +1329,7 @@ static int ov5645_probe(struct i2c_client *client, >> >> power_down: >> ov5645_s_power(&ov5645->sd, false); >> + ret = -ENODEV; > > I don't think this is where people would expect you to set the error code > in general. It should rather take place before goto, not after it. That'd > mean another variable, and I'm not convinced the result would improve the > driver. I agree with Sakari. > >> free_entity: >> media_entity_cleanup(&ov5645->sd.entity); >> free_ctrl: > -- Best regards, Todor Tomov