Received: by 10.213.65.68 with SMTP id h4csp1539106imn; Thu, 15 Mar 2018 02:33:57 -0700 (PDT) X-Google-Smtp-Source: AG47ELujRkDvjcETpI0RS2BtgFRqHItgRDeIX/HT7Yrdm9wsBN397A0ck0qXXbAMcTRTyitb7j+9 X-Received: by 10.98.69.196 with SMTP id n65mr7193337pfi.29.1521106437376; Thu, 15 Mar 2018 02:33:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521106437; cv=none; d=google.com; s=arc-20160816; b=GZm9Mi7lYqb+bSRjpk6drsI387EmXmRtqns6ZdC4DiE3HzhnkyrRCDL4/QQT6bKn3j YeTUa9tNkV1zT0UmYyI23DUTiAkedzPd5ygPyjsi/3m4MNSaMRI5oYyz+qpsFwUWlqOF dezHjoQ/Li88/Ig7+kxSwU1CcdHZILB6GRra4cnWHum/yEpu1J78zs72th/9QZ+dlBYD rNCBRjYBJdOfv8CN+3zfXg6RcXx0Xef+OkEO3GVLv82CtoKaNPTlrhZ3ohFPKoPF5C7P xhHWcVu4LlqduJJ9WJd4HBiivJ+d4RmfxvQKVYnBbexfTaTAP6u+l9KYQKebhyLTMlVo YNHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:cc:references:to :subject:dkim-signature:arc-authentication-results; bh=pC1C55+tqSHU3Zv58a5kbGr2ukA4fkbokXDqkfOQ2fM=; b=sO3K3T0kqXnLyJiw9jKLYWUJXnJB20BF00GnG/u4w8RqytyaHopH+vcu0viAXcGWkQ VlW9Do+U1xqmcZw1V7XTHbdnO4//eHmqmuUrU5HVMX2U2xijCvULtXJjlu7NdOQmVMBu N7kC0zNmWpAG5ys4ov6XA4Su6IViiFC0i89fgVh5MicZzVRB9Bu0ztCjzheylPnL3HY8 nezZlsEaYyH05p3zkBNlHkGS1I2+G7SLDIEg0Ztd7ZHaSrWQUFCsm8E5276CF0cB+54n rDy5hF3BaTF423SPryfmJ+B7MTSbPcgSaVu9+iUqhsUU/dbZj3z+jnIYZ3zbhxT5wW27 8gMw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=N0ZAWri7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x3-v6si3790054plw.269.2018.03.15.02.33.41; Thu, 15 Mar 2018 02:33:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=N0ZAWri7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751943AbeCOJc6 (ORCPT + 99 others); Thu, 15 Mar 2018 05:32:58 -0400 Received: from mail-qt0-f193.google.com ([209.85.216.193]:33735 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751467AbeCOJcz (ORCPT ); Thu, 15 Mar 2018 05:32:55 -0400 Received: by mail-qt0-f193.google.com with SMTP id a23so6503112qtn.0 for ; Thu, 15 Mar 2018 02:32:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=pC1C55+tqSHU3Zv58a5kbGr2ukA4fkbokXDqkfOQ2fM=; b=N0ZAWri7xQEpi3VLbK373ljnvz/uYsNCmXRdV7XRnNk/V8iWax+DEtj4ytbcZr9S3b sVshCkNfjNavYa/irIHsqa8TlMijmqcdzdPEfRwW3pB5Aiz+hBGVvfvwpOk4ygVqjWlw VPh23fec/7hiIVlbcktsSJC8o13ebEl0Gzm20= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=pC1C55+tqSHU3Zv58a5kbGr2ukA4fkbokXDqkfOQ2fM=; b=pTP9AgbJsyxeu7FQjV8uMFxKD1Qzf9/2BwBE1ruMAiLAOEhNDnVKEJV/9b8jF43F92 9UVZXBosEx/IWSThJsQcnVr030we1QYUqdwk0ineALQUGeRsAw0qKp4kmUFkJh1YHo/j Idk6tD7O7YSOZP0w4fQIpqG63OUV+zVv7P3MkURyUWHRCsXCFNS+yaFlDM/cs00gojDA jQmNE4fBIuUNr+Rt4LPdJxDGoA3dlerE/D7yyv8xRDZateyIOTIheOmMuEVV0guHC2BO SI01qf2fgDx//myEkRhXNLtNK0R2aHxiRpmvtxRzBIAmijtOCgx1OWALx4GKtvPLFFFk rq7g== X-Gm-Message-State: AElRT7GSh5Xa330O9f4nt/Kcf47KzAqyNVq2cYk60TzwMdHtuVvh6vfR gL9xSTCxGRBbgPAWdILEHx5+1eQG X-Received: by 10.237.37.50 with SMTP id v47mr12078868qtc.66.1521106374878; Thu, 15 Mar 2018 02:32:54 -0700 (PDT) Received: from [10.176.68.125] ([192.19.248.250]) by smtp.gmail.com with ESMTPSA id x39sm3533785qtc.37.2018.03.15.02.32.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Mar 2018 02:32:54 -0700 (PDT) Subject: Re: [PATCH] drivers: base: add description for .coredump() callback To: Greg Kroah-Hartman References: <1518167637-1948-1-git-send-email-aspriel@gmail.com> <5AA8E61F.9090500@broadcom.com> Cc: LKML From: Arend van Spriel Message-ID: <5AAA3DC5.4070101@broadcom.com> Date: Thu, 15 Mar 2018 10:32:53 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <5AA8E61F.9090500@broadcom.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/14/2018 10:06 AM, Arend van Spriel wrote: > On 2/9/2018 10:13 AM, Arend van Spriel wrote: >> Commit 3c47d19ff4dc ("drivers: base: add coredump driver ops") added >> a new callback in struct device_driver, but not a kerneldoc description >> so here it is. > > Hi Greg, > > Revisiting the header file I notice this patch is not yet applied. I am > pretty sure I got an automated email from you regarding the merge > window, but nothing else so did this one slip the cracks? Hi Greg, As I am touching this in follow-up patch, can we just drop this one? I will be posting a couple of new patch assuming it is fine to drop this. Let me know how you want to handle this. Regards, Arend > Regards, > Arend > >> Fixes: 3c47d19ff4dc ("drivers: base: add coredump driver ops") >> Signed-off-by: Arend van Spriel >> --- >> include/linux/device.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/include/linux/device.h b/include/linux/device.h >> index b093405..0b32a42 100644 >> --- a/include/linux/device.h >> +++ b/include/linux/device.h >> @@ -256,6 +256,7 @@ enum probe_type { >> * automatically. >> * @pm: Power management operations of the device which matched >> * this driver. >> + * @coredump: Called through sysfs to initiate a device coredump. >> * @p: Driver core's private data, no one other than the driver >> * core can touch this. >> * >> >