Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Arend van Spriel <aspriel@gmail.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Brian Norris <briannorris@chromium.org>,
        Arend van Spriel <aspriel@gmail.com>
Subject: [PATCH for-4.16 3/3] drivers: base: remove check for callback in coredump_store()
Date:   Thu, 15 Mar 2018 10:55:25 +0100
Message-Id: <1521107725-25027-4-git-send-email-aspriel@gmail.com>
In-Reply-To: <1521107725-25027-1-git-send-email-aspriel@gmail.com>
References: <1521107725-25027-1-git-send-email-aspriel@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

The check for the .coredump() callback in coredump_store() is
redundant. It is already assured the device driver implements
the callback upon creating the coredump sysfs entry.

Signed-off-by: Arend van Spriel <aspriel@gmail.com>
---
 drivers/base/dd.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/base/dd.c b/drivers/base/dd.c
index de6fd09..c9f5408 100644
--- a/drivers/base/dd.c
+++ b/drivers/base/dd.c
@@ -292,8 +292,7 @@ static ssize_t coredump_store(struct device *dev, struct device_attribute *attr,
 			    const char *buf, size_t count)
 {
 	device_lock(dev);
-	if (dev->driver->coredump)
-		dev->driver->coredump(dev);
+	dev->driver->coredump(dev);
 	device_unlock(dev);

 	return count;
--
1.9.1