Received: by 10.213.65.68 with SMTP id h4csp1565233imn; Thu, 15 Mar 2018 03:28:25 -0700 (PDT) X-Google-Smtp-Source: AG47ELuniP+VKOPo7rGUrGlBGSodbFL18GT7ZcJBKN/wshyGGTYQEoMjQdfZeoKfwQ5ixAi7blj+ X-Received: by 2002:a17:902:309:: with SMTP id 9-v6mr7664624pld.63.1521109705063; Thu, 15 Mar 2018 03:28:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521109705; cv=none; d=google.com; s=arc-20160816; b=EFK/qurKfrhcvXI/+riEEFmXyrXTaqIdCt/LlR1EdfOdfuyIs94x9+bnBnvBKfrT1X FtTL1d+Inok6zJT5sSJx+ZexU9UBr3AusqKPC2vExK1ou3rXDZezxE1LsLGLywIRKs55 voHVdKr0jnTpcOGbAvuR0V/tXDG8LDvQU4La4o886PQyTYVljVvtVjhHlofA6kBzvVI/ ODgw2mRH0W7zGqMi42V4OfLbu6CTHMHnN4YASszIHY8LVNVOFdpdq0b8PKNC5EqRfvhO OsmH+HiXSVHkM6sgpb/i0xZYBl9ppeymRPsGZKFfP4nczWlXdzG04UHoQ/yrNkCCJcpF r+8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=o1Dti61GKGQWhYsWGF4Jcrdb7phpxI1kP64l1rsHOyw=; b=wW0D7rIcu2RZbEzWhpFJZmv1nIZ16hwuF7zBfnfJKIaQWgpjWRWFF1xsSoau0b3QlW b+HtVWGE2HntII/nKbD0EAM74M7dPj0gXK6sOLE5BKoFvNnVSfdahnAtHR0l9VPjZx5b 5Z7B8iNTjckVRgRp1YbrMxw4KISzYYBbmQeo9TmtuTx7RiLMG+yYukeQDhdNe4KzqMHK fI3fPL0Eqw6swy1LbR5OQuUS0xBy+wLUwiGBnb+ozGwmYFievY03wSl5XD2HhHyPBzVP TkcKFE8r44udBh5l9sOXlePTulcCmX2rJaXSdrt/CmETfOy0RyvwFVDbPUP4AethtHoV fB0w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=qGvBSeDv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a13si3262876pgd.36.2018.03.15.03.28.10; Thu, 15 Mar 2018 03:28:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=qGvBSeDv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751854AbeCOK1F (ORCPT + 99 others); Thu, 15 Mar 2018 06:27:05 -0400 Received: from mail-wr0-f196.google.com ([209.85.128.196]:41392 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751467AbeCOK1D (ORCPT ); Thu, 15 Mar 2018 06:27:03 -0400 Received: by mail-wr0-f196.google.com with SMTP id f14so7664569wre.8; Thu, 15 Mar 2018 03:27:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=o1Dti61GKGQWhYsWGF4Jcrdb7phpxI1kP64l1rsHOyw=; b=qGvBSeDvMsXFxqK/eY3njodG1qEu/v2IiQn20LAjxIN6NUZVgyQuYiIfZCqnY7IT9z 0br+e28UP3Dq5J9fmMkI7Ldlykv/OPkjnWiJns74wHuis2y7pr4G6ce3dBBzLgbM3GQp hQPdw/bEmISlxUrf9AGItuTddVO+E4TnqjytmGbzG/mRZtlffId7JtDEfANM5yslVhB+ XH+G36+kgCjRU5lNyeAeu7ElErcAiOEPdlOPkxPP/BfQ6W7XVExVVoLxbUPrChA96Rii UCEf2w9T4EI9zwc1EpbquBSXLMYpYjNsbAwNk2WDo36s4sqgyt01U4K4ZGYWcHVbH7Fw 0IcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=o1Dti61GKGQWhYsWGF4Jcrdb7phpxI1kP64l1rsHOyw=; b=lpVIazUBFxeazznXtko2i4kVQl64AoG/vBnWRAsqsbWT04rgLr692bHNyUedlvdm31 whf5d0MIj4bxWO/ibps2Y1KyJqZE1wAJMia2j08XhMCpjUKXknrXkmtdBj8Z4rwkQ9Y2 ERFuE8bSB8LUVsBytR4WLVkSDfCTwa2nPn6clLzqnv47+ZwBYFNG9hsqEz9vZf8tZL9j mSvU6pjV5HzocAF5QQEk60HSo893aeX9q1DrgCByELYjLqIbmgshgvkcpTYZkmFd2Qcu o5tHIOYUzGgVGC5KgPa8mAKhSWY1TkYFl8+uZaXbnYnPZ2tvVc9bJjr4Qwh6Ai669MO9 /s6A== X-Gm-Message-State: AElRT7EB1QaKmxx/hv9NW024m3akfgXbmMSAQ/3y0PYz8sk3voTTeMks 82pfW4S9cJ1yLh80lWdiTFhxsg== X-Received: by 10.223.150.161 with SMTP id u30mr1754902wrb.151.1521109622329; Thu, 15 Mar 2018 03:27:02 -0700 (PDT) Received: from localhost (p200300E41F1A6C00A7FFE15449086C5C.dip0.t-ipconnect.de. [2003:e4:1f1a:6c00:a7ff:e154:4908:6c5c]) by smtp.gmail.com with ESMTPSA id x17sm5634867wrg.32.2018.03.15.03.27.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 15 Mar 2018 03:27:01 -0700 (PDT) Date: Thu, 15 Mar 2018 11:27:00 +0100 From: Thierry Reding To: Dmitry Osipenko Cc: dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/3] drm/tegra: plane: Fix RGB565 plane format on older Tegra's Message-ID: <20180315102700.GA15393@ulmo> References: <8d9c7220b1d2cf126bd2030e5d232ec06f761440.1521075485.git.digetx@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="T4sUOijqQbZv57TR" Content-Disposition: inline In-Reply-To: <8d9c7220b1d2cf126bd2030e5d232ec06f761440.1521075485.git.digetx@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --T4sUOijqQbZv57TR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 15, 2018 at 04:00:23AM +0300, Dmitry Osipenko wrote: > Simplify opaque format adjustment by removing format checking. There are > only 4 formats that require the adjustment and so this way is less error > prone, avoiding mishandling native formats, like in this case RGB565 is > the format that was erroneously treated as invalid. >=20 > Fixes: ebae8d07435a ("drm/tegra: dc: Implement legacy blending") > Signed-off-by: Dmitry Osipenko > --- > drivers/gpu/drm/tegra/dc.c | 11 ++--------- > drivers/gpu/drm/tegra/plane.c | 21 ++++++--------------- > drivers/gpu/drm/tegra/plane.h | 2 +- > 3 files changed, 9 insertions(+), 25 deletions(-) I've applied a slightly different version of this which doesn't rework as much of the surrounding code and is therefore easier to backport to v4.16. Thierry --T4sUOijqQbZv57TR Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAlqqSnEACgkQ3SOs138+ s6GLWBAAjVnw0dbXXghy0m5xpXQi+uwcqhbDv/imL5un0qIt3ZxcbdRM1WoGZwSF 090XlZi0/sQwCOR5TFZUPfbWOXqKI3YghMp5jcxuoRGbi51yzDS8US2VnA2A6gFb VsPn7pgPgOyMibjVvQ+zLhK6XBQwW2I/ThEBuzqCLFSruDiGdPblC9JbtRKLRVkA 1Mb0faLhNZ1LlL/6H/YJ5YnaQ/JekVRbbSOOVCMyCXmUvpVvUTzJbQ5viNwJGp22 kO5YLa/WFwijndX7uUdVb77tO+g9WQ0N5Vnd000df/S+nsBV19SJunP2mgwpORf5 jwB707wqYwn+wJ16FsI22fLNcWLwTWgchP8fYkOr9YxRM9KEzRtz8pxJ/XqWG47b SZ+Mif5cIXAvQ+kbTrKYuEUvmFrJLCZmanDw5zujnLVMl5fB+XMuDN3NRtSvOFED FHiE54RlwwqkEY7mimYmf6FJbVnV5/qry0TaEAkGJPlYglihGWbRYx/8iXGlbM1x AUvFSuWzr+Xlaruzf91RKvCQ6Bss5Yc6NKwoir+Gs0JZNbTM9OPMil9X1Wu8Bz5h Mrg5fwSx/uw3KSX2vqFjQmDexSL9H5pt0ThIi9FauQmAtxQhg+gmVIS3JvkwRSMg 38TnqJtPtREAjlgUAIA74b6fq7IDcWHdLr/4OOTm9cBVwrVb2cc= =rz7o -----END PGP SIGNATURE----- --T4sUOijqQbZv57TR--