Received: by 10.213.65.68 with SMTP id h4csp1569828imn; Thu, 15 Mar 2018 03:37:13 -0700 (PDT) X-Google-Smtp-Source: AG47ELt1fs6EVucFnRkOBli2Ms5c9T6RFlI9Lon0/y3Pb1P+m9UcC8F/Eiaw9Qv2WTRBNVZ8GFhX X-Received: by 2002:a17:902:8f8e:: with SMTP id z14-v6mr7454971plo.271.1521110233908; Thu, 15 Mar 2018 03:37:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521110233; cv=none; d=google.com; s=arc-20160816; b=j+GTwLDy2V6hV1YLOtxCt6lrx6cGCR/nEmenOYY2bDZRIqWsKY6vXzBJIA0y3NsIPu Gles/ai1Bi71xXQuvGtaXcHYGEs5mL4CRPCBh1eTgXczX+TgiDHAEUurGWfcOhu7otNs KuT1XIJVKz+j5UIGQKCc3UR3lpU2/DON4INQ98gErvjXCaSV769VH+aCgJfOlipqn5oV TE+tfy6a3f9ZOCOqt+LOkfODl38GkIVJmMRvObOHCbu8gVe/G0szWO9KSSpEok+wT6rV DAbLZTbsr3ybfLFKTiML6xPsEJOTKi6lxqnBOrQ1HZIZ918WQZFXVdEEmgmyNATL1fwb O7vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:arc-authentication-results; bh=RVCwQvSf3PUOJ5ZEMPuaQC0EZUKkFq6FCW9LUHGEaKI=; b=AlkGHcfjXvz9yWKNdHgxbHn5LKEl4wvBA1FUlvBwNF9LEDpc3qP8Rh40DJOriiw65E 95PiR5rs9CZVk3zb4WvcvBZJ3knF249Wh5ZTcLCbpCbhcn4R5aawtcSu2PTON63gPvLO m+lNYoLCWXptzh/OrK+PVg9/VjuYUOQoesV08Uo+kWlO9KffrDRIM948/aX2P8nyMluJ fUppkN8BgJc8UsbetLL3Z3eyyEywVBLLsTYhRmTNNa9ruXAWSoomszzLehKS7fg8HgKG /DyB1xkLIyOXR0tb2fUovW55+4zm0g0eEvltah/p0ymdzxxJORrnt1yxBH+gVY3RSmp/ JOBg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 92-v6si3766813pli.455.2018.03.15.03.36.59; Thu, 15 Mar 2018 03:37:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751826AbeCOKf6 (ORCPT + 99 others); Thu, 15 Mar 2018 06:35:58 -0400 Received: from mx2.suse.de ([195.135.220.15]:54399 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751470AbeCOKf4 (ORCPT ); Thu, 15 Mar 2018 06:35:56 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id BA13DACC0; Thu, 15 Mar 2018 10:35:54 +0000 (UTC) Subject: Re: [PATCH v2 2/3] xen: xenbus: Catch closing of non existent transactions To: Simon Gaiser , xen-devel@lists.xenproject.org Cc: Boris Ostrovsky , linux-kernel@vger.kernel.org References: <20180315024322.27429-1-simon@invisiblethingslab.com> <20180315024322.27429-2-simon@invisiblethingslab.com> From: Juergen Gross Message-ID: <993d84d7-c901-6365-0392-600e320a1d24@suse.com> Date: Thu, 15 Mar 2018 11:34:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180315024322.27429-2-simon@invisiblethingslab.com> Content-Type: text/plain; charset=utf-8 Content-Language: de-DE Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/03/18 03:43, Simon Gaiser wrote: > Users of the xenbus functions should never close a non existent > transaction (for example by trying to closing the same transaction > twice) but better catch it in xs_request_exit() than to corrupt the > reference counter. > > Signed-off-by: Simon Gaiser Reviewed-by: Juergen Gross Juergen