Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (1.0)
Subject: Re: [PATCH] scsi: iscsi_tcp: set BDI_CAP_STABLE_WRITES when data digest enabled
From:   Lee Duncan <leeman.duncan@gmail.com>
In-Reply-To: <yq137129dvi.fsf@oracle.com>
Date:   Thu, 15 Mar 2018 04:37:24 -0600
Cc:     lduncan@suse.com, cleech@redhat.com,
        Jianchao Wang <jianchao.w.wang@oracle.com>,
        jejb@linux.vnet.ibm.com, martin.petersen@oracle.com,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <8FA9AB3F-DFD0-4DB9-B1F3-0C1049E4A2E5@gmail.com>
References: <1520425743-1923-1-git-send-email-jianchao.w.wang@oracle.com> <yq137129dvi.fsf@oracle.com>
To:     open-iscsi@googlegroups.com
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

I reviewed this several days before but mistakenly replied only to the open-=
iscsi list.=20

Signed-off-by: Lee Duncan <lduncan@suse.com>

--
Lee-Man Duncan
Sent from my iPhone, dude


> On Mar 14, 2018, at 10:11 PM, Martin K. Petersen <martin.petersen@oracle.c=
om> wrote:
>=20
>=20
>> iscsi tcp will first send out data, then calculate and send data
>> digest. If we don't have BDI_CAP_STABLE_WRITES, the page cache will
>> be written in spite of the on going writeback. Consequently, wrong
>> digest will be got and sent to target.
>>=20
>> To fix this, set BDI_CAP_STABLE_WRITES when data digest is enabled
>> in iscsi_tcp .slave_configure callback.
>=20
> Lee, Chris: Please review!
>=20
> --=20
> Martin K. Petersen    Oracle Linux Engineering
>=20
> --=20
> You received this message because you are subscribed to a topic in the Goo=
gle Groups "open-iscsi" group.
> To unsubscribe from this topic, visit https://groups.google.com/d/topic/op=
en-iscsi/owLIZAXfgoA/unsubscribe.
> To unsubscribe from this group and all its topics, send an email to open-i=
scsi+unsubscribe@googlegroups.com.
> To post to this group, send email to open-iscsi@googlegroups.com.
> Visit this group at https://groups.google.com/group/open-iscsi.
> For more options, visit https://groups.google.com/d/optout.