Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   NeilBrown <neil@brown.name>
To:     Dan Carpenter <dan.carpenter@oracle.com>
Date:   Thu, 15 Mar 2018 22:04:33 +1100
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        devel@driverdev.osuosl.org, lkml <linux-kernel@vger.kernel.org>,
        John Crispin <john@phrozen.org>
Subject: Re: [PATCH 00/13] staging: add drivers to support Mediatek mt7621 in gnubee-pc1
In-Reply-To: <20180315104853.bthffdd4hzklzo6d@mwanda>
References: <152105892255.22262.1902152685410223215.stgit@noble> <20180315104853.bthffdd4hzklzo6d@mwanda>
Message-ID: <87vadxbnwe.fsf@notabene.neil.brown.name>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha256; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--=-=-=
Content-Type: text/plain

On Thu, Mar 15 2018, Dan Carpenter wrote:

> This all seems fine.  Generally the requirements for staging are that it
> has a TODO, someone to work on it, and it doesn't break the build.  But
> some of the patches don't have commit message and those are required and
> some of the commit messages are just the changes you have made not don't
> describe the actual code...

Thanks for having a look.
It seems odd to require detailed commit messages, when we don't require
the same level of quality in the code.
Naturally when the driver is moved out of staging a properly detailed
commit message should be added, but is that needed on the way in to
staging?  At this stage I don't know much more than is already there.
After I've cleaned up the code I probably will.

For patch 01/13 you asked "what kind of device this is".  The subject
line makes it clear that it is a "pcie driver".  What extra detail did
you want?  Would it be sufficient to just copy the subject line so that
it appears twice in the commit message?

>
> John Crispin's email is john@phrozen.org.

Thanks.

NeilBrown

>
> regards,
> dan carpenter

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEG8Yp69OQ2HB7X0l6Oeye3VZigbkFAlqqU0EACgkQOeye3VZi
gbkCPA//XzehKADE/hYzhmcQ9/QaJIPOoNG0IkbWtF7GQ7j4KM+2/l2Z+s2Du87j
zfHhE2sxTU+5M+QZXiKIy3Q60lIdh2w9S5w7gr2HN8YPVh2V5H1kBfuMyelul28H
JBe87OCbxBXaEtLav7N8mXHC8I4bh/l4bCqDvwqesY1VH8OUJkYNa+DCpnUSkEJm
gl40vkw7Q1Mi2+pkxaQ/+Nz8QfHUbhnqN5ZcmWXJvGwpGRWXxbURqlT8Aj1csNxv
KukABeUrrhZbl6m5gyI5eiRkWvaA1KiLdKjPlhtg9LNrPgK2sJToWIQK7BIVONKY
lAIWjaKJaFmBNmZTDVHlTywOIfdn3yu5PtM+27D4aCcM5xsfenyuv6L0l/JBosFY
qPRJovbfqJ+s3ujiBdbxK3+6qVkCYC2yiitAIUXoWoxZ9RBvT24FfSH71VoeoGPx
fUOpyOdaRFH8n/KyhiaIn/qj6GaNohtWX8XzwOHv8cPifQlPrzuARt4Cqyjk4Mh+
bpC7qstvLqAbvDk1TUifgJ83Bs4C7NiqOZty+/a2kQBv7nzJSKpTGuCU7kSrHc0E
2+c3PK1HF6adq66ZvB8CeJ0AIVIPxB2sD4Y5NqZPMFdqLAH8RX7Zec3gEMc8Z9bZ
kfRI/mDvNGCa46ZBFwqDkVhoToZqdgudJxI6b3PaYHms1SVwYts=
=o9ME
-----END PGP SIGNATURE-----
--=-=-=--