Received: by 10.213.65.68 with SMTP id h4csp1585713imn; Thu, 15 Mar 2018 04:08:59 -0700 (PDT) X-Google-Smtp-Source: AG47ELts/Z8FTDySSEx6DIdT7m0nEbB0Nm++B+/uaOeXBEs47pLj9OGZqLG12ltQAXYeaGAvzhhP X-Received: by 10.98.141.205 with SMTP id p74mr7364372pfk.211.1521112139100; Thu, 15 Mar 2018 04:08:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521112139; cv=none; d=google.com; s=arc-20160816; b=CQceVYsQf5oA6BMWV7m8+yZcBS4e/JGURwVA2Xl6ic5lMZsrLqAzl9Ekzxjfrf84/v cFdSeSQA1J2NdkniLSFmSKXCV/oEYYK3/fCgB/XiLczu0fwd3UPwwvVBaWxa099zeJ2R xIZMaI7vIrCUBNnUBXQ2pRudKdoZmRgTjCh+eIA8g2MLIk74smT6NOlvbygoQpqhNeNP ySXzWxucpQYfRZmsdo7H4D2JpENhCbYrb75zjUGPl4LQoAEgHiUKMM5QMKsdTQ8DP39F bs8HNaQx6rAZHkMownbYDh9g+IU1KgyFeN/4nj5pG7Zp4Dcp1T5loF+p44Dkq3pFOA9A 0uqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:arc-authentication-results; bh=j7mnWp3OK2XlkNQFl2/2WcaSwAGSAIkCslGhSQLV7T8=; b=DiekwLa8OYPQ6/cAO1GV9NOhYBFxXJ6yQbm34nLOxE5KHqlMW3eWLuP895pDrb/nDz vC3QiV5ddXFMzWKFh7A7n6uwpko2+c/alBj+z0EN4meeFDiS4moglKW5trm9GtG+kTeZ sFdCebMteQ+VzKWy3zfnLv8J7P1O2WDeI26ocNRRCSq8in6hkqUYh9/LER+2vuAJ9b6h Z56oRnKqWxad/ceydMoHCbZB+8HE8+xDS/zOIogJiZuhpixy6/WIEm2UHW30jEAfp4l+ vout0Jrd6bAcmN7t2IpzGOmjyKRYNKaiLaMD+dNZQbn+m/hUUnpATa1doFpyK9/eeBSd OSew== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y16-v6si1820975plr.174.2018.03.15.04.08.45; Thu, 15 Mar 2018 04:08:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752117AbeCOLHa (ORCPT + 99 others); Thu, 15 Mar 2018 07:07:30 -0400 Received: from nbd.name ([46.4.11.11]:51708 "EHLO nbd.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751638AbeCOLH3 (ORCPT ); Thu, 15 Mar 2018 07:07:29 -0400 Subject: Re: [PATCH 00/13] staging: add drivers to support Mediatek mt7621 in gnubee-pc1 To: NeilBrown Cc: Dan Carpenter , Greg Kroah-Hartman , devel@driverdev.osuosl.org, lkml References: <152105892255.22262.1902152685410223215.stgit@noble> <20180315104853.bthffdd4hzklzo6d@mwanda> From: John Crispin Message-ID: Date: Thu, 15 Mar 2018 12:07:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180315104853.bthffdd4hzklzo6d@mwanda> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/03/18 11:48, Dan Carpenter wrote: > This all seems fine. Generally the requirements for staging are that it > has a TODO, someone to work on it, and it doesn't break the build. But > some of the patches don't have commit message and those are required and > some of the commit messages are just the changes you have made not don't > describe the actual code... > > John Crispin's email is john@phrozen.org. > > regards, > dan carpenter > Hi All, looks like i was CC'ed on the openwrt addr, which no longer exists. This series makes no sense. None of the stuff posted is anywhere near ready to be upstreamed. * we dont need a dedicated pinctrl driver, pinctrl-single will work fine on these SoCs * the DMA/sdhci driver is a hacked up version of the SDK driver. * drivers/net/ethernet/mediatek/* works on mt7623 and is easily portable to mt7621, same goes for the gsw driver.     John