Received: by 10.213.65.68 with SMTP id h4csp1603756imn; Thu, 15 Mar 2018 04:41:49 -0700 (PDT) X-Google-Smtp-Source: AG47ELuNuSSC0JZrW4rezWpCbb50SEc5b9Z8H/BoOwxJ0cvyP3nQYkw8lSXUP4I6Fbc9AvX0COxJ X-Received: by 10.99.43.67 with SMTP id r64mr6458091pgr.403.1521114109251; Thu, 15 Mar 2018 04:41:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521114109; cv=none; d=google.com; s=arc-20160816; b=V4VA2vPEDoz4eihhcrgTckOTLQDaulKYwz+44DOdvyrgwolrSysVthTFy5ZF1wTUJA BBuCeiNjWKd2GZHx904WKMqkdIiCA12ETqsMryph+yxLaqJ0uDRwU+O9dsvii9weXShx 1iqL5Ktfm/eqU5uMa1znTwKDsInYuFnD1f/KLBcg4tGs2whblhahtAigGFg3+PmKEjqd sTY2eSkw0r+86rFaZsI6EZBVWQxvUPxfWRF8UmpZGa7YGfPfo22RBmlV/EokxqZJvkIG B/btCUK+fmxPjc/U3+FHw3nVozkbVC71w0esKfeEybiZUxmLe/rT20LLwyB9IC9wyNoi 2DBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from :arc-authentication-results; bh=C9mT61XHHUOEZ/u3F4H6ue0vw8+PqjHBw7obX40coLc=; b=PvHrnz6EJiCbYaPlZXqpx4jxAMYCUSdSEVItmzF2T42jUWTcuYNRUKynfN8NeOKwjc ZbwN5zGUFNymA2WF/oOWYuR/0VrEbQLw9vsvB85LXauPeLNtxRwtsy+oa9Yb7ANVrMXA dUYeqQzGTG2VZpJptQv28vsdCxBvQ2fCpGJrV34AHVJ9f+xeb/EKavGdfhjMX+cJZ2iB 5xt1j7bubNvoyTL8m9MaMX8hVHNY37aa+9/8Z7tPMIvIb2Ixc8QCd36f8SIRwgDBMPd0 bTFqlT9zQ7TJNXRgr1LlegmZZlfpljRsu+IG8A0aM6AbtrjEzSkIy7M3iPbpc1RCUS2d 6UpQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q14si3309211pgr.311.2018.03.15.04.41.31; Thu, 15 Mar 2018 04:41:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751840AbeCOLjN convert rfc822-to-8bit (ORCPT + 99 others); Thu, 15 Mar 2018 07:39:13 -0400 Received: from smtp-out6.electric.net ([192.162.217.183]:50379 "EHLO smtp-out6.electric.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751410AbeCOLjL (ORCPT ); Thu, 15 Mar 2018 07:39:11 -0400 Received: from 1ewRDv-000BlH-VE by out6a.electric.net with emc1-ok (Exim 4.90_1) (envelope-from ) id 1ewRDx-000Bui-Td; Thu, 15 Mar 2018 04:39:09 -0700 Received: by emcmailer; Thu, 15 Mar 2018 04:39:09 -0700 Received: from [156.67.243.126] (helo=AcuMS.aculab.com) by out6a.electric.net with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ewRDv-000BlH-VE; Thu, 15 Mar 2018 04:39:07 -0700 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) by AcuMS.aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Thu, 15 Mar 2018 11:40:05 +0000 Received: from AcuMS.Aculab.com ([fe80::43c:695e:880f:8750]) by AcuMS.aculab.com ([fe80::43c:695e:880f:8750%12]) with mapi id 15.00.1347.000; Thu, 15 Mar 2018 11:40:05 +0000 From: David Laight To: "'Martin K. Petersen'" , Stephen Kitt CC: "hare@suse.com" , "linux-scsi@vger.kernel.org" , "kernel-hardening@lists.openwall.com" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] bfa: remove VLA Thread-Topic: [PATCH] bfa: remove VLA Thread-Index: AQHTvBeGEJGXEa7ONkidGyb1MqLdgqPRLCRg Date: Thu, 15 Mar 2018 11:40:05 +0000 Message-ID: <32130f556f09408686626c50c70b39c9@AcuMS.aculab.com> References: <20180308213841.13807-1-steve@sk2.org> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.33] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Outbound-IP: 156.67.243.126 X-Env-From: David.Laight@ACULAB.COM X-Proto: esmtps X-Revdns: X-HELO: AcuMS.aculab.com X-TLS: TLSv1.2:ECDHE-RSA-AES256-SHA384:256 X-Authenticated_ID: X-PolicySMART: 3396946, 3397078 X-Virus-Status: Scanned by VirusSMART (c) X-Virus-Status: Scanned by VirusSMART (s) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > - sizeof(wwn_t[iocmd->nports])) != BFA_STATUS_OK) { > > + sizeof(wwn_t) * iocmd->nports) != BFA_STATUS_OK) { > > These parentheses made me blurry eyed but it's actually OK. iocmd->nports * sizeof(wwn_t)) != BFA_STATUS_OK) { is easier to focus on :-) David