Received: by 10.213.65.68 with SMTP id h4csp1650404imn; Thu, 15 Mar 2018 05:59:24 -0700 (PDT) X-Google-Smtp-Source: AG47ELtK/umWid2aeGA2QIWYC4NLUSZf/RzA9T1ZAb1aC2llMKQCr4lorICZRZWLCUPQ1Fy98Dpj X-Received: by 2002:a17:902:2862:: with SMTP id e89-v6mr8001694plb.348.1521118764068; Thu, 15 Mar 2018 05:59:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521118764; cv=none; d=google.com; s=arc-20160816; b=v/9zgE/tigj+t4hofbSZ7IUK13VWyweuPPiEmsj1hpsOaX/DEGL9jdnRBi81FlM/a/ OTiIdW7sa/kT7ZK8UJ3Z51rmSiNUsJWo7LxazcYf8cOofu66T5KEtIkWiFXf+YnyTPaE cyBPUWbuKhCxA6Zc6/LBu1ybhlywOD4Ps36jVwDtTjaipS2OqiuI9rW9Th1qr61IU3yW 5ybUyPVY0VVGE7Pv9RkIepFlOoTF3xbobzfv4PSPaCnv8fcFNMVxy1cJSMtGmPek3oqf RJDVZlK0hevMsMA9EyFbXK3PAC22aU9TOLcxcTLZHbJ4jeK+Kr4uE3pf4WZVqUwiZOhD aL+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:references:cc:to:from:subject:dkim-signature :arc-authentication-results; bh=AVike/pCXACxTyDYkpJYqa+ATux5tDjSdEeM7D+0pYs=; b=mGIylTFqCTvJ+8CWdpX8pVnRLEr61fy58ewUIf8UNqeWiAb3XCI1olrpcoYlxq+23x aIZRL/kG8HVvuz8dwgFRcYgET9TCsANpBcq5NH6OjnoHkwW+MfsMJijYfmxuTcuZ7Hki rByxWBo18yCZUIgTG1foOFZHW1QUq0C+b+pu/Q8qdGg99WUHyjcbeOzgSLyae2c28cYt rdEZXMhE8lHo2O5tBs74SucfDSfiq658xpYNatdXD+j6mzXPRzfxArxR2rHT07QtT32+ pc/vTZ5RgZrROvG2Jh9Rx66e36H/Alz6YNjFyt9GDlzD1+KygwSlBVshC7BZpudYNFUp Acsg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=NhpsolmG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o63si3778811pfg.347.2018.03.15.05.59.08; Thu, 15 Mar 2018 05:59:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=NhpsolmG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751981AbeCOM6O (ORCPT + 99 others); Thu, 15 Mar 2018 08:58:14 -0400 Received: from mail-it0-f66.google.com ([209.85.214.66]:37450 "EHLO mail-it0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751529AbeCOM6M (ORCPT ); Thu, 15 Mar 2018 08:58:12 -0400 Received: by mail-it0-f66.google.com with SMTP id k79-v6so9069969ita.2; Thu, 15 Mar 2018 05:58:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=AVike/pCXACxTyDYkpJYqa+ATux5tDjSdEeM7D+0pYs=; b=NhpsolmGT1UVKlMlrV6FxQ46xsS6PffzLaMgziUptfqL48JA3/Eii8E8uQFt0PlHph SUxPZBJa2lD5uTrWb9RqlI2Vh/zdVbQdNxyqYldYFcHeSaPftkK/nUB8ZZS+PjfkBilI 0TK5zOhNfXtYA7WDnBQ9aCH7HE6ZgYw1DtpeeSqj7i6f5FmNZvIOb5CBG2eFTUaP95S6 AMDjL4EwSOu0FTNLm7mh2RRFeKTSJeCspIw6BXbHFlrxrqlxoneHL460ED3yKw0G7yF+ HVc5++Sh4ang167FoNtD0PxR8WgDuOdk4cTKyWi3xp36h9E744rr00lzC8JQj8iMbuai NE4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=AVike/pCXACxTyDYkpJYqa+ATux5tDjSdEeM7D+0pYs=; b=fmjvxMaoaYSjQPpEXjDyeG3E1DyUaznQogzW2khzny0olH39Gkp8+Z7WoNDh97ckrq C8JsIFA5/plWwRmhlC5yAtf7l5YQyxXX3CE2Pb04sJZP5Wj/Uhg2AgUI5Wqy2ZwM1/su duyqctgzQwuFhgtfujE3kwhHhraSsDtwOwSuyDlqOB2U5pA2tFjeYKXUp6E4orzBTkNB YfFEH7KIY9zp8yJGnqvx6pJ/SDVyX5pzPM16efJI+Ep5n3sCn1u3MH3JFNFNSVKmYDyG zSyGI5zXhe3jziHJIgA2NTBnjZGB+2A1Gh6fYdgnZ7ksgqGtOeMlQo1lUZSbHsVZa7/9 mcKA== X-Gm-Message-State: AElRT7HkGEBe1G3QZV8Y9r1DEdZEY5zaJlP/lfx+d5DcU2P/MqmURuYL vFw+stkFteXlGabCN5fhFEEfNhaU X-Received: by 2002:a24:f04d:: with SMTP id p13-v6mr6414614iti.72.1521118691338; Thu, 15 Mar 2018 05:58:11 -0700 (PDT) Received: from [192.168.1.145] (ppp109-252-55-234.pppoe.spdop.ru. [109.252.55.234]) by smtp.googlemail.com with ESMTPSA id b17-v6sm3028339itc.38.2018.03.15.05.58.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Mar 2018 05:58:10 -0700 (PDT) Subject: Re: [PATCH v1 1/3] drm/tegra: plane: Fix RGB565 plane format on older Tegra's From: Dmitry Osipenko To: Thierry Reding Cc: dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org References: <8d9c7220b1d2cf126bd2030e5d232ec06f761440.1521075485.git.digetx@gmail.com> <20180315102700.GA15393@ulmo> <90169117-fc06-7d2d-34bd-af2827240048@gmail.com> Message-ID: Date: Thu, 15 Mar 2018 15:58:03 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <90169117-fc06-7d2d-34bd-af2827240048@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15.03.2018 15:48, Dmitry Osipenko wrote: > On 15.03.2018 13:27, Thierry Reding wrote: >> On Thu, Mar 15, 2018 at 04:00:23AM +0300, Dmitry Osipenko wrote: >>> Simplify opaque format adjustment by removing format checking. There are >>> only 4 formats that require the adjustment and so this way is less error >>> prone, avoiding mishandling native formats, like in this case RGB565 is >>> the format that was erroneously treated as invalid. >>> >>> Fixes: ebae8d07435a ("drm/tegra: dc: Implement legacy blending") >>> Signed-off-by: Dmitry Osipenko >>> --- >>> drivers/gpu/drm/tegra/dc.c | 11 ++--------- >>> drivers/gpu/drm/tegra/plane.c | 21 ++++++--------------- >>> drivers/gpu/drm/tegra/plane.h | 2 +- >>> 3 files changed, 9 insertions(+), 25 deletions(-) >> >> I've applied a slightly different version of this which doesn't rework >> as much of the surrounding code and is therefore easier to backport to >> v4.16. > > Okay. Please don't forget to push the modified patch, I don't see it in the FDO git. See it now.