Received: by 10.213.65.68 with SMTP id h4csp1668053imn; Thu, 15 Mar 2018 06:23:42 -0700 (PDT) X-Google-Smtp-Source: AG47ELs2BpT1csxtO//ldQcONJVSrGjCg442gC5adLg7/68RfFFJNeJ0zeFJjEWs0m6tx6JU6qIk X-Received: by 10.98.205.140 with SMTP id o134mr7795539pfg.34.1521120222227; Thu, 15 Mar 2018 06:23:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521120222; cv=none; d=google.com; s=arc-20160816; b=dzQlryytXelOXVzDhZ7Hc4SooE9CjJ+MR8neAHJ6NK6j2l4U0O4Hc0iG2F0zvbxNZ8 Ldj68Zkhy6RO0ulinLkvUZdE6/rYuyn1rvmoeRPFf2xtLi4JFtqLSuuMYG4wQpRVBHZG IluVz1yzRtJASKSCOBbCKMLSgOb4pK5scRQyi0+NyS2Vdl4pBGqjxomAGbZD19fza1Ts RwZEVzkZoUjsuanfAFMca4SDDtviCQqnIyqWLSw+LVVCQA+QR024wRUrgT7r7ERa7Whr Aplq2pJbrx/G04Gp7LURQ2tsbd2Q9m1/U1YE6/chd977HBjG0pHOQpX2FXtX4GMZ40Br iZ+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=MTY15tb/W+N0NpRrknAFrItoPds3mfihq5lCYa2n4KE=; b=UtAzWQJElL+VS8oug5TPCBLeISEs2LuvmGNFwJXUIYzpUbB8lQDkHWVgRg2jBNPooO aguGJ1oloUd8XOX9C315fL6gixSua4LDlMD0VbhfFPYqAu7Qwr0CHvhE0T7pE+4muDIV z642TsSPso8W58eFS2l3iR35/Yjl4Mv2mresddNlsPW057fQTd9YqI/j/HTkkZxJrdN8 /glyUdXlsAJ/Df8o+shbaiBiAExhAHZd7zCnSp5AcBccYqhvyd0XK33jVTmWw0VJpDAr K4UCfH/aHD3d2zY4bkI5cEpihgc7G3vbqpdbIX2kTGUIXcHDWKuwrt45VIVj3R5/L6by WtBA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o2-v6si3873136pls.46.2018.03.15.06.23.27; Thu, 15 Mar 2018 06:23:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751753AbeCONWP (ORCPT + 99 others); Thu, 15 Mar 2018 09:22:15 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:56890 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751302AbeCONWO (ORCPT ); Thu, 15 Mar 2018 09:22:14 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id BC905FCF; Thu, 15 Mar 2018 13:22:13 +0000 (UTC) Date: Thu, 15 Mar 2018 14:22:13 +0100 From: Greg Kroah-Hartman To: Niklas Cassel Cc: kishon@ti.com, Lorenzo Pieralisi , Arnd Bergmann , Niklas Cassel , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 5/5] misc: pci_endpoint_test: Handle 64-bit BARs properly Message-ID: <20180315132213.GA8629@kroah.com> References: <20180308133331.19464-1-niklas.cassel@axis.com> <20180308133331.19464-6-niklas.cassel@axis.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180308133331.19464-6-niklas.cassel@axis.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 08, 2018 at 02:33:30PM +0100, Niklas Cassel wrote: > A 64-bit BAR consists of a BAR pair, where the second BAR has the > upper bits, so we cannot simply call pci_ioremap_bar() on every single > BAR index. > > The second BAR in a BAR pair will not have the IORESOURCE_MEM resource > flag set. Only call ioremap on BARs that have the IORESOURCE_MEM > resource flag set. > > pci 0000:01:00.0: BAR 4: assigned [mem 0xc0300000-0xc031ffff 64bit] > pci 0000:01:00.0: BAR 2: assigned [mem 0xc0320000-0xc03203ff 64bit] > pci 0000:01:00.0: BAR 0: assigned [mem 0xc0320400-0xc03204ff 64bit] > pci-endpoint-test 0000:01:00.0: can't ioremap BAR 1: [??? 0x00000000 flags 0x0] > pci-endpoint-test 0000:01:00.0: failed to read BAR1 > pci-endpoint-test 0000:01:00.0: can't ioremap BAR 3: [??? 0x00000000 flags 0x0] > pci-endpoint-test 0000:01:00.0: failed to read BAR3 > pci-endpoint-test 0000:01:00.0: can't ioremap BAR 5: [??? 0x00000000 flags 0x0] > pci-endpoint-test 0000:01:00.0: failed to read BAR5 > > Signed-off-by: Niklas Cassel > --- > drivers/misc/pci_endpoint_test.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) Where are the 4 other patches in this series? I can't just only apply the last one, right? Please be careful when sending patches to properly notify everyone... this is now dropped from my patch queue. greg k-h